Remove the RedisObfuscationUtil.Obfuscate() method as it's never used#8202
Merged
andrewlock merged 1 commit intomasterfrom Feb 16, 2026
Merged
Remove the RedisObfuscationUtil.Obfuscate() method as it's never used#8202andrewlock merged 1 commit intomasterfrom
RedisObfuscationUtil.Obfuscate() method as it's never used#8202andrewlock merged 1 commit intomasterfrom
Conversation
pierotibou
approved these changes
Feb 13, 2026
| _normalizerTraceProcessor = new NormalizerTraceProcessor(); | ||
| _trucantorTraceProcessor = new TruncatorTraceProcessor(); | ||
| _obfuscatorTraceProcessor = new ObfuscatorTraceProcessor(true); | ||
| _obfuscatorTraceProcessor = new ObfuscatorTraceProcessor(); |
Contributor
There was a problem hiding this comment.
Clever way of improving our benchmarks ;)
…, and associated code
f90b47c to
a2a3931
Compare
BenchmarksBenchmark execution time: 2026-02-13 18:15:50 Comparing candidate commit a2a3931 in PR branch Found 6 performance improvements and 7 performance regressions! Performance is the same for 170 metrics, 9 unstable metrics. scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1
scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0
scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net472
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Remove dead code from the trace processor paths obfuscation
Reason for change
The code is never called, and it confused me thoroughly, embarrassing me in front of @pierotibou. NEVER AGAIN.
This was originally part of the client-side-stats implementation, but was never enabled (and couldn't be), and in fact shouldn't be, because the agent applies obfuscation anyway.
Implementation details
Start deleting things and stop when I run out.
Test coverage
Deleted some tests, this is just removal so meh