Skip to content

Fix broken build in Rider#8195

Merged
andrewlock merged 1 commit intomasterfrom
andrew/fix-rider-build
Feb 12, 2026
Merged

Fix broken build in Rider#8195
andrewlock merged 1 commit intomasterfrom
andrew/fix-rider-build

Conversation

@andrewlock
Copy link
Member

@andrewlock andrewlock commented Feb 12, 2026

Summary of changes

Fix Datadog.Trace.csproj not loading in Rider

Reason for change

Rider fails to load Datadog.Trace.csproj due to the use of new lines in a property

Implementation details

Remove the new lines

Test coverage

It works, Rider can now load it

@andrewlock andrewlock requested a review from a team as a code owner February 12, 2026 09:07
@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Feb 12, 2026
@andrewlock andrewlock enabled auto-merge (squash) February 12, 2026 09:07
@github-actions github-actions bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Feb 12, 2026
@pr-commenter
Copy link

pr-commenter bot commented Feb 12, 2026

Benchmarks

Benchmark execution time: 2026-02-12 09:47:32

Comparing candidate commit b64872a in PR branch andrew/fix-rider-build with baseline commit 9f017b8 in branch master.

Found 11 performance improvements and 5 performance regressions! Performance is the same for 158 metrics, 18 unstable metrics.

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 execution_time [-19.285ms; -15.108ms] or [-8.946%; -7.008%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+20.298ms; +20.928ms] or [+11.285%; +11.635%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟩 execution_time [-46.319ms; -39.103ms] or [-23.404%; -19.758%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

  • 🟩 execution_time [-89.830µs; -82.916µs] or [-6.100%; -5.630%]
  • 🟩 throughput [+40.637op/s; +43.977op/s] or [+5.984%; +6.476%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

  • 🟩 execution_time [-125.466µs; -112.628µs] or [-6.196%; -5.562%]
  • 🟩 throughput [+29.143op/s; +32.582op/s] or [+5.901%; +6.597%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1

  • 🟩 execution_time [-308.177µs; -262.063µs] or [-7.342%; -6.243%]
  • 🟩 throughput [+15.942op/s; +18.841op/s] or [+6.692%; +7.909%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟩 throughput [+23684.161op/s; +24865.151op/s] or [+8.496%; +8.920%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472

  • 🟩 throughput [+20819.641op/s; +22664.186op/s] or [+7.838%; +8.533%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟥 throughput [-32543.757op/s; -28329.127op/s] or [-7.908%; -6.884%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • 🟩 throughput [+1376.924op/s; +3225.915op/s] or [+6.768%; +15.857%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 throughput [-16551529.733op/s; -15417890.588op/s] or [-6.853%; -6.383%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1

  • 🟥 execution_time [+10.824ms; +16.200ms] or [+5.447%; +8.153%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

  • 🟥 execution_time [+11.833ms; +16.150ms] or [+5.993%; +8.179%]

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Feb 12, 2026

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8195) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration68.24 ± (68.23 - 68.46) ms68.37 ± (68.42 - 68.64) ms+0.2%✅⬆️
.NET Framework 4.8 - Bailout
duration72.22 ± (72.16 - 72.38) ms72.17 ± (72.06 - 72.31) ms-0.1%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1026.49 ± (1027.78 - 1033.13) ms1026.16 ± (1028.57 - 1034.62) ms-0.0%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms22.16 ± (22.14 - 22.19) ms22.10 ± (22.07 - 22.12) ms-0.3%✅
process.time_to_main_ms86.01 ± (85.83 - 86.20) ms85.83 ± (85.65 - 86.01) ms-0.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed15.46 ± (15.46 - 15.46) MB15.48 ± (15.48 - 15.49) MB+0.2%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.06 ± (22.04 - 22.08) ms22.09 ± (22.08 - 22.11) ms+0.2%✅⬆️
process.time_to_main_ms86.83 ± (86.69 - 86.96) ms86.79 ± (86.69 - 86.88) ms-0.0%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed15.52 ± (15.51 - 15.52) MB15.52 ± (15.51 - 15.52) MB-0.0%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms256.99 ± (254.24 - 259.73) ms258.75 ± (256.00 - 261.50) ms+0.7%✅⬆️
process.time_to_main_ms489.77 ± (489.24 - 490.31) ms491.97 ± (491.29 - 492.65) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed52.16 ± (52.13 - 52.19) MB52.17 ± (52.15 - 52.19) MB+0.0%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms20.85 ± (20.83 - 20.88) ms20.88 ± (20.85 - 20.90) ms+0.1%✅⬆️
process.time_to_main_ms74.00 ± (73.86 - 74.13) ms74.10 ± (73.96 - 74.24) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed15.19 ± (15.19 - 15.19) MB15.19 ± (15.19 - 15.20) MB+0.0%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms20.72 ± (20.69 - 20.74) ms20.83 ± (20.80 - 20.85) ms+0.5%✅⬆️
process.time_to_main_ms74.70 ± (74.64 - 74.76) ms75.33 ± (75.24 - 75.41) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed15.31 ± (15.30 - 15.31) MB15.31 ± (15.30 - 15.31) MB-0.0%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms256.75 ± (255.89 - 257.61) ms254.26 ± (253.53 - 254.98) ms-1.0%✅
process.time_to_main_ms470.17 ± (469.55 - 470.79) ms468.41 ± (467.82 - 469.01) ms-0.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed52.97 ± (52.95 - 53.00) MB53.01 ± (52.98 - 53.05) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms18.86 ± (18.83 - 18.89) ms18.80 ± (18.77 - 18.83) ms-0.3%✅
process.time_to_main_ms67.36 ± (67.27 - 67.46) ms67.57 ± (67.44 - 67.70) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.69 ± (7.68 - 7.69) MB7.70 ± (7.70 - 7.71) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms18.85 ± (18.82 - 18.88) ms18.80 ± (18.77 - 18.82) ms-0.3%✅
process.time_to_main_ms68.58 ± (68.48 - 68.68) ms68.46 ± (68.39 - 68.53) ms-0.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.75 ± (7.74 - 7.76) MB7.77 ± (7.76 - 7.78) MB+0.3%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms180.07 ± (179.09 - 181.04) ms178.35 ± (177.58 - 179.12) ms-1.0%✅
process.time_to_main_ms427.77 ± (427.06 - 428.47) ms426.49 ± (425.95 - 427.03) ms-0.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed35.92 ± (35.89 - 35.95) MB35.97 ± (35.94 - 36.00) MB+0.1%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (26 - 27)-0.4%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration204.50 ± (208.40 - 211.97) ms200.92 ± (200.56 - 201.66) ms-1.8%✅
.NET Framework 4.8 - Bailout
duration203.89 ± (203.66 - 204.51) ms203.78 ± (203.68 - 204.66) ms-0.1%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1169.74 ± (1168.23 - 1175.27) ms1168.56 ± (1168.61 - 1175.11) ms-0.1%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms198.15 ± (197.59 - 198.70) ms199.80 ± (199.22 - 200.38) ms+0.8%✅⬆️
process.time_to_main_ms91.53 ± (91.23 - 91.83) ms91.99 ± (91.69 - 92.30) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed20.57 ± (20.55 - 20.59) MB20.59 ± (20.58 - 20.61) MB+0.1%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+1.3%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms198.30 ± (197.80 - 198.81) ms198.89 ± (198.41 - 199.36) ms+0.3%✅⬆️
process.time_to_main_ms92.45 ± (92.20 - 92.70) ms93.31 ± (93.06 - 93.56) ms+0.9%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed20.64 ± (20.62 - 20.66) MB20.65 ± (20.63 - 20.67) MB+0.1%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)+0.0%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms450.36 ± (448.01 - 452.70) ms452.24 ± (449.69 - 454.80) ms+0.4%✅⬆️
process.time_to_main_ms510.49 ± (509.66 - 511.31) ms512.87 ± (511.99 - 513.75) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed62.29 ± (62.19 - 62.40) MB62.26 ± (62.13 - 62.38) MB-0.1%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.1%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms197.74 ± (197.27 - 198.21) ms200.48 ± (199.93 - 201.04) ms+1.4%✅⬆️
process.time_to_main_ms72.10 ± (71.88 - 72.31) ms73.15 ± (72.94 - 73.37) ms+1.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.31 ± (16.28 - 16.33) MB16.28 ± (16.26 - 16.30) MB-0.1%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.5%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms198.58 ± (198.04 - 199.12) ms200.65 ± (199.91 - 201.39) ms+1.0%✅⬆️
process.time_to_main_ms73.69 ± (73.49 - 73.90) ms74.33 ± (74.03 - 74.62) ms+0.9%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.30 ± (16.29 - 16.32) MB16.33 ± (16.30 - 16.35) MB+0.1%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+1.0%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms453.27 ± (449.88 - 456.67) ms458.35 ± (455.49 - 461.20) ms+1.1%✅⬆️
process.time_to_main_ms459.30 ± (458.65 - 459.96) ms463.72 ± (462.85 - 464.59) ms+1.0%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed57.85 ± (57.71 - 57.99) MB57.98 ± (57.84 - 58.11) MB+0.2%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)30 ± (29 - 30)+0.3%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms201.39 ± (200.78 - 202.00) ms201.69 ± (201.15 - 202.24) ms+0.1%✅⬆️
process.time_to_main_ms78.05 ± (77.83 - 78.27) ms78.60 ± (78.34 - 78.86) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.23 ± (16.21 - 16.25) MB16.17 ± (16.16 - 16.19) MB-0.3%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.1%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms200.25 ± (199.70 - 200.80) ms200.82 ± (200.23 - 201.42) ms+0.3%✅⬆️
process.time_to_main_ms78.98 ± (78.78 - 79.18) ms79.62 ± (79.40 - 79.83) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.26 ± (16.24 - 16.27) MB16.25 ± (16.23 - 16.27) MB-0.0%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-0.3%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms385.47 ± (382.40 - 388.54) ms402.88 ± (397.02 - 408.73) ms+4.5%✅⬆️
process.time_to_main_ms469.02 ± (468.33 - 469.72) ms475.21 ± (474.21 - 476.22) ms+1.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed52.62 ± (52.49 - 52.75) MB53.26 ± (53.09 - 53.43) MB+1.2%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.0%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8195) - mean (69ms)  : 67, 70
    master - mean (68ms)  : 67, 70

    section Bailout
    This PR (8195) - mean (72ms)  : 71, 73
    master - mean (72ms)  : 71, 73

    section CallTarget+Inlining+NGEN
    This PR (8195) - mean (1,032ms)  : 989, 1075
    master - mean (1,030ms)  : 992, 1069
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8195) - mean (114ms)  : 110, 117
    master - mean (114ms)  : 110, 118

    section Bailout
    This PR (8195) - mean (114ms)  : 113, 116
    master - mean (114ms)  : 113, 116

    section CallTarget+Inlining+NGEN
    This PR (8195) - mean (777ms)  : 727, 827
    master - mean (771ms)  : 721, 821
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8195) - mean (100ms)  : 98, 102
    master - mean (100ms)  : 98, 102

    section Bailout
    This PR (8195) - mean (101ms)  : 100, 103
    master - mean (100ms)  : 100, 101

    section CallTarget+Inlining+NGEN
    This PR (8195) - mean (761ms)  : 739, 783
    master - mean (763ms)  : 732, 794
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8195) - mean (93ms)  : 90, 95
    master - mean (93ms)  : 89, 97

    section Bailout
    This PR (8195) - mean (94ms)  : 92, 95
    master - mean (94ms)  : 92, 95

    section CallTarget+Inlining+NGEN
    This PR (8195) - mean (642ms)  : 624, 660
    master - mean (636ms)  : 617, 655
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8195) - mean (201ms)  : 193, 209
    master - mean (210ms)  : 185, 236

    section Bailout
    This PR (8195) - mean (204ms)  : 198, 211
    master - mean (204ms)  : 200, 208

    section CallTarget+Inlining+NGEN
    This PR (8195) - mean (1,172ms)  : 1125, 1219
    master - mean (1,172ms)  : 1121, 1222
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8195) - mean (302ms)  : 288, 317
    master - mean (300ms)  : 286, 314

    section Bailout
    This PR (8195) - mean (302ms)  : 292, 312
    master - mean (301ms)  : 292, 310

    section CallTarget+Inlining+NGEN
    This PR (8195) - mean (1,003ms)  : 964, 1042
    master - mean (995ms)  : 952, 1039
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8195) - mean (283ms)  : 272, 294
    master - mean (279ms)  : 270, 287

    section Bailout
    This PR (8195) - mean (285ms)  : 269, 300
    master - mean (281ms)  : 270, 291

    section CallTarget+Inlining+NGEN
    This PR (8195) - mean (953ms)  : 906, 1000
    master - mean (943ms)  : 893, 993
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8195) - mean (291ms)  : 277, 305
    master - mean (291ms)  : 279, 302

    section Bailout
    This PR (8195) - mean (292ms)  : 278, 305
    master - mean (291ms)  : 279, 302

    section CallTarget+Inlining+NGEN
    This PR (8195) - mean (913ms)  : 828, 998
    master - mean (890ms)  : 835, 944
Loading

@andrewlock andrewlock merged commit 62fea04 into master Feb 12, 2026
143 checks passed
@andrewlock andrewlock deleted the andrew/fix-rider-build branch February 12, 2026 13:46
@github-actions github-actions bot added this to the vNext-v3 milestone Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bouwkast bouwkast bouwkast approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)

Projects

None yet

Milestone

3.38.0

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewlock @bouwkast