Skip to content

[Azure Functions] Improve local NuGet build script, follow-up#8188

Merged
lucaspimentel merged 5 commits intomasterfrom
lpimentel/improve-azure-functions-nuget-build-script-2
Feb 13, 2026
Merged

[Azure Functions] Improve local NuGet build script, follow-up#8188
lucaspimentel merged 5 commits intomasterfrom
lpimentel/improve-azure-functions-nuget-build-script-2

Conversation

@lucaspimentel
Copy link
Member

@lucaspimentel lucaspimentel commented Feb 10, 2026

Summary of changes

  • Use separate Nuke verbosity levels for download (quiet) vs build (normal) targets
  • Skip building net461 in local dev script (commented out)
  • add this build script to CODEOWNERS
  • Suppress CheckEolTargetFramework warning about net6.0 EOL

Reason for change

After #8174 changed default verbosity to quiet, the package path output was suppressed, making it harder to locate the generated .nupkg file during local development.

Implementation details

In tracer/tools/Build-AzureFunctionsNuget.ps1, split $nukeVerbosity into two variables:

  • $nukeVerbosityDownload: verbose/quiet for DownloadBundleNugetFromBuild
  • $nukeVerbosityBuild: verbose/normal for BuildAzureFunctionsNuget (shows package path)

Bonus: In tracer/src/Datadog.AzureFunctions/Datadog.AzureFunctions.csproj, removeCheckEolTargetFramework so we inherit false from a parent directory and suppress the net6.0 EOL warning.

Test coverage

Manually tested.

@lucaspimentel lucaspimentel requested a review from a team as a code owner February 10, 2026 18:45
@github-actions github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Feb 10, 2026
@lucaspimentel lucaspimentel changed the title Output Azure Functions NuGet package path [Azure Functions] Output Azure Functions NuGet package path in local dev script build Feb 10, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a9fb6e9d9d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lucaspimentel lucaspimentel force-pushed the lpimentel/improve-azure-functions-nuget-build-script-2 branch from a9fb6e9 to 99238f6 Compare February 10, 2026 19:18
@lucaspimentel lucaspimentel requested a review from a team as a code owner February 10, 2026 19:18
@lucaspimentel lucaspimentel changed the title [Azure Functions] Output Azure Functions NuGet package path in local dev script build Use normal verbosity for Azure Functions build Feb 10, 2026
@lucaspimentel lucaspimentel changed the title Use normal verbosity for Azure Functions build [Azure Functions] Restore normal verbosity for in local build script, log the nupkg path Feb 10, 2026
@lucaspimentel lucaspimentel force-pushed the lpimentel/improve-azure-functions-nuget-build-script-2 branch from 99238f6 to 14525a7 Compare February 10, 2026 19:48
@lucaspimentel lucaspimentel requested a review from a team as a code owner February 10, 2026 19:48
@lucaspimentel lucaspimentel force-pushed the lpimentel/improve-azure-functions-nuget-build-script-2 branch from 14525a7 to e8e87a3 Compare February 10, 2026 19:54
@lucaspimentel lucaspimentel changed the title [Azure Functions] Restore normal verbosity for in local build script, log the nupkg path Improve Azure Functions local build script Feb 10, 2026
@lucaspimentel lucaspimentel removed the request for review from kathiehuang February 10, 2026 19:55
@lucaspimentel lucaspimentel changed the title Improve Azure Functions local build script [Azure Functions] Improve local NuGet build script, follow-up Feb 10, 2026
@lucaspimentel lucaspimentel enabled auto-merge (squash) February 10, 2026 20:01
@pr-commenter

This comment was marked as off-topic.

@dd-trace-dotnet-ci-bot

This comment was marked as off-topic.

@lucaspimentel lucaspimentel force-pushed the lpimentel/improve-azure-functions-nuget-build-script-2 branch 3 times, most recently from d62c1ce to 6b7d007 Compare February 12, 2026 00:21
@pr-commenter

This comment was marked as off-topic.

@dd-trace-dotnet-ci-bot

This comment was marked as off-topic.

Split Nuke verbosity into two variables to control output:
- DownloadBundleNugetFromBuild: verbose/quiet
- BuildAzureFunctionsNuget: verbose/normal (shows package path)

🤖 Co-Authored-By: Claude Code <noreply@anthropic.com>
@lucaspimentel lucaspimentel force-pushed the lpimentel/improve-azure-functions-nuget-build-script-2 branch from 6b7d007 to ceb6cb6 Compare February 12, 2026 20:46
@pr-commenter

This comment was marked as off-topic.

@dd-trace-dotnet-ci-bot

This comment was marked as off-topic.

/tracer/test/Datadog.Trace.ClrProfiler.Managed.Tests/HttpBypassTests.cs @DataDog/tracing-dotnet @DataDog/apm-serverless @DataDog/serverless-azure-and-gcp
/tracer/samples/AzureFunctionsWithAgentLessLogging/ @DataDog/tracing-dotnet @DataDog/apm-serverless @DataDog/serverless-azure-and-gcp
/docs/development/**/AzureFunctions*.md @DataDog/tracing-dotnet @DataDog/apm-serverless @DataDog/serverless-azure-and-gcp
/tracer/tools/Build-AzureFunctionsNuget.ps1 @DataDog/apm-serverless
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally give dual ownership to these, to make it easier to merge when team sizes are small

Suggested change
/tracer/tools/Build-AzureFunctionsNuget.ps1 @DataDog/apm-serverless
/tracer/tools/Build-AzureFunctionsNuget.ps1 @DataDog/tracing-dotnet @DataDog/apm-serverless @DataDog/serverless-azure-and-gcp

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I can update this in #8173.

Comment on lines +48 to +49
$nukeVerbosityDownload = if ($verbose) { 'verbose' } else { 'quiet' }
$nukeVerbosityBuild = if ($verbose) { 'verbose' } else { 'normal' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you really want verbose? Or do you want to keep the same 'normal' as verbose? Because verbose is verbose

Copy link
Member Author

@lucaspimentel lucaspimentel Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only for troubleshooting. Trying to be a good PowerShell citizen following conventions, etc 😅 If you pass -Verbose to the ps1 script, it should be verbose.

Comment on lines +117 to +118
# Write-Verbose "Publishing Datadog.Trace (net461) to bundle folder."
# dotnet publish "$tracerDir/src/Datadog.Trace" -c Release -o "$tracerDir/src/Datadog.Trace.Bundle/home/net461" -f 'net461' -v $dotnetVerbosity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be commented out?

Suggested change
# Write-Verbose "Publishing Datadog.Trace (net461) to bundle folder."
# dotnet publish "$tracerDir/src/Datadog.Trace" -c Release -o "$tracerDir/src/Datadog.Trace.Bundle/home/net461" -f 'net461' -v $dotnetVerbosity
Write-Verbose "Publishing Datadog.Trace (net461) to bundle folder."
dotnet publish "$tracerDir/src/Datadog.Trace" -c Release -o "$tracerDir/src/Datadog.Trace.Bundle/home/net461" -f 'net461' -v $dotnetVerbosity

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny story. We include net461 in the Azure Functions nuget package, but all C# Azure Functions code is behind #if !NETFRAMEWORK, so we don't really support .NET Framework. (I didn't realize this until after the nuget was first released.)

So, for purposes of dev testing (which is what this script is for), building net461 is a waste of time.

@lucaspimentel lucaspimentel merged commit 9d1dcc7 into master Feb 13, 2026
142 checks passed
@lucaspimentel lucaspimentel deleted the lpimentel/improve-azure-functions-nuget-build-script-2 branch February 13, 2026 13:11
@github-actions github-actions bot added this to the vNext-v3 milestone Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages area:serverless

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants