[Azure Functions] Improve local NuGet build script, follow-up#8188
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9fb6e9d9d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a9fb6e9 to
99238f6
Compare
99238f6 to
14525a7
Compare
14525a7 to
e8e87a3
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
d62c1ce to
6b7d007
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Split Nuke verbosity into two variables to control output: - DownloadBundleNugetFromBuild: verbose/quiet - BuildAzureFunctionsNuget: verbose/normal (shows package path) 🤖 Co-Authored-By: Claude Code <noreply@anthropic.com>
6b7d007 to
ceb6cb6
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
| /tracer/test/Datadog.Trace.ClrProfiler.Managed.Tests/HttpBypassTests.cs @DataDog/tracing-dotnet @DataDog/apm-serverless @DataDog/serverless-azure-and-gcp | ||
| /tracer/samples/AzureFunctionsWithAgentLessLogging/ @DataDog/tracing-dotnet @DataDog/apm-serverless @DataDog/serverless-azure-and-gcp | ||
| /docs/development/**/AzureFunctions*.md @DataDog/tracing-dotnet @DataDog/apm-serverless @DataDog/serverless-azure-and-gcp | ||
| /tracer/tools/Build-AzureFunctionsNuget.ps1 @DataDog/apm-serverless |
There was a problem hiding this comment.
We normally give dual ownership to these, to make it easier to merge when team sizes are small
| /tracer/tools/Build-AzureFunctionsNuget.ps1 @DataDog/apm-serverless | |
| /tracer/tools/Build-AzureFunctionsNuget.ps1 @DataDog/tracing-dotnet @DataDog/apm-serverless @DataDog/serverless-azure-and-gcp |
| $nukeVerbosityDownload = if ($verbose) { 'verbose' } else { 'quiet' } | ||
| $nukeVerbosityBuild = if ($verbose) { 'verbose' } else { 'normal' } |
There was a problem hiding this comment.
do you really want verbose? Or do you want to keep the same 'normal' as verbose? Because verbose is verbose
There was a problem hiding this comment.
Only for troubleshooting. Trying to be a good PowerShell citizen following conventions, etc 😅 If you pass -Verbose to the ps1 script, it should be verbose.
| # Write-Verbose "Publishing Datadog.Trace (net461) to bundle folder." | ||
| # dotnet publish "$tracerDir/src/Datadog.Trace" -c Release -o "$tracerDir/src/Datadog.Trace.Bundle/home/net461" -f 'net461' -v $dotnetVerbosity |
There was a problem hiding this comment.
Is this meant to be commented out?
| # Write-Verbose "Publishing Datadog.Trace (net461) to bundle folder." | |
| # dotnet publish "$tracerDir/src/Datadog.Trace" -c Release -o "$tracerDir/src/Datadog.Trace.Bundle/home/net461" -f 'net461' -v $dotnetVerbosity | |
| Write-Verbose "Publishing Datadog.Trace (net461) to bundle folder." | |
| dotnet publish "$tracerDir/src/Datadog.Trace" -c Release -o "$tracerDir/src/Datadog.Trace.Bundle/home/net461" -f 'net461' -v $dotnetVerbosity |
There was a problem hiding this comment.
Funny story. We include net461 in the Azure Functions nuget package, but all C# Azure Functions code is behind #if !NETFRAMEWORK, so we don't really support .NET Framework. (I didn't realize this until after the nuget was first released.)
So, for purposes of dev testing (which is what this script is for), building net461 is a waste of time.
Summary of changes
quiet) vs build (normal) targetsnet461in local dev script (commented out)CODEOWNERSCheckEolTargetFrameworkwarning aboutnet6.0EOLReason for change
After #8174 changed default verbosity to
quiet, the package path output was suppressed, making it harder to locate the generated.nupkgfile during local development.Implementation details
In
tracer/tools/Build-AzureFunctionsNuget.ps1, split$nukeVerbosityinto two variables:$nukeVerbosityDownload:verbose/quietforDownloadBundleNugetFromBuild$nukeVerbosityBuild:verbose/normalforBuildAzureFunctionsNuget(shows package path)Bonus: In
tracer/src/Datadog.AzureFunctions/Datadog.AzureFunctions.csproj, removeCheckEolTargetFrameworkso we inheritfalsefrom a parent directory and suppress thenet6.0EOL warning.Test coverage
Manually tested.