[ASM] Remove unused telemetry tag from waf.request metric by daniel-romano-DD · Pull Request #8160 · DataDog/dd-trace-dotnet

daniel-romano-DD · 2026-02-05T09:21:20Z

Summary of changes

Remove request_excluded tag that was always sent to false from the waf.requests metric.

Reason for change

The tag was optional and as there is no current way of determining if the request has been excluded, it has been deprecated

Implementation details

Test coverage

Other details

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bce597768c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

tracer/src/Datadog.Trace/Telemetry/Metrics/MetricTags.cs

pr-commenter · 2026-02-05T10:43:21Z

Benchmarks

Benchmark execution time: 2026-02-05 21:54:04

Comparing candidate commit e1fa4fb in PR branch dani/asm/remove_unused_telemetry_tag with baseline commit 1953712 in branch master.

Found 12 performance improvements and 8 performance regressions! Performance is the same for 160 metrics, 12 unstable metrics.

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

🟥 execution_time [+23.058ms; +29.130ms] or [+11.687%; +14.765%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472

🟥 execution_time [+11.859ms; +12.354ms] or [+5.928%; +6.176%]
🟥 throughput [-187347.945op/s; -180049.871op/s] or [-5.718%; -5.496%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

🟥 execution_time [+12.282ms; +18.459ms] or [+6.167%; +9.270%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

🟩 execution_time [-20.577ms; -14.430ms] or [-9.550%; -6.697%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

🟩 throughput [+360.928op/s; +366.994op/s] or [+5.425%; +5.516%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

🟩 throughput [+108.653op/s; +136.031op/s] or [+11.089%; +13.883%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

🟥 throughput [-126.739op/s; -92.172op/s] or [-8.236%; -5.990%]
🟩 execution_time [-30.632ms; -26.358ms] or [-14.729%; -12.674%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

🟥 execution_time [+43.008ms; +48.075ms] or [+28.911%; +32.317%]
🟩 throughput [+115.178op/s; +161.045op/s] or [+7.631%; +10.670%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1

🟩 execution_time [-968.379µs; -699.720µs] or [-33.305%; -24.065%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472

🟩 execution_time [-74.163µs; -65.051µs] or [-6.178%; -5.419%]
🟩 throughput [+48.015op/s; +54.521op/s] or [+5.763%; +6.544%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

🟩 execution_time [-14.402ms; -11.498ms] or [-6.863%; -5.479%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

🟩 execution_time [-11.567ms; -11.362ms] or [-5.726%; -5.624%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

🟥 execution_time [+12.844ms; +14.274ms] or [+6.845%; +7.607%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

🟩 execution_time [-16.388ms; -10.761ms] or [-7.797%; -5.120%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

🟩 throughput [+715.015op/s; +1818.124op/s] or [+6.213%; +15.798%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

🟥 execution_time [+10.300ms; +14.228ms] or [+5.145%; +7.106%]

dd-trace-dotnet-ci-bot · 2026-02-05T10:46:10Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8160) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	68.25 ± (68.25 - 68.47) ms	68.14 ± (68.11 - 68.34) ms	-0.2%	✅
.NET Framework 4.8 - Bailout
duration	72.28 ± (72.15 - 72.40) ms	72.01 ± (71.95 - 72.10) ms	-0.4%	✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1047.91 ± (1046.84 - 1055.96) ms	1026.80 ± (1031.74 - 1040.65) ms	-2.0%	✅
.NET Core 3.1 - Baseline
process.internal_duration_ms	22.64 ± (22.60 - 22.68) ms	22.24 ± (22.20 - 22.27) ms	-1.8%	✅
process.time_to_main_ms	86.62 ± (86.46 - 86.78) ms	86.27 ± (86.12 - 86.42) ms	-0.4%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	15.50 ± (15.50 - 15.51) MB	15.52 ± (15.51 - 15.52) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	12 ± (12 - 12)	12 ± (12 - 12)	+0.0%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	22.53 ± (22.50 - 22.57) ms	22.20 ± (22.19 - 22.22) ms	-1.5%	✅
process.time_to_main_ms	87.59 ± (87.47 - 87.72) ms	87.45 ± (87.34 - 87.56) ms	-0.2%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	15.56 ± (15.56 - 15.57) MB	15.55 ± (15.54 - 15.55) MB	-0.1%	✅
runtime.dotnet.threads.count	13 ± (13 - 13)	13 ± (13 - 13)	+0.0%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	260.20 ± (256.76 - 263.64) ms	262.13 ± (259.14 - 265.12) ms	+0.7%	✅⬆️
process.time_to_main_ms	503.05 ± (502.48 - 503.62) ms	504.13 ± (503.64 - 504.62) ms	+0.2%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	53.20 ± (53.17 - 53.22) MB	53.31 ± (53.29 - 53.33) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	+0.0%	✅
.NET 6 - Baseline
process.internal_duration_ms	21.00 ± (20.97 - 21.02) ms	20.98 ± (20.96 - 21.01) ms	-0.1%	✅
process.time_to_main_ms	74.18 ± (74.07 - 74.29) ms	74.44 ± (74.31 - 74.56) ms	+0.3%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	15.22 ± (15.22 - 15.22) MB	15.23 ± (15.23 - 15.23) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 6 - Bailout
process.internal_duration_ms	20.91 ± (20.89 - 20.94) ms	20.90 ± (20.88 - 20.92) ms	-0.1%	✅
process.time_to_main_ms	75.30 ± (75.23 - 75.37) ms	75.38 ± (75.31 - 75.46) ms	+0.1%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	15.33 ± (15.33 - 15.34) MB	15.34 ± (15.34 - 15.35) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	254.61 ± (253.69 - 255.53) ms	251.93 ± (251.22 - 252.64) ms	-1.1%	✅
process.time_to_main_ms	479.93 ± (479.29 - 480.57) ms	479.31 ± (478.78 - 479.84) ms	-0.1%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	54.02 ± (53.99 - 54.05) MB	54.08 ± (54.05 - 54.11) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	+0.0%	✅
.NET 8 - Baseline
process.internal_duration_ms	19.23 ± (19.20 - 19.26) ms	19.32 ± (19.29 - 19.34) ms	+0.4%	✅⬆️
process.time_to_main_ms	73.42 ± (73.31 - 73.54) ms	73.60 ± (73.50 - 73.70) ms	+0.2%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	12.25 ± (12.24 - 12.26) MB	12.27 ± (12.26 - 12.27) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	19.17 ± (19.15 - 19.19) ms	19.22 ± (19.20 - 19.25) ms	+0.3%	✅⬆️
process.time_to_main_ms	74.74 ± (74.67 - 74.80) ms	74.63 ± (74.57 - 74.69) ms	-0.1%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	12.29 ± (12.28 - 12.30) MB	12.32 ± (12.31 - 12.33) MB	+0.3%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	181.04 ± (180.17 - 181.90) ms	181.43 ± (180.66 - 182.21) ms	+0.2%	✅⬆️
process.time_to_main_ms	459.77 ± (459.27 - 460.26) ms	459.89 ± (459.43 - 460.35) ms	+0.0%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	41.23 ± (41.21 - 41.25) MB	41.23 ± (41.20 - 41.26) MB	-0.0%	✅
runtime.dotnet.threads.count	27 ± (27 - 27)	27 ± (27 - 27)	-0.5%	✅

HttpMessageHandler

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	203.29 ± (203.30 - 204.19) ms	208.26 ± (208.22 - 209.37) ms	+2.4%	✅⬆️
.NET Framework 4.8 - Bailout
duration	209.24 ± (209.10 - 210.23) ms	211.28 ± (211.01 - 211.98) ms	+1.0%	✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1202.45 ± (1200.86 - 1209.12) ms	1192.96 ± (1191.34 - 1199.67) ms	-0.8%	✅
.NET Core 3.1 - Baseline
process.internal_duration_ms	203.14 ± (202.65 - 203.63) ms	202.37 ± (201.77 - 202.98) ms	-0.4%	✅
process.time_to_main_ms	94.02 ± (93.74 - 94.30) ms	93.83 ± (93.55 - 94.12) ms	-0.2%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	20.64 ± (20.62 - 20.65) MB	20.61 ± (20.60 - 20.63) MB	-0.1%	✅
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (20 - 20)	+0.0%	✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms	204.83 ± (204.12 - 205.53) ms	206.28 ± (205.61 - 206.95) ms	+0.7%	✅⬆️
process.time_to_main_ms	96.31 ± (96.00 - 96.61) ms	96.53 ± (96.21 - 96.84) ms	+0.2%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	20.63 ± (20.61 - 20.64) MB	20.59 ± (20.58 - 20.61) MB	-0.2%	✅
runtime.dotnet.threads.count	21 ± (21 - 21)	21 ± (21 - 21)	-0.5%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	464.02 ± (461.25 - 466.80) ms	457.30 ± (454.16 - 460.44) ms	-1.4%	✅
process.time_to_main_ms	542.49 ± (541.10 - 543.88) ms	535.68 ± (534.39 - 536.98) ms	-1.3%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	62.84 ± (62.69 - 63.00) MB	63.18 ± (63.03 - 63.33) MB	+0.5%	✅⬆️
runtime.dotnet.threads.count	30 ± (29 - 30)	29 ± (29 - 30)	-0.1%	✅
.NET 6 - Baseline
process.internal_duration_ms	216.87 ± (215.77 - 217.96) ms	210.88 ± (210.12 - 211.65) ms	-2.8%	✅
process.time_to_main_ms	85.24 ± (84.88 - 85.60) ms	82.29 ± (82.01 - 82.56) ms	-3.5%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	20.73 ± (20.72 - 20.74) MB	20.75 ± (20.73 - 20.77) MB	+0.1%	✅⬆️
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (20 - 20)	-0.2%	✅
.NET 6 - Bailout
process.internal_duration_ms	214.66 ± (213.96 - 215.36) ms	205.94 ± (205.37 - 206.51) ms	-4.1%	✅
process.time_to_main_ms	85.99 ± (85.72 - 86.27) ms	81.92 ± (81.69 - 82.15) ms	-4.7%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	20.79 ± (20.77 - 20.80) MB	20.89 ± (20.87 - 20.90) MB	+0.5%	✅⬆️
runtime.dotnet.threads.count	21 ± (21 - 21)	20 ± (20 - 21)	-0.7%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	494.29 ± (490.64 - 497.94) ms	475.89 ± (474.03 - 477.75) ms	-3.7%	✅
process.time_to_main_ms	523.17 ± (521.89 - 524.45) ms	503.06 ± (502.01 - 504.10) ms	-3.8%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	62.41 ± (62.30 - 62.53) MB	62.72 ± (62.61 - 62.83) MB	+0.5%	✅⬆️
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	-0.5%	✅
.NET 8 - Baseline
process.internal_duration_ms	223.52 ± (221.85 - 225.19) ms	204.30 ± (203.76 - 204.83) ms	-8.6%	✅
process.time_to_main_ms	85.93 ± (85.52 - 86.33) ms	80.05 ± (79.82 - 80.28) ms	-6.8%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	15.98 ± (15.96 - 16.00) MB	16.18 ± (16.16 - 16.19) MB	+1.3%	✅⬆️
runtime.dotnet.threads.count	19 ± (19 - 19)	19 ± (19 - 19)	-0.2%	✅
.NET 8 - Bailout
process.internal_duration_ms	225.16 ± (223.82 - 226.49) ms	203.85 ± (203.29 - 204.41) ms	-9.5%	✅
process.time_to_main_ms	87.80 ± (87.46 - 88.13) ms	81.47 ± (81.28 - 81.65) ms	-7.2%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.03 ± (16.01 - 16.04) MB	16.22 ± (16.21 - 16.23) MB	+1.2%	✅⬆️
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (20 - 20)	-0.2%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	466.60 ± (459.52 - 473.69) ms	416.97 ± (409.79 - 424.15) ms	-10.6%	✅
process.time_to_main_ms	503.58 ± (502.54 - 504.62) ms	490.63 ± (489.43 - 491.83) ms	-2.6%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	55.17 ± (55.13 - 55.21) MB	54.47 ± (54.32 - 54.63) MB	-1.3%	✅
runtime.dotnet.threads.count	29 ± (29 - 29)	29 ± (29 - 29)	-0.0%	✅

Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts

FakeDbCommand (.NET Framework 4.8)

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8160) - mean (68ms)  : 67, 70
    master - mean (68ms)  : 67, 70

    section Bailout
    This PR (8160) - mean (72ms)  : 71, 73
    master - mean (72ms)  : 71, 74

    section CallTarget+Inlining+NGEN
    This PR (8160) - mean (1,036ms)  : 972, 1100
    master - mean (1,051ms)  : 985, 1118

FakeDbCommand (.NET Core 3.1)

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8160) - mean (115ms)  : 112, 117
    master - mean (115ms)  : 112, 118

    section Bailout
    This PR (8160) - mean (115ms)  : 114, 117
    master - mean (116ms)  : 114, 118

    section CallTarget+Inlining+NGEN
    This PR (8160) - mean (799ms)  : 751, 847
    master - mean (796ms)  : 731, 860

FakeDbCommand (.NET 6)

gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8160) - mean (101ms)  : 99, 102
    master - mean (101ms)  : 98, 103

    section Bailout
    This PR (8160) - mean (102ms)  : 100, 103
    master - mean (101ms)  : 100, 102

    section CallTarget+Inlining+NGEN
    This PR (8160) - mean (768ms)  : 748, 789
    master - mean (770ms)  : 746, 795

FakeDbCommand (.NET 8)

gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8160) - mean (100ms)  : 97, 102
    master - mean (99ms)  : 96, 102

    section Bailout
    This PR (8160) - mean (100ms)  : 99, 102
    master - mean (100ms)  : 99, 102

    section CallTarget+Inlining+NGEN
    This PR (8160) - mean (672ms)  : 652, 691
    master - mean (672ms)  : 653, 690

HttpMessageHandler (.NET Framework 4.8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8160) - mean (209ms)  : 201, 217
    master - mean (204ms)  : 198, 210

    section Bailout
    This PR (8160) - mean (211ms)  : 205, 218
    master - mean (210ms)  : 201, 218

    section CallTarget+Inlining+NGEN
    This PR (8160) - mean (1,196ms)  : 1135, 1256
    master - mean (1,205ms)  : 1143, 1267

HttpMessageHandler (.NET Core 3.1)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8160) - mean (307ms)  : 295, 319
    master - mean (308ms)  : 298, 318

    section Bailout
    This PR (8160) - mean (313ms)  : 301, 326
    master - mean (312ms)  : 295, 328

    section CallTarget+Inlining+NGEN
    This PR (8160) - mean (1,036ms)  : 982, 1090
    master - mean (1,044ms)  : 991, 1097

HttpMessageHandler (.NET 6)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8160) - mean (303ms)  : 289, 317
    master - mean (313ms)  : 289, 337

    section Bailout
    This PR (8160) - mean (298ms)  : 284, 311
    master - mean (311ms)  : 295, 326

    section CallTarget+Inlining+NGEN
    This PR (8160) - mean (1,018ms)  : 982, 1055
    master - mean (1,057ms)  : 991, 1122

HttpMessageHandler (.NET 8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8160) - mean (296ms)  : 284, 307
    master - mean (323ms)  : 296, 349

    section Bailout
    This PR (8160) - mean (296ms)  : 284, 308
    master - mean (326ms)  : 297, 354

    section CallTarget+Inlining+NGEN
    This PR (8160) - mean (948ms)  : 837, 1059
    master - mean (1,007ms)  : 901, 1113

andrewlock

Thanks!

tracer/test/Datadog.Trace.Tests/Telemetry/Metrics/common_metrics.json

Remove tag from test Fix test restore config file Cleanup

daniel-romano-DD requested a review from a team as a code owner February 5, 2026 09:21

daniel-romano-DD added the area:asm label Feb 5, 2026

github-actions bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Feb 5, 2026

chatgpt-codex-connector bot reviewed Feb 5, 2026

View reviewed changes

tracer/src/Datadog.Trace/Telemetry/Metrics/MetricTags.cs Show resolved Hide resolved

daniel-romano-DD requested a review from a team as a code owner February 5, 2026 09:57

daniel-romano-DD enabled auto-merge (squash) February 5, 2026 10:01

e-n-0 approved these changes Feb 5, 2026

View reviewed changes

andrewlock approved these changes Feb 5, 2026

View reviewed changes

tracer/test/Datadog.Trace.Tests/Telemetry/Metrics/common_metrics.json Show resolved Hide resolved

daniel-romano-DD disabled auto-merge February 5, 2026 11:24

daniel-romano-DD force-pushed the dani/asm/remove_unused_telemetry_tag branch from 9a61768 to 58de8ef Compare February 5, 2026 11:33

daniel-romano-DD requested a review from a team as a code owner February 5, 2026 11:33

e-n-0 approved these changes Feb 5, 2026

View reviewed changes

daniel-romano-DD enabled auto-merge (squash) February 5, 2026 17:29

daniel-romano-DD added 2 commits February 5, 2026 22:10

Remove unused / deprecated tag

ef379ba

Remove tag from test Fix test restore config file Cleanup

Add deprecated tags

e1fa4fb

daniel-romano-DD force-pushed the dani/asm/remove_unused_telemetry_tag branch from b7a07c4 to e1fa4fb Compare February 5, 2026 21:10

daniel-romano-DD merged commit 57f90c1 into master Feb 5, 2026
141 checks passed

daniel-romano-DD deleted the dani/asm/remove_unused_telemetry_tag branch February 5, 2026 22:22

github-actions bot added this to the vNext-v3 milestone Feb 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ASM] Remove unused telemetry tag from waf.request metric#8160

[ASM] Remove unused telemetry tag from waf.request metric#8160
daniel-romano-DD merged 2 commits intomasterfrom
dani/asm/remove_unused_telemetry_tag

daniel-romano-DD commented Feb 5, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

pr-commenter bot commented Feb 5, 2026 •

edited

Loading

Uh oh!

dd-trace-dotnet-ci-bot bot commented Feb 5, 2026 •

edited

Loading

FakeDbCommand

HttpMessageHandler

Uh oh!

andrewlock left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

daniel-romano-DD commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

pr-commenter bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

Uh oh!

dd-trace-dotnet-ci-bot bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Execution-Time Benchmarks Report ⏱️

FakeDbCommand

HttpMessageHandler

Uh oh!

andrewlock left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

daniel-romano-DD commented Feb 5, 2026 •

edited

Loading

pr-commenter bot commented Feb 5, 2026 •

edited

Loading

dd-trace-dotnet-ci-bot bot commented Feb 5, 2026 •

edited

Loading