[ASM] Custom data classification#8155
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d577c6e740
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tracer/test/Datadog.Trace.Security.IntegrationTests/AspNetCore5ProcessorOverrides.cs
Outdated
Show resolved
Hide resolved
BenchmarksBenchmark execution time: 2026-02-05 09:46:48 Comparing candidate commit 7875af9 in PR branch Found 12 performance improvements and 4 performance regressions! Performance is the same for 163 metrics, 13 unstable metrics. scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1
scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8155) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8155) - mean (68ms) : 67, 70
master - mean (68ms) : 67, 70
section Bailout
This PR (8155) - mean (72ms) : 71, 74
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (8155) - mean (1,028ms) : 987, 1069
master - mean (1,040ms) : 978, 1102
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8155) - mean (115ms) : 112, 119
master - mean (115ms) : 112, 118
section Bailout
This PR (8155) - mean (116ms) : 114, 117
master - mean (116ms) : 114, 118
section CallTarget+Inlining+NGEN
This PR (8155) - mean (805ms) : 757, 854
master - mean (799ms) : 743, 855
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8155) - mean (101ms) : 98, 103
master - mean (101ms) : 98, 104
section Bailout
This PR (8155) - mean (102ms) : 101, 103
master - mean (102ms) : 101, 103
section CallTarget+Inlining+NGEN
This PR (8155) - mean (770ms) : 746, 794
master - mean (771ms) : 751, 792
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8155) - mean (99ms) : 97, 102
master - mean (100ms) : 98, 102
section Bailout
This PR (8155) - mean (101ms) : 99, 102
master - mean (101ms) : 100, 102
section CallTarget+Inlining+NGEN
This PR (8155) - mean (680ms) : 658, 703
master - mean (683ms) : 663, 703
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8155) - mean (198ms) : 192, 204
master - mean (199ms) : 194, 204
section Bailout
This PR (8155) - mean (203ms) : 197, 209
master - mean (203ms) : 198, 208
section CallTarget+Inlining+NGEN
This PR (8155) - mean (1,168ms) : 1118, 1218
master - mean (1,164ms) : 1109, 1219
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8155) - mean (295ms) : 288, 301
master - mean (296ms) : 289, 302
section Bailout
This PR (8155) - mean (295ms) : 290, 299
master - mean (295ms) : 290, 300
section CallTarget+Inlining+NGEN
This PR (8155) - mean (993ms) : 944, 1043
master - mean (996ms) : 935, 1057
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8155) - mean (286ms) : 279, 294
master - mean (288ms) : 278, 299
section Bailout
This PR (8155) - mean (288ms) : 282, 294
master - mean (287ms) : 281, 293
section CallTarget+Inlining+NGEN
This PR (8155) - mean (992ms) : 953, 1032
master - mean (990ms) : 945, 1035
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8155) - mean (285ms) : 278, 293
master - mean (288ms) : 279, 297
section Bailout
This PR (8155) - mean (285ms) : 279, 292
master - mean (286ms) : 281, 291
section CallTarget+Inlining+NGEN
This PR (8155) - mean (886ms) : 855, 918
master - mean (887ms) : 861, 913
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Numerics; | ||
| using System.Security.Cryptography; |
There was a problem hiding this comment.
I really don't know why VS keeps adding these kind of useless usings
Summary of changes
Added remote configuration capabilities:
CAPABILITY_ASM_PROCESSOR_OVERRIDES (16)
CAPABILITY_ASM_CUSTOM_DATA_SCANNERS (17)
These capabilities inform remote config that this tracer version supports processor overrides and custom data scanners, allowing remote config to send these configurations.
Reason for change
RFC
Implementation details
Test coverage
Added integration tests
Other details