Skip to content

[ASM] Custom data classification#8155

Merged
daniel-romano-DD merged 3 commits intomasterfrom
dani/asm/custom_data_classification
Feb 5, 2026
Merged

[ASM] Custom data classification#8155
daniel-romano-DD merged 3 commits intomasterfrom
dani/asm/custom_data_classification

Conversation

@daniel-romano-DD
Copy link
Contributor

Summary of changes

Added remote configuration capabilities:
CAPABILITY_ASM_PROCESSOR_OVERRIDES (16)
CAPABILITY_ASM_CUSTOM_DATA_SCANNERS (17)
These capabilities inform remote config that this tracer version supports processor overrides and custom data scanners, allowing remote config to send these configurations.

Reason for change

RFC

Implementation details

Test coverage

Added integration tests

Other details

@daniel-romano-DD daniel-romano-DD requested a review from a team as a code owner February 4, 2026 14:34
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d577c6e740

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@pr-commenter
Copy link

pr-commenter bot commented Feb 4, 2026

Benchmarks

Benchmark execution time: 2026-02-05 09:46:48

Comparing candidate commit 7875af9 in PR branch dani/asm/custom_data_classification with baseline commit e76a1dc in branch master.

Found 12 performance improvements and 4 performance regressions! Performance is the same for 163 metrics, 13 unstable metrics.

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 execution_time [+12.099ms; +15.683ms] or [+6.036%; +7.824%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟥 execution_time [+21.182ms; +25.446ms] or [+10.836%; +13.018%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 throughput [-549.577op/s; -527.593op/s] or [-8.053%; -7.731%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟩 execution_time [-22.634ms; -21.135ms] or [-11.203%; -10.461%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1

  • 🟩 execution_time [-70.937µs; -36.572µs] or [-14.338%; -7.392%]
  • 🟩 throughput [+152.177op/s; +273.091op/s] or [+7.397%; +13.274%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1

  • 🟩 execution_time [-25.723ms; -19.423ms] or [-20.519%; -15.494%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟩 execution_time [-56.205ms; -48.987ms] or [-22.054%; -19.222%]
  • 🟩 throughput [+147.279op/s; +180.756op/s] or [+15.599%; +19.145%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1

  • 🟩 execution_time [-154.637µs; -147.216µs] or [-5.314%; -5.059%]
  • 🟩 throughput [+18.326op/s; +19.272op/s] or [+5.333%; +5.608%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0

  • 🟩 execution_time [-89.067µs; -76.853µs] or [-7.826%; -6.753%]
  • 🟩 throughput [+64.350op/s; +73.653op/s] or [+7.323%; +8.382%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 execution_time [-15.710ms; -11.571ms] or [-7.340%; -5.407%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • 🟩 execution_time [-19.961ms; -16.553ms] or [-9.282%; -7.697%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟥 execution_time [+13.268ms; +19.007ms] or [+6.662%; +9.543%]

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Feb 4, 2026

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8155) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration68.27 ± (68.30 - 68.54) ms68.30 ± (68.27 - 68.50) ms+0.1%✅⬆️
.NET Framework 4.8 - Bailout
duration72.25 ± (72.19 - 72.43) ms72.08 ± (72.05 - 72.35) ms-0.2%
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1033.04 ± (1035.71 - 1044.32) ms1024.45 ± (1025.17 - 1030.87) ms-0.8%
.NET Core 3.1 - Baseline
process.internal_duration_ms22.47 ± (22.44 - 22.50) ms22.46 ± (22.42 - 22.50) ms-0.1%
process.time_to_main_ms86.94 ± (86.79 - 87.08) ms86.66 ± (86.49 - 86.83) ms-0.3%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed15.53 ± (15.53 - 15.53) MB15.53 ± (15.53 - 15.53) MB+0.0%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%
.NET Core 3.1 - Bailout
process.internal_duration_ms22.45 ± (22.42 - 22.47) ms22.34 ± (22.31 - 22.36) ms-0.5%
process.time_to_main_ms87.91 ± (87.81 - 88.01) ms87.79 ± (87.68 - 87.90) ms-0.1%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed15.57 ± (15.57 - 15.57) MB15.57 ± (15.56 - 15.57) MB-0.0%
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms257.57 ± (254.24 - 260.90) ms263.23 ± (260.62 - 265.84) ms+2.2%✅⬆️
process.time_to_main_ms504.60 ± (504.09 - 505.11) ms506.48 ± (505.97 - 506.99) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed53.32 ± (53.30 - 53.35) MB53.31 ± (53.29 - 53.33) MB-0.0%
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%
.NET 6 - Baseline
process.internal_duration_ms20.96 ± (20.93 - 20.99) ms21.08 ± (21.06 - 21.11) ms+0.6%✅⬆️
process.time_to_main_ms74.57 ± (74.42 - 74.71) ms74.52 ± (74.39 - 74.65) ms-0.1%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed15.23 ± (15.23 - 15.24) MB15.24 ± (15.24 - 15.24) MB+0.0%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 6 - Bailout
process.internal_duration_ms20.92 ± (20.89 - 20.95) ms21.02 ± (20.99 - 21.04) ms+0.5%✅⬆️
process.time_to_main_ms75.64 ± (75.56 - 75.71) ms75.55 ± (75.50 - 75.60) ms-0.1%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed15.34 ± (15.34 - 15.34) MB15.35 ± (15.34 - 15.35) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms253.41 ± (252.63 - 254.19) ms252.79 ± (252.08 - 253.51) ms-0.2%
process.time_to_main_ms479.64 ± (479.17 - 480.11) ms479.91 ± (479.38 - 480.44) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed54.06 ± (54.02 - 54.10) MB54.16 ± (54.13 - 54.19) MB+0.2%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.2%
.NET 8 - Baseline
process.internal_duration_ms19.26 ± (19.23 - 19.29) ms19.27 ± (19.24 - 19.29) ms+0.1%✅⬆️
process.time_to_main_ms74.05 ± (73.90 - 74.20) ms73.55 ± (73.43 - 73.68) ms-0.7%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed12.28 ± (12.27 - 12.29) MB12.28 ± (12.28 - 12.29) MB+0.0%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 8 - Bailout
process.internal_duration_ms19.27 ± (19.23 - 19.30) ms19.20 ± (19.18 - 19.23) ms-0.3%
process.time_to_main_ms75.22 ± (75.13 - 75.31) ms74.83 ± (74.69 - 74.97) ms-0.5%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed12.31 ± (12.31 - 12.32) MB12.33 ± (12.32 - 12.34) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms181.92 ± (181.15 - 182.68) ms182.11 ± (181.20 - 183.01) ms+0.1%✅⬆️
process.time_to_main_ms459.81 ± (459.31 - 460.31) ms460.01 ± (459.45 - 460.58) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed41.31 ± (41.28 - 41.33) MB41.27 ± (41.25 - 41.30) MB-0.1%
runtime.dotnet.threads.count27 ± (27 - 27)26 ± (26 - 26)-0.1%

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration198.20 ± (198.17 - 199.09) ms197.36 ± (197.67 - 198.65) ms-0.4%
.NET Framework 4.8 - Bailout
duration202.72 ± (202.47 - 203.46) ms202.61 ± (202.51 - 203.50) ms-0.1%
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1159.85 ± (1160.27 - 1167.60) ms1164.53 ± (1164.28 - 1171.22) ms+0.4%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms195.47 ± (195.07 - 195.88) ms194.65 ± (194.26 - 195.03) ms-0.4%
process.time_to_main_ms90.63 ± (90.37 - 90.90) ms90.45 ± (90.20 - 90.70) ms-0.2%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed20.73 ± (20.71 - 20.75) MB20.61 ± (20.58 - 20.63) MB-0.6%
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.0%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms194.32 ± (193.97 - 194.67) ms193.90 ± (193.56 - 194.23) ms-0.2%
process.time_to_main_ms91.34 ± (91.12 - 91.56) ms91.09 ± (90.95 - 91.23) ms-0.3%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed20.79 ± (20.76 - 20.81) MB20.69 ± (20.67 - 20.71) MB-0.5%
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)-1.0%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms445.16 ± (442.45 - 447.88) ms440.25 ± (437.03 - 443.47) ms-1.1%
process.time_to_main_ms516.72 ± (515.96 - 517.48) ms514.71 ± (514.01 - 515.41) ms-0.4%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed63.34 ± (63.22 - 63.45) MB63.63 ± (63.52 - 63.73) MB+0.5%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.0%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms200.37 ± (199.94 - 200.81) ms198.46 ± (198.04 - 198.88) ms-1.0%
process.time_to_main_ms78.25 ± (78.06 - 78.45) ms78.42 ± (78.26 - 78.59) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed20.90 ± (20.88 - 20.92) MB20.90 ± (20.88 - 20.92) MB-0.0%
runtime.dotnet.threads.count19 ± (19 - 20)19 ± (19 - 19)-0.1%
.NET 6 - Bailout
process.internal_duration_ms198.72 ± (198.31 - 199.14) ms199.06 ± (198.61 - 199.50) ms+0.2%✅⬆️
process.time_to_main_ms79.26 ± (79.08 - 79.43) ms79.60 ± (79.44 - 79.76) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed20.97 ± (20.94 - 20.99) MB20.98 ± (20.95 - 21.01) MB+0.1%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 21)+0.7%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms465.84 ± (463.42 - 468.26) ms465.37 ± (463.80 - 466.95) ms-0.1%
process.time_to_main_ms490.54 ± (489.94 - 491.14) ms490.07 ± (489.42 - 490.71) ms-0.1%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed63.12 ± (62.99 - 63.25) MB63.11 ± (63.00 - 63.22) MB-0.0%
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.0%
.NET 8 - Baseline
process.internal_duration_ms199.28 ± (198.83 - 199.73) ms196.94 ± (196.47 - 197.41) ms-1.2%
process.time_to_main_ms78.35 ± (78.14 - 78.56) ms77.71 ± (77.50 - 77.92) ms-0.8%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.35 ± (16.33 - 16.36) MB16.30 ± (16.28 - 16.32) MB-0.3%
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.1%
.NET 8 - Bailout
process.internal_duration_ms196.63 ± (196.22 - 197.05) ms195.70 ± (195.29 - 196.11) ms-0.5%
process.time_to_main_ms78.96 ± (78.81 - 79.11) ms78.96 ± (78.76 - 79.15) ms-0.0%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.42 ± (16.39 - 16.44) MB16.37 ± (16.35 - 16.40) MB-0.3%
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.0%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms378.45 ± (376.98 - 379.91) ms376.77 ± (375.31 - 378.24) ms-0.4%
process.time_to_main_ms474.34 ± (473.63 - 475.06) ms476.03 ± (475.44 - 476.61) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed52.97 ± (52.92 - 53.02) MB52.96 ± (52.90 - 53.01) MB-0.0%
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.0%
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8)
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8155) - mean (68ms)  : 67, 70
    master - mean (68ms)  : 67, 70

    section Bailout
    This PR (8155) - mean (72ms)  : 71, 74
    master - mean (72ms)  : 71, 73

    section CallTarget+Inlining+NGEN
    This PR (8155) - mean (1,028ms)  : 987, 1069
    master - mean (1,040ms)  : 978, 1102

Loading
FakeDbCommand (.NET Core 3.1)
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8155) - mean (115ms)  : 112, 119
    master - mean (115ms)  : 112, 118

    section Bailout
    This PR (8155) - mean (116ms)  : 114, 117
    master - mean (116ms)  : 114, 118

    section CallTarget+Inlining+NGEN
    This PR (8155) - mean (805ms)  : 757, 854
    master - mean (799ms)  : 743, 855

Loading
FakeDbCommand (.NET 6)
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8155) - mean (101ms)  : 98, 103
    master - mean (101ms)  : 98, 104

    section Bailout
    This PR (8155) - mean (102ms)  : 101, 103
    master - mean (102ms)  : 101, 103

    section CallTarget+Inlining+NGEN
    This PR (8155) - mean (770ms)  : 746, 794
    master - mean (771ms)  : 751, 792

Loading
FakeDbCommand (.NET 8)
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8155) - mean (99ms)  : 97, 102
    master - mean (100ms)  : 98, 102

    section Bailout
    This PR (8155) - mean (101ms)  : 99, 102
    master - mean (101ms)  : 100, 102

    section CallTarget+Inlining+NGEN
    This PR (8155) - mean (680ms)  : 658, 703
    master - mean (683ms)  : 663, 703

Loading
HttpMessageHandler (.NET Framework 4.8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8155) - mean (198ms)  : 192, 204
    master - mean (199ms)  : 194, 204

    section Bailout
    This PR (8155) - mean (203ms)  : 197, 209
    master - mean (203ms)  : 198, 208

    section CallTarget+Inlining+NGEN
    This PR (8155) - mean (1,168ms)  : 1118, 1218
    master - mean (1,164ms)  : 1109, 1219

Loading
HttpMessageHandler (.NET Core 3.1)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8155) - mean (295ms)  : 288, 301
    master - mean (296ms)  : 289, 302

    section Bailout
    This PR (8155) - mean (295ms)  : 290, 299
    master - mean (295ms)  : 290, 300

    section CallTarget+Inlining+NGEN
    This PR (8155) - mean (993ms)  : 944, 1043
    master - mean (996ms)  : 935, 1057

Loading
HttpMessageHandler (.NET 6)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8155) - mean (286ms)  : 279, 294
    master - mean (288ms)  : 278, 299

    section Bailout
    This PR (8155) - mean (288ms)  : 282, 294
    master - mean (287ms)  : 281, 293

    section CallTarget+Inlining+NGEN
    This PR (8155) - mean (992ms)  : 953, 1032
    master - mean (990ms)  : 945, 1035

Loading
HttpMessageHandler (.NET 8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8155) - mean (285ms)  : 278, 293
    master - mean (288ms)  : 279, 297

    section Bailout
    This PR (8155) - mean (285ms)  : 279, 292
    master - mean (286ms)  : 281, 291

    section CallTarget+Inlining+NGEN
    This PR (8155) - mean (886ms)  : 855, 918
    master - mean (887ms)  : 861, 913

Loading

@daniel-romano-DD daniel-romano-DD enabled auto-merge (squash) February 5, 2026 08:50
@daniel-romano-DD daniel-romano-DD merged commit 8b053fc into master Feb 5, 2026
140 checks passed
@daniel-romano-DD daniel-romano-DD deleted the dani/asm/custom_data_classification branch February 5, 2026 10:49
@github-actions github-actions bot added this to the vNext-v3 milestone Feb 5, 2026
using System;
using System.Collections.Generic;
using System.Numerics;
using System.Security.Cryptography;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤨

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't know why VS keeps adding these kind of useless usings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants