[Tests] Remove empty metastruct info from snapshots#8150
Merged
daniel-romano-DD merged 4 commits intomasterfrom Feb 4, 2026
Merged
[Tests] Remove empty metastruct info from snapshots#8150daniel-romano-DD merged 4 commits intomasterfrom
daniel-romano-DD merged 4 commits intomasterfrom
Conversation
Contributor
Snapshots difference summaryThe following differences have been observed in committed snapshots. It is meant to help the reviewer. 159 occurrences of : - },
- MetaStruct: {
- iast:
5 occurrences of : - _dd.iast.json.metastruct.test: true
[...]
- },
- MetaStruct: {
- iast:
1 occurrences of : - _dd.iast.json.metastruct.test: true,
7 occurrences of : - },
- MetaStruct: {
- iast: ,
- _dd.stack:
18 occurrences of : - },
- MetaStruct: {
- appsec: ,
- _dd.stack:
351 occurrences of : - },
- MetaStruct: {
- appsec:
17 occurrences of : - },
- MetaStruct: {
- appsec: ,
- iast: ,
- _dd.stack:
1 occurrences of : - _dd.appsec.json.metastruct.test: true,
|
BenchmarksBenchmark execution time: 2026-02-04 11:06:33 Comparing candidate commit 4ebab35 in PR branch Found 7 performance improvements and 7 performance regressions! Performance is the same for 164 metrics, 14 unstable metrics. scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1
scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8150) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8150) - mean (73ms) : 71, 75
master - mean (73ms) : 71, 75
section Bailout
This PR (8150) - mean (77ms) : 75, 80
master - mean (77ms) : 75, 79
section CallTarget+Inlining+NGEN
This PR (8150) - mean (1,058ms) : 1019, 1097
master - mean (1,062ms) : 1021, 1104
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8150) - mean (124ms) : 120, 129
master - mean (123ms) : 120, 126
section Bailout
This PR (8150) - mean (125ms) : 122, 128
master - mean (124ms) : 121, 127
section CallTarget+Inlining+NGEN
This PR (8150) - mean (835ms) : 791, 880
master - mean (831ms) : 780, 882
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8150) - mean (110ms) : 106, 113
master - mean (109ms) : 105, 112
section Bailout
This PR (8150) - mean (110ms) : 107, 113
master - mean (109ms) : 107, 111
section CallTarget+Inlining+NGEN
This PR (8150) - mean (802ms) : 782, 822
master - mean (797ms) : 775, 818
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8150) - mean (108ms) : 105, 111
master - mean (107ms) : 104, 110
section Bailout
This PR (8150) - mean (110ms) : 107, 113
master - mean (108ms) : 106, 110
section CallTarget+Inlining+NGEN
This PR (8150) - mean (714ms) : 694, 733
master - mean (707ms) : 689, 724
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8150) - mean (198ms) : 193, 203
master - mean (199ms) : 194, 204
section Bailout
This PR (8150) - mean (202ms) : 197, 206
master - mean (202ms) : 198, 206
section CallTarget+Inlining+NGEN
This PR (8150) - mean (1,162ms) : 1117, 1207
master - mean (1,163ms) : 1116, 1209
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8150) - mean (298ms) : 292, 305
master - mean (295ms) : 289, 302
section Bailout
This PR (8150) - mean (298ms) : 291, 304
master - mean (296ms) : 292, 299
section CallTarget+Inlining+NGEN
This PR (8150) - mean (1,005ms) : 961, 1049
master - mean (1,000ms) : 949, 1052
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8150) - mean (290ms) : 282, 297
master - mean (287ms) : 281, 293
section Bailout
This PR (8150) - mean (290ms) : 283, 296
master - mean (289ms) : 284, 295
section CallTarget+Inlining+NGEN
This PR (8150) - mean (1,012ms) : 982, 1042
master - mean (1,003ms) : 964, 1043
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8150) - mean (289ms) : 281, 296
master - mean (287ms) : 281, 292
section Bailout
This PR (8150) - mean (289ms) : 283, 295
master - mean (285ms) : 282, 289
section CallTarget+Inlining+NGEN
This PR (8150) - mean (904ms) : 876, 933
master - mean (898ms) : 860, 936
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
e-n-0
approved these changes
Feb 4, 2026
Member
e-n-0
left a comment
There was a problem hiding this comment.
Few comments.
Also if you don't want to use Metastruct anymore in the tests, the Mock Agent configuration should be changed to disabled metastruct. (And I'm not 100% sure but there was on some tests a wait of discoverably feature to wait for the agent config; so this could be maybe disabled when not needed for appsec tests)
| #pragma warning restore SA1401 // Fields should be private | ||
|
|
||
| public AspNetBase(string sampleName, ITestOutputHelper outputHelper, string shutdownPath, string samplesDir = null, string testName = null, bool clearMetaStruct = false, bool allowAutoRedirect = true) | ||
| public AspNetBase(string sampleName, ITestOutputHelper outputHelper, string shutdownPath, string samplesDir = null, string testName = null, string clearMetaStruct = "", bool allowAutoRedirect = true) |
Member
There was a problem hiding this comment.
is string clearMetaStruct = "" still used/relevant ?
Comment on lines
-52
to
-62
| }, | ||
| _dd.iast.json.metastruct.test: true | ||
| } | ||
| }, | ||
| Metrics: { | ||
| process_id: 0, | ||
| _dd.top_level: 1.0, | ||
| _dd.tracer_kr: 1.0, | ||
| _sampling_priority_v1: 2.0 | ||
| }, | ||
| MetaStruct: { | ||
| iast: |
Member
There was a problem hiding this comment.
I think this PR might makes these tests completely useless as metastruct won't be enabled anymore and tested?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Remove metastruct data from snapshots in APPSEC integration tests
Reason for change
Some tests where flakying because of the occasional unavailability of metastruct capability
Implementation details
Test coverage
Other details