[FFE] Ruggerize integration tests Remote Config retrieval#8129
Merged
daniel-romano-DD merged 2 commits intomasterfrom Feb 2, 2026
Merged
[FFE] Ruggerize integration tests Remote Config retrieval#8129daniel-romano-DD merged 2 commits intomasterfrom
daniel-romano-DD merged 2 commits intomasterfrom
Conversation
andrewlock
approved these changes
Feb 2, 2026
| return; | ||
| } | ||
| Console.WriteLine($"Waiting for RC..."); | ||
| System.Threading.Thread.Sleep(1000); |
Member
There was a problem hiding this comment.
nit, threads are precious in CI, we should prob use await Task.Delay(1_000) 😄
| if (e.Value.PathAndQuery.EndsWith("api/v2/exposures")) | ||
| { | ||
| Interlocked.Increment(ref eventsReceived); | ||
| e.Value.Headers["Content-Encoding"].Should().Be(MimeTypes.Json); |
Member
There was a problem hiding this comment.
Did we change something here? Because it looks like this probably was failing before, but it wasn't causing the test to fail :sus: I'm assuming that exceptions here are just swallowed?
Contributor
Author
There was a problem hiding this comment.
Yep, the assert was failing but not halting the process, as it was happening in the RC handler. It was just showing an ugly message in the console output
sameerank
approved these changes
Feb 2, 2026
sameerank
left a comment
There was a problem hiding this comment.
Thanks for addressing this test flakiness!
BenchmarksBenchmark execution time: 2026-02-02 17:06:26 Comparing candidate commit ae61d1d in PR branch Found 8 performance improvements and 11 performance regressions! Performance is the same for 158 metrics, 15 unstable metrics. scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0
scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1
scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0
scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Increase timeout and change logic order to try to minimize test flakiness
Reason for change
Flakiness is bad
Implementation details
Test coverage
Other details