Skip to content

[CI] Add CultureInvariant to a test that was failing locally#8127

Merged
pierotibou merged 1 commit intomasterfrom
pierre/Truncates_FormatStrings
Feb 6, 2026
Merged

[CI] Add CultureInvariant to a test that was failing locally#8127
pierotibou merged 1 commit intomasterfrom
pierre/Truncates_FormatStrings

Conversation

@pierotibou
Copy link
Contributor

@pierotibou pierotibou commented Feb 2, 2026

Summary of changes

Fixing a test that was failing on my env, because of a , instead of a ..

Reason for change

The test was the issue not the code it tested.

Implementation details

Just adding a good old CultureInfo.InvariantCulture as Lucas has been doing everywhere since ever :p

Test coverage

N/A

@pierotibou
Add CultureInvariant to a test that was failing locally
aceccd9 
Signed-off-by: Pierre Bonet <pierre.bonet@datadoghq.com>
@pierotibou pierotibou requested a review from a team as a code owner February 2, 2026 13:21
@github-actions github-actions bot added the area:tests unit tests, integration tests label Feb 2, 2026
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Feb 2, 2026 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8127) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration73.30 ± (73.22 - 73.50) ms72.48 ± (72.53 - 72.84) ms-1.1%✅
.NET Framework 4.8 - Bailout
duration77.63 ± (77.47 - 77.82) ms76.77 ± (76.54 - 76.90) ms-1.1%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1060.19 ± (1062.61 - 1070.00) ms1055.14 ± (1054.71 - 1060.95) ms-0.5%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms23.36 ± (23.31 - 23.41) ms23.05 ± (23.01 - 23.09) ms-1.3%✅
process.time_to_main_ms93.44 ± (93.27 - 93.61) ms92.40 ± (92.22 - 92.57) ms-1.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed15.52 ± (15.51 - 15.52) MB15.53 ± (15.52 - 15.53) MB+0.0%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms23.29 ± (23.24 - 23.33) ms22.96 ± (22.92 - 23.00) ms-1.4%✅
process.time_to_main_ms94.78 ± (94.55 - 95.02) ms93.91 ± (93.69 - 94.13) ms-0.9%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed15.59 ± (15.58 - 15.59) MB15.55 ± (15.55 - 15.55) MB-0.2%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms270.24 ± (266.95 - 273.52) ms267.84 ± (264.61 - 271.06) ms-0.9%✅
process.time_to_main_ms525.66 ± (525.00 - 526.33) ms523.70 ± (522.93 - 524.46) ms-0.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed53.24 ± (53.22 - 53.26) MB53.29 ± (53.26 - 53.31) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅
.NET 6 - Baseline
process.internal_duration_ms21.47 ± (21.43 - 21.51) ms21.60 ± (21.55 - 21.64) ms+0.6%✅⬆️
process.time_to_main_ms74.25 ± (74.06 - 74.44) ms80.32 ± (80.08 - 80.55) ms+8.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.67 ± (10.66 - 10.67) MB15.23 ± (15.22 - 15.23) MB+42.7%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.45 ± (21.41 - 21.49) ms21.55 ± (21.50 - 21.60) ms+0.4%✅⬆️
process.time_to_main_ms75.09 ± (74.91 - 75.28) ms81.07 ± (80.89 - 81.25) ms+8.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.72 ± (10.72 - 10.73) MB15.35 ± (15.34 - 15.35) MB+43.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms231.31 ± (227.35 - 235.28) ms262.60 ± (261.47 - 263.73) ms+13.5%✅⬆️
process.time_to_main_ms474.27 ± (473.59 - 474.95) ms494.96 ± (494.28 - 495.64) ms+4.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed49.27 ± (49.25 - 49.30) MB54.01 ± (53.98 - 54.04) MB+9.6%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.3%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms19.89 ± (19.86 - 19.93) ms19.79 ± (19.74 - 19.83) ms-0.5%✅
process.time_to_main_ms79.24 ± (79.07 - 79.41) ms78.81 ± (78.62 - 78.99) ms-0.5%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed12.26 ± (12.26 - 12.27) MB12.28 ± (12.28 - 12.29) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.80 ± (19.77 - 19.84) ms19.74 ± (19.69 - 19.79) ms-0.3%✅
process.time_to_main_ms80.12 ± (79.97 - 80.27) ms80.25 ± (80.07 - 80.42) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed12.33 ± (12.32 - 12.35) MB12.33 ± (12.32 - 12.34) MB-0.0%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms190.55 ± (189.68 - 191.41) ms189.77 ± (188.76 - 190.78) ms-0.4%✅
process.time_to_main_ms479.80 ± (478.92 - 480.67) ms479.27 ± (478.39 - 480.14) ms-0.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed41.43 ± (41.39 - 41.47) MB41.40 ± (41.34 - 41.45) MB-0.1%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.5%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration196.92 ± (197.16 - 198.04) ms198.35 ± (198.07 - 199.09) ms+0.7%✅⬆️
.NET Framework 4.8 - Bailout
duration201.04 ± (200.76 - 201.51) ms201.81 ± (201.96 - 203.07) ms+0.4%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1161.56 ± (1165.33 - 1174.28) ms1170.96 ± (1182.90 - 1203.43) ms+0.8%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms192.16 ± (191.66 - 192.66) ms195.72 ± (195.41 - 196.02) ms+1.9%✅⬆️
process.time_to_main_ms83.98 ± (83.68 - 84.29) ms90.94 ± (90.75 - 91.13) ms+8.3%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.14 ± (16.12 - 16.16) MB20.76 ± (20.74 - 20.78) MB+28.6%✅⬆️
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (20 - 20)+0.5%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms191.75 ± (191.25 - 192.25) ms195.56 ± (195.19 - 195.94) ms+2.0%✅⬆️
process.time_to_main_ms84.84 ± (84.67 - 85.01) ms92.15 ± (91.94 - 92.36) ms+8.6%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.24 ± (16.22 - 16.26) MB20.72 ± (20.69 - 20.75) MB+27.6%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)+0.8%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms427.56 ± (424.05 - 431.06) ms447.19 ± (444.90 - 449.47) ms+4.6%✅⬆️
process.time_to_main_ms491.40 ± (490.36 - 492.44) ms516.60 ± (515.75 - 517.44) ms+5.1%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed59.15 ± (59.04 - 59.26) MB63.44 ± (63.33 - 63.56) MB+7.3%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 30)29 ± (29 - 29)-0.2%✅
.NET 6 - Baseline
process.internal_duration_ms201.30 ± (200.90 - 201.71) ms200.38 ± (199.96 - 200.81) ms-0.5%✅
process.time_to_main_ms78.79 ± (78.57 - 79.01) ms78.54 ± (78.32 - 78.75) ms-0.3%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed20.90 ± (20.88 - 20.92) MB20.90 ± (20.88 - 20.93) MB+0.0%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 20)20 ± (19 - 20)+0.2%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms200.20 ± (199.83 - 200.56) ms199.40 ± (198.99 - 199.82) ms-0.4%✅
process.time_to_main_ms79.85 ± (79.66 - 80.05) ms79.36 ± (79.18 - 79.54) ms-0.6%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed20.95 ± (20.93 - 20.97) MB20.97 ± (20.95 - 21.00) MB+0.1%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 21)21 ± (20 - 21)+0.1%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms468.41 ± (466.73 - 470.10) ms466.52 ± (464.69 - 468.35) ms-0.4%✅
process.time_to_main_ms491.75 ± (491.03 - 492.48) ms490.80 ± (490.15 - 491.45) ms-0.2%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed62.90 ± (62.80 - 63.01) MB63.15 ± (63.03 - 63.26) MB+0.4%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.0%✅
.NET 8 - Baseline
process.internal_duration_ms198.87 ± (198.45 - 199.30) ms199.90 ± (199.42 - 200.37) ms+0.5%✅⬆️
process.time_to_main_ms78.14 ± (77.95 - 78.34) ms78.65 ± (78.45 - 78.85) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.34 ± (16.32 - 16.36) MB16.31 ± (16.29 - 16.32) MB-0.2%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.1%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms198.49 ± (197.99 - 198.99) ms199.13 ± (198.63 - 199.64) ms+0.3%✅⬆️
process.time_to_main_ms79.57 ± (79.35 - 79.80) ms80.10 ± (79.89 - 80.32) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.45 ± (16.43 - 16.47) MB16.37 ± (16.35 - 16.39) MB-0.5%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.4%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms379.23 ± (377.96 - 380.50) ms378.23 ± (376.85 - 379.61) ms-0.3%✅
process.time_to_main_ms476.77 ± (476.08 - 477.45) ms477.75 ± (477.06 - 478.44) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed52.94 ± (52.88 - 53.01) MB53.01 ± (52.95 - 53.08) MB+0.1%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.2%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8127) - mean (73ms)  : 70, 75
    master - mean (73ms)  : 71, 75

    section Bailout
    This PR (8127) - mean (77ms)  : 75, 79
    master - mean (78ms)  : 76, 79

    section CallTarget+Inlining+NGEN
    This PR (8127) - mean (1,058ms)  : 1012, 1104
    master - mean (1,066ms)  : 1013, 1119
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8127) - mean (123ms)  : 120, 126
    master - mean (125ms)  : 120, 129

    section Bailout
    This PR (8127) - mean (124ms)  : 121, 127
    master - mean (126ms)  : 123, 129

    section CallTarget+Inlining+NGEN
    This PR (8127) - mean (828ms)  : 772, 885
    master - mean (833ms)  : 780, 886
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8127) - mean (109ms)  : 104, 114
    master - mean (102ms)  : 99, 106

    section Bailout
    This PR (8127) - mean (109ms)  : crit, 107, 112
    master - mean (103ms)  : 100, 106

    section CallTarget+Inlining+NGEN
    This PR (8127) - mean (798ms)  : crit, 775, 821
    master - mean (742ms)  : 666, 817
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8127) - mean (107ms)  : 105, 110
    master - mean (108ms)  : 105, 110

    section Bailout
    This PR (8127) - mean (108ms)  : 106, 110
    master - mean (108ms)  : 106, 110

    section CallTarget+Inlining+NGEN
    This PR (8127) - mean (713ms)  : 696, 729
    master - mean (712ms)  : 690, 735
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8127) - mean (199ms)  : 192, 205
    master - mean (198ms)  : 192, 204

    section Bailout
    This PR (8127) - mean (203ms)  : 195, 210
    master - mean (201ms)  : 198, 205

    section CallTarget+Inlining+NGEN
    This PR (8127) - mean (1,193ms)  : 1034, 1352
    master - mean (1,170ms)  : 1104, 1235
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8127) - mean (297ms)  : 287, 306
    master - mean (285ms)  : 279, 291

    section Bailout
    This PR (8127) - mean (297ms)  : 292, 302
    master - mean (285ms)  : 278, 293

    section CallTarget+Inlining+NGEN
    This PR (8127) - mean (1,006ms)  : 962, 1050
    master - mean (960ms)  : 887, 1033
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8127) - mean (289ms)  : 279, 298
    master - mean (289ms)  : 280, 299

    section Bailout
    This PR (8127) - mean (287ms)  : 283, 292
    master - mean (289ms)  : 285, 294

    section CallTarget+Inlining+NGEN
    This PR (8127) - mean (995ms)  : 958, 1031
    master - mean (998ms)  : 959, 1038
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8127) - mean (290ms)  : 279, 301
    master - mean (288ms)  : 281, 295

    section Bailout
    This PR (8127) - mean (291ms)  : 284, 297
    master - mean (289ms)  : 282, 295

    section CallTarget+Inlining+NGEN
    This PR (8127) - mean (894ms)  : 856, 932
    master - mean (892ms)  : 861, 922
Loading

@pierotibou pierotibou force-pushed the pierre/Truncates_FormatStrings branch from 7a60ba9 to 9215be8 Compare February 4, 2026 07:58
@pierotibou pierotibou enabled auto-merge (squash) February 4, 2026 07:58
@pr-commenter
Copy link

pr-commenter bot commented Feb 4, 2026 •
edited
Loading

Benchmarks

Benchmark execution time: 2026-02-04 09:56:16

Comparing candidate commit aceccd9 in PR branch pierre/Truncates_FormatStrings with baseline commit 723078c in branch master.

Found 8 performance improvements and 10 performance regressions! Performance is the same for 157 metrics, 17 unstable metrics.

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+19.060ms; +20.281ms] or [+9.564%; +10.176%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+80.482ms; +81.122ms] or [+67.209%; +67.743%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 execution_time [+13.993ms; +18.237ms] or [+7.023%; +9.153%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟩 execution_time [-37.460ms; -30.895ms] or [-16.694%; -13.768%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+18.647ms; +19.816ms] or [+10.287%; +10.933%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1

  • 🟥 execution_time [+34.916µs; +67.949µs] or [+7.842%; +15.261%]
  • 🟥 throughput [-265.128op/s; -142.742op/s] or [-11.788%; -6.347%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+19.507ms; +24.376ms] or [+10.392%; +12.986%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+10.185ms; +16.968ms] or [+6.468%; +10.776%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0

  • 🟩 execution_time [-90.902µs; -83.832µs] or [-7.781%; -7.175%]
  • 🟩 throughput [+66.523op/s; +71.804op/s] or [+7.772%; +8.389%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟩 throughput [+25754.547op/s; +28773.120op/s] or [+6.781%; +7.576%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

  • 🟩 execution_time [-16.525ms; -11.037ms] or [-7.812%; -5.217%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1

  • 🟩 execution_time [-53.102ms; -47.863ms] or [-25.546%; -23.025%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟩 execution_time [-21.146ms; -19.578ms] or [-10.507%; -9.728%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟥 execution_time [+35.813ms; +36.456ms] or [+37.573%; +38.248%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟩 throughput [+23958601.489op/s; +25283646.410op/s] or [+11.078%; +11.691%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟥 execution_time [+16.857ms; +21.151ms] or [+8.359%; +10.488%]

@pierotibou pierotibou force-pushed the pierre/Truncates_FormatStrings branch 3 times, most recently from 45532b0 to aceccd9 Compare February 4, 2026 09:13
@pierotibou pierotibou disabled auto-merge February 6, 2026 10:52
@pierotibou pierotibou merged commit 71d86ec into master Feb 6, 2026
142 checks passed
@pierotibou pierotibou deleted the pierre/Truncates_FormatStrings branch February 6, 2026 20:24
@github-actions github-actions bot added this to the vNext-v3 milestone Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes

@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

area:tests unit tests, integration tests

Projects

None yet

Milestone

3.37.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pierotibou @lucaspimentel @andrewlock