Skip to content

Add a few nitpicks in agents.md#8125

Merged
pierotibou merged 1 commit intomasterfrom
pierre/agent_rules
Feb 2, 2026
Merged

Add a few nitpicks in agents.md#8125
pierotibou merged 1 commit intomasterfrom
pierre/agent_rules

Conversation

@pierotibou
Copy link
Contributor

Summary of changes

Ask agents not to duplicate test or use is not null rather than the old way.

Reason for change

Was trying out agents and noticed that twice.

Implementation details

Just added a mention in agent.md. Honestly not sure how impactful it is.

Test coverage

None

@pierotibou pierotibou requested a review from a team as a code owner February 2, 2026 13:05
@pr-commenter
Copy link

pr-commenter bot commented Feb 2, 2026

Benchmarks

Benchmark execution time: 2026-02-02 13:47:40

Comparing candidate commit 2379c01 in PR branch pierre/agent_rules with baseline commit 22b8edf in branch master.

Found 5 performance improvements and 8 performance regressions! Performance is the same for 168 metrics, 11 unstable metrics.

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+80.179ms; +80.616ms] or [+66.356%; +66.718%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟥 execution_time [+20.903ms; +24.870ms] or [+11.136%; +13.250%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟥 execution_time [+19.351ms; +25.146ms] or [+9.844%; +12.793%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+30.451ms; +31.001ms] or [+17.530%; +17.846%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟩 execution_time [-51.400ms; -45.154ms] or [-25.191%; -22.130%]
  • 🟩 throughput [+203.742op/s; +264.727op/s] or [+14.434%; +18.755%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟩 execution_time [-56.895ms; -53.053ms] or [-25.132%; -23.436%]
  • 🟩 throughput [+159.007op/s; +187.582op/s] or [+11.247%; +13.268%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 execution_time [+11.779ms; +12.973ms] or [+5.847%; +6.440%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟥 throughput [-390.391op/s; -196.476op/s] or [-18.871%; -9.498%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 throughput [-15951304.138op/s; -14912898.968op/s] or [-6.619%; -6.188%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟥 execution_time [+12.597ms; +18.176ms] or [+6.379%; +9.204%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟩 execution_time [-17.796ms; -12.300ms] or [-8.443%; -5.836%]

Copy link
Collaborator

@bouwkast bouwkast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pierotibou pierotibou merged commit 8195b98 into master Feb 2, 2026
99 of 102 checks passed
@pierotibou pierotibou deleted the pierre/agent_rules branch February 2, 2026 14:29
@github-actions github-actions bot added this to the vNext-v3 milestone Feb 2, 2026
@lucaspimentel lucaspimentel added the ai-agents 🤖 files used by AI agents label Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-agents 🤖 files used by AI agents area:docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants