Quick fix: write process tags as array instead of string in DSM payloads#8114
Quick fix: write process tags as array instead of string in DSM payloads#8114
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8114) and master.
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Metric | Master (Mean ± 95% CI) | Current (Mean ± 95% CI) | Change | Status |
|---|---|---|---|---|
| .NET Framework 4.8 - Baseline | ||||
| duration | 68.43 ± (68.43 - 68.68) ms | 76.80 ± (76.80 - 77.24) ms | +12.2% | ❌⬆️ |
| .NET Framework 4.8 - Bailout | ||||
| duration | 72.29 ± (72.26 - 72.52) ms | 81.65 ± (81.46 - 81.90) ms | +12.9% | ❌⬆️ |
Full Metrics Comparison
FakeDbCommand
| Metric | Master (Mean ± 95% CI) | Current (Mean ± 95% CI) | Change | Status |
|---|---|---|---|---|
| .NET Framework 4.8 - Baseline | ||||
| duration | 68.43 ± (68.43 - 68.68) ms | 76.80 ± (76.80 - 77.24) ms | +12.2% | ❌⬆️ |
| .NET Framework 4.8 - Bailout | ||||
| duration | 72.29 ± (72.26 - 72.52) ms | 81.65 ± (81.46 - 81.90) ms | +12.9% | ❌⬆️ |
| .NET Framework 4.8 - CallTarget+Inlining+NGEN | ||||
| duration | 1025.96 ± (1032.58 - 1042.59) ms | 1089.31 ± (1087.03 - 1093.77) ms | +6.2% | ✅⬆️ |
| .NET Core 3.1 - Baseline | ||||
| process.internal_duration_ms | 21.89 ± (21.86 - 21.92) ms | 23.50 ± (23.44 - 23.56) ms | +7.4% | ✅⬆️ |
| process.time_to_main_ms | 78.83 ± (78.68 - 78.98) ms | 90.47 ± (90.17 - 90.77) ms | +14.8% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 0 ± (0 - 0) | 0 ± (0 - 0) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 10.91 ± (10.90 - 10.92) MB | 10.91 ± (10.91 - 10.91) MB | -0.0% | ✅ |
| runtime.dotnet.threads.count | 12 ± (12 - 12) | 12 ± (12 - 12) | +0.0% | ✅ |
| .NET Core 3.1 - Bailout | ||||
| process.internal_duration_ms | 21.80 ± (21.77 - 21.82) ms | 23.62 ± (23.55 - 23.68) ms | +8.4% | ✅⬆️ |
| process.time_to_main_ms | 80.09 ± (79.98 - 80.20) ms | 92.35 ± (92.12 - 92.58) ms | +15.3% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 0 ± (0 - 0) | 0 ± (0 - 0) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 10.93 ± (10.93 - 10.94) MB | 10.95 ± (10.95 - 10.95) MB | +0.1% | ✅⬆️ |
| runtime.dotnet.threads.count | 13 ± (13 - 13) | 13 ± (13 - 13) | +0.0% | ✅ |
| .NET Core 3.1 - CallTarget+Inlining+NGEN | ||||
| process.internal_duration_ms | 258.90 ± (257.04 - 260.76) ms | 235.92 ± (232.22 - 239.62) ms | -8.9% | ✅ |
| process.time_to_main_ms | 476.69 ± (476.16 - 477.22) ms | 523.45 ± (522.54 - 524.37) ms | +9.8% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 0 ± (0 - 0) | 0 ± (0 - 0) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 48.61 ± (48.59 - 48.63) MB | 48.52 ± (48.50 - 48.54) MB | -0.2% | ✅ |
| runtime.dotnet.threads.count | 28 ± (28 - 28) | 28 ± (28 - 28) | -1.3% | ✅ |
| .NET 6 - Baseline | ||||
| process.internal_duration_ms | 20.66 ± (20.63 - 20.68) ms | 22.25 ± (22.20 - 22.30) ms | +7.7% | ✅⬆️ |
| process.time_to_main_ms | 68.44 ± (68.33 - 68.55) ms | 78.83 ± (78.59 - 79.06) ms | +15.2% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 0 ± (0 - 0) | 0 ± (0 - 0) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 10.61 ± (10.61 - 10.61) MB | 10.64 ± (10.64 - 10.65) MB | +0.3% | ✅⬆️ |
| runtime.dotnet.threads.count | 10 ± (10 - 10) | 10 ± (10 - 10) | +0.0% | ✅ |
| .NET 6 - Bailout | ||||
| process.internal_duration_ms | 20.49 ± (20.47 - 20.52) ms | 21.97 ± (21.91 - 22.03) ms | +7.2% | ✅⬆️ |
| process.time_to_main_ms | 69.20 ± (69.16 - 69.25) ms | 79.12 ± (78.94 - 79.30) ms | +14.3% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 0 ± (0 - 0) | 0 ± (0 - 0) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 10.66 ± (10.66 - 10.66) MB | 10.75 ± (10.75 - 10.75) MB | +0.8% | ✅⬆️ |
| runtime.dotnet.threads.count | 11 ± (11 - 11) | 11 ± (11 - 11) | +0.0% | ✅ |
| .NET 6 - CallTarget+Inlining+NGEN | ||||
| process.internal_duration_ms | 248.41 ± (247.16 - 249.66) ms | 235.69 ± (231.68 - 239.71) ms | -5.1% | ✅ |
| process.time_to_main_ms | 454.07 ± (453.59 - 454.55) ms | 493.29 ± (492.60 - 493.98) ms | +8.6% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 0 ± (0 - 0) | 0 ± (0 - 0) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 49.34 ± (49.31 - 49.37) MB | 49.19 ± (49.17 - 49.21) MB | -0.3% | ✅ |
| runtime.dotnet.threads.count | 28 ± (28 - 28) | 28 ± (28 - 28) | +0.0% | ✅⬆️ |
| .NET 8 - Baseline | ||||
| process.internal_duration_ms | 18.78 ± (18.76 - 18.80) ms | 20.17 ± (20.12 - 20.23) ms | +7.4% | ✅⬆️ |
| process.time_to_main_ms | 67.42 ± (67.31 - 67.54) ms | 77.17 ± (76.98 - 77.36) ms | +14.5% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 0 ± (0 - 0) | 0 ± (0 - 0) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 7.67 ± (7.67 - 7.68) MB | 7.66 ± (7.65 - 7.67) MB | -0.2% | ✅ |
| runtime.dotnet.threads.count | 10 ± (10 - 10) | 10 ± (10 - 10) | +0.0% | ✅ |
| .NET 8 - Bailout | ||||
| process.internal_duration_ms | 18.87 ± (18.84 - 18.90) ms | 20.35 ± (20.29 - 20.41) ms | +7.8% | ✅⬆️ |
| process.time_to_main_ms | 68.46 ± (68.40 - 68.52) ms | 78.71 ± (78.50 - 78.91) ms | +15.0% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 0 ± (0 - 0) | 0 ± (0 - 0) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 7.73 ± (7.72 - 7.73) MB | 7.71 ± (7.70 - 7.72) MB | -0.2% | ✅ |
| runtime.dotnet.threads.count | 11 ± (11 - 11) | 11 ± (11 - 11) | +0.0% | ✅ |
| .NET 8 - CallTarget+Inlining+NGEN | ||||
| process.internal_duration_ms | 177.36 ± (176.41 - 178.31) ms | 194.33 ± (193.62 - 195.03) ms | +9.6% | ✅⬆️ |
| process.time_to_main_ms | 436.93 ± (436.12 - 437.74) ms | 475.50 ± (474.70 - 476.30) ms | +8.8% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 0 ± (0 - 0) | 0 ± (0 - 0) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 36.57 ± (36.54 - 36.60) MB | 36.88 ± (36.84 - 36.92) MB | +0.9% | ✅⬆️ |
| runtime.dotnet.threads.count | 26 ± (26 - 26) | 27 ± (27 - 27) | +0.3% | ✅⬆️ |
HttpMessageHandler
| Metric | Master (Mean ± 95% CI) | Current (Mean ± 95% CI) | Change | Status |
|---|---|---|---|---|
| .NET Framework 4.8 - Baseline | ||||
| duration | 195.80 ± (195.94 - 196.66) ms | 198.83 ± (198.85 - 199.69) ms | +1.5% | ✅⬆️ |
| .NET Framework 4.8 - Bailout | ||||
| duration | 199.15 ± (198.84 - 199.43) ms | 202.24 ± (201.85 - 202.78) ms | +1.6% | ✅⬆️ |
| .NET Framework 4.8 - CallTarget+Inlining+NGEN | ||||
| duration | 1144.10 ± (1144.44 - 1151.28) ms | 1168.02 ± (1171.93 - 1181.01) ms | +2.1% | ✅⬆️ |
| .NET Core 3.1 - Baseline | ||||
| process.internal_duration_ms | 189.26 ± (188.92 - 189.60) ms | 193.91 ± (193.49 - 194.33) ms | +2.5% | ✅⬆️ |
| process.time_to_main_ms | 81.99 ± (81.75 - 82.23) ms | 83.70 ± (83.48 - 83.92) ms | +2.1% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 3 ± (3 - 3) | 3 ± (3 - 3) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 16.05 ± (16.02 - 16.08) MB | 16.05 ± (16.03 - 16.07) MB | -0.0% | ✅ |
| runtime.dotnet.threads.count | 20 ± (20 - 20) | 20 ± (20 - 20) | -0.4% | ✅ |
| .NET Core 3.1 - Bailout | ||||
| process.internal_duration_ms | 189.50 ± (189.19 - 189.82) ms | 193.78 ± (193.28 - 194.28) ms | +2.3% | ✅⬆️ |
| process.time_to_main_ms | 83.19 ± (83.01 - 83.37) ms | 85.46 ± (85.23 - 85.70) ms | +2.7% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 3 ± (3 - 3) | 3 ± (3 - 3) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 16.10 ± (16.08 - 16.13) MB | 16.14 ± (16.12 - 16.17) MB | +0.2% | ✅⬆️ |
| runtime.dotnet.threads.count | 21 ± (21 - 21) | 21 ± (21 - 21) | +0.0% | ✅⬆️ |
| .NET Core 3.1 - CallTarget+Inlining+NGEN | ||||
| process.internal_duration_ms | 437.65 ± (435.28 - 440.02) ms | 424.01 ± (420.65 - 427.37) ms | -3.1% | ✅ |
| process.time_to_main_ms | 485.61 ± (484.97 - 486.25) ms | 494.23 ± (493.44 - 495.03) ms | +1.8% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 3 ± (3 - 3) | 3 ± (3 - 3) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 58.98 ± (58.88 - 59.08) MB | 59.15 ± (59.05 - 59.25) MB | +0.3% | ✅⬆️ |
| runtime.dotnet.threads.count | 29 ± (29 - 29) | 29 ± (29 - 29) | +0.1% | ✅⬆️ |
| .NET 6 - Baseline | ||||
| process.internal_duration_ms | 195.19 ± (194.80 - 195.58) ms | 199.63 ± (199.14 - 200.13) ms | +2.3% | ✅⬆️ |
| process.time_to_main_ms | 71.93 ± (71.74 - 72.13) ms | 73.01 ± (72.80 - 73.22) ms | +1.5% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 4 ± (4 - 4) | 4 ± (4 - 4) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 16.35 ± (16.32 - 16.38) MB | 16.30 ± (16.28 - 16.32) MB | -0.3% | ✅ |
| runtime.dotnet.threads.count | 19 ± (19 - 19) | 19 ± (19 - 19) | +0.9% | ✅⬆️ |
| .NET 6 - Bailout | ||||
| process.internal_duration_ms | 193.22 ± (192.92 - 193.52) ms | 198.41 ± (197.92 - 198.89) ms | +2.7% | ✅⬆️ |
| process.time_to_main_ms | 72.66 ± (72.53 - 72.79) ms | 73.90 ± (73.71 - 74.09) ms | +1.7% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 4 ± (4 - 4) | 4 ± (4 - 4) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 16.35 ± (16.30 - 16.40) MB | 16.37 ± (16.35 - 16.39) MB | +0.1% | ✅⬆️ |
| runtime.dotnet.threads.count | 20 ± (20 - 20) | 20 ± (20 - 20) | +1.4% | ✅⬆️ |
| .NET 6 - CallTarget+Inlining+NGEN | ||||
| process.internal_duration_ms | 449.58 ± (446.20 - 452.95) ms | 446.58 ± (442.65 - 450.50) ms | -0.7% | ✅ |
| process.time_to_main_ms | 462.97 ± (462.44 - 463.50) ms | 473.31 ± (472.45 - 474.17) ms | +2.2% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 4 ± (4 - 4) | 4 ± (4 - 4) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 58.85 ± (58.73 - 58.98) MB | 58.90 ± (58.75 - 59.06) MB | +0.1% | ✅⬆️ |
| runtime.dotnet.threads.count | 29 ± (29 - 29) | 29 ± (29 - 29) | +0.1% | ✅⬆️ |
| .NET 8 - Baseline | ||||
| process.internal_duration_ms | 192.94 ± (192.55 - 193.32) ms | 202.04 ± (201.51 - 202.57) ms | +4.7% | ✅⬆️ |
| process.time_to_main_ms | 71.23 ± (71.02 - 71.44) ms | 73.67 ± (73.45 - 73.90) ms | +3.4% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 4 ± (4 - 4) | 4 ± (4 - 4) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 11.79 ± (11.75 - 11.82) MB | 11.61 ± (11.60 - 11.62) MB | -1.5% | ✅ |
| runtime.dotnet.threads.count | 18 ± (18 - 18) | 19 ± (19 - 19) | +2.4% | ✅⬆️ |
| .NET 8 - Bailout | ||||
| process.internal_duration_ms | 191.42 ± (191.12 - 191.71) ms | 200.80 ± (200.30 - 201.31) ms | +4.9% | ✅⬆️ |
| process.time_to_main_ms | 72.10 ± (71.98 - 72.22) ms | 74.54 ± (74.34 - 74.74) ms | +3.4% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 4 ± (4 - 4) | 4 ± (4 - 4) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 11.81 ± (11.78 - 11.83) MB | 11.67 ± (11.66 - 11.69) MB | -1.2% | ✅ |
| runtime.dotnet.threads.count | 19 ± (19 - 19) | 19 ± (19 - 19) | +1.0% | ✅⬆️ |
| .NET 8 - CallTarget+Inlining+NGEN | ||||
| process.internal_duration_ms | 370.79 ± (369.40 - 372.17) ms | 384.00 ± (381.37 - 386.63) ms | +3.6% | ✅⬆️ |
| process.time_to_main_ms | 447.37 ± (446.78 - 447.96) ms | 465.25 ± (464.25 - 466.25) ms | +4.0% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 4 ± (4 - 4) | 4 ± (4 - 4) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 48.38 ± (48.35 - 48.41) MB | 48.87 ± (48.72 - 49.02) MB | +1.0% | ✅⬆️ |
| runtime.dotnet.threads.count | 29 ± (29 - 29) | 29 ± (29 - 29) | -0.3% | ✅ |
Comparison explanation
Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
- Welch test with statistical test for significance of 5%
- Only results indicating a difference greater than 5% and 5 ms are considered.
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
Duration charts
FakeDbCommand (.NET Framework 4.8)
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8114) - mean (77ms) : 74, 80
master - mean (69ms) : 67, 70
section Bailout
This PR (8114) - mean (82ms) : crit, 79, 84
master - mean (72ms) : 71, 74
section CallTarget+Inlining+NGEN
This PR (8114) - mean (1,090ms) : 1041, 1140
master - mean (1,038ms) : 963, 1112
FakeDbCommand (.NET Core 3.1)
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8114) - mean (121ms) : 117, 126
master - mean (106ms) : 103, 110
section Bailout
This PR (8114) - mean (123ms) : crit, 119, 127
master - mean (107ms) : 105, 109
section CallTarget+Inlining+NGEN
This PR (8114) - mean (799ms) : 743, 855
master - mean (762ms) : 730, 793
FakeDbCommand (.NET 6)
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8114) - mean (108ms) : 103, 112
master - mean (94ms) : 92, 96
section Bailout
This PR (8114) - mean (108ms) : crit, 105, 110
master - mean (94ms) : 94, 95
section CallTarget+Inlining+NGEN
This PR (8114) - mean (762ms) : 685, 839
master - mean (728ms) : 700, 756
FakeDbCommand (.NET 8)
gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8114) - mean (106ms) : 102, 109
master - mean (92ms) : 90, 95
section Bailout
This PR (8114) - mean (107ms) : crit, 103, 111
master - mean (93ms) : 92, 94
section CallTarget+Inlining+NGEN
This PR (8114) - mean (705ms) : crit, 680, 730
master - mean (642ms) : 629, 654
HttpMessageHandler (.NET Framework 4.8)
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8114) - mean (199ms) : 194, 205
master - mean (196ms) : 192, 200
section Bailout
This PR (8114) - mean (202ms) : 198, 207
master - mean (199ms) : 196, 202
section CallTarget+Inlining+NGEN
This PR (8114) - mean (1,176ms) : 1109, 1244
master - mean (1,148ms) : 1098, 1198
HttpMessageHandler (.NET Core 3.1)
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8114) - mean (287ms) : 278, 295
master - mean (280ms) : 274, 286
section Bailout
This PR (8114) - mean (288ms) : 281, 296
master - mean (281ms) : 277, 286
section CallTarget+Inlining+NGEN
This PR (8114) - mean (954ms) : 907, 1001
master - mean (949ms) : 911, 987
HttpMessageHandler (.NET 6)
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8114) - mean (281ms) : 273, 289
master - mean (276ms) : 268, 283
section Bailout
This PR (8114) - mean (281ms) : 271, 291
master - mean (274ms) : 269, 279
section CallTarget+Inlining+NGEN
This PR (8114) - mean (953ms) : 901, 1006
master - mean (943ms) : 896, 989
HttpMessageHandler (.NET 8)
gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8114) - mean (287ms) : 276, 297
master - mean (274ms) : 268, 281
section Bailout
This PR (8114) - mean (286ms) : 274, 299
master - mean (273ms) : 268, 278
section CallTarget+Inlining+NGEN
This PR (8114) - mean (881ms) : 841, 922
master - mean (848ms) : 819, 877
BenchmarksBenchmark execution time: 2026-02-02 13:30:13 Comparing candidate commit 218a4eb in PR branch Found 7 performance improvements and 9 performance regressions! Performance is the same for 161 metrics, 15 unstable metrics. scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1
scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.NLogBenchmark.EnrichedLog net6.0
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0
scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net472
scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1
|
Summary of changes
Tags were written as a string, but DSM backend expects an array.
This was actually done correctly in the Java implem, and I missed it somehow, even though I used it as a reference...
https://github.com/DataDog/dd-trace-java/blob/e74c6a793a73862d6a0813c4c83e113dc03578b9/dd-trace-core/src/main/java/datadog/trace/core/datastreams/MsgPackDatastreamsPayloadWriter.java#L183-L185
Reason for change
Will create messagepack errors if enabled as is
Implementation details
Test coverage
Other details