Skip to content

[ASM] Added missing appsec.waf.request telemetry metric tags#8113

Merged
daniel-romano-DD merged 1 commit intomasterfrom
dani/asm/request_telemetry_tags
Jan 29, 2026
Merged

[ASM] Added missing appsec.waf.request telemetry metric tags#8113
daniel-romano-DD merged 1 commit intomasterfrom
dani/asm/request_telemetry_tags

Conversation

@daniel-romano-DD
Copy link
Contributor

@daniel-romano-DD daniel-romano-DD commented Jan 28, 2026 •
edited
Loading

Summary of changes

Added missing tags to appsec.waf.requests metric as stated here

Reason for change

Implementation details

Test coverage

Enabled and passed related system tests

Other details

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Jan 28, 2026 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8113) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration68.24 ± (68.22 - 68.44) ms68.32 ± (68.38 - 68.61) ms+0.1%✅⬆️
.NET Framework 4.8 - Bailout
duration72.39 ± (72.30 - 72.51) ms72.26 ± (72.23 - 72.42) ms-0.2%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1017.46 ± (1018.62 - 1024.83) ms1021.39 ± (1030.99 - 1042.61) ms+0.4%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms21.80 ± (21.77 - 21.84) ms21.85 ± (21.83 - 21.87) ms+0.2%✅⬆️
process.time_to_main_ms78.61 ± (78.45 - 78.77) ms78.87 ± (78.71 - 79.04) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.89 ± (10.89 - 10.90) MB10.90 ± (10.90 - 10.91) MB+0.1%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms21.85 ± (21.83 - 21.87) ms21.80 ± (21.77 - 21.82) ms-0.2%✅
process.time_to_main_ms79.91 ± (79.82 - 79.99) ms79.92 ± (79.82 - 80.02) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.93 ± (10.93 - 10.94) MB10.93 ± (10.93 - 10.94) MB+0.0%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms241.41 ± (237.86 - 244.96) ms249.80 ± (246.59 - 253.01) ms+3.5%✅⬆️
process.time_to_main_ms473.96 ± (473.36 - 474.57) ms476.00 ± (475.50 - 476.51) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.52 ± (48.50 - 48.54) MB48.56 ± (48.54 - 48.59) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms20.58 ± (20.55 - 20.61) ms20.54 ± (20.51 - 20.57) ms-0.2%✅
process.time_to_main_ms68.19 ± (68.07 - 68.32) ms68.03 ± (67.91 - 68.15) ms-0.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.61 ± (10.60 - 10.61) MB10.64 ± (10.64 - 10.65) MB+0.3%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms20.56 ± (20.53 - 20.58) ms20.52 ± (20.50 - 20.55) ms-0.2%✅
process.time_to_main_ms69.13 ± (69.07 - 69.19) ms69.12 ± (69.06 - 69.19) ms-0.0%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.65 ± (10.65 - 10.66) MB10.72 ± (10.72 - 10.73) MB+0.7%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms248.88 ± (247.53 - 250.23) ms247.12 ± (245.18 - 249.05) ms-0.7%✅
process.time_to_main_ms451.03 ± (450.61 - 451.44) ms451.39 ± (450.96 - 451.82) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed49.30 ± (49.27 - 49.33) MB49.36 ± (49.33 - 49.39) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.1%✅
.NET 8 - Baseline
process.internal_duration_ms18.76 ± (18.74 - 18.79) ms18.83 ± (18.81 - 18.86) ms+0.4%✅⬆️
process.time_to_main_ms67.36 ± (67.26 - 67.47) ms67.21 ± (67.11 - 67.32) ms-0.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.68 ± (7.67 - 7.69) MB7.68 ± (7.67 - 7.69) MB+0.0%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms18.71 ± (18.68 - 18.73) ms18.87 ± (18.85 - 18.90) ms+0.9%✅⬆️
process.time_to_main_ms68.47 ± (68.40 - 68.54) ms68.47 ± (68.40 - 68.54) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.72 ± (7.71 - 7.73) MB7.73 ± (7.72 - 7.74) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms178.50 ± (177.61 - 179.39) ms178.46 ± (177.45 - 179.48) ms-0.0%✅
process.time_to_main_ms434.45 ± (433.81 - 435.10) ms435.12 ± (434.39 - 435.85) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.64 ± (36.61 - 36.67) MB36.67 ± (36.64 - 36.70) MB+0.1%✅⬆️
runtime.dotnet.threads.count27 ± (26 - 27)26 ± (26 - 26)-0.0%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration194.59 ± (194.42 - 195.18) ms194.40 ± (194.23 - 195.06) ms-0.1%✅
.NET Framework 4.8 - Bailout
duration198.07 ± (198.11 - 198.75) ms197.53 ± (197.27 - 197.83) ms-0.3%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1144.63 ± (1143.59 - 1151.59) ms1141.39 ± (1145.01 - 1154.19) ms-0.3%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms188.30 ± (187.94 - 188.67) ms188.34 ± (187.93 - 188.76) ms+0.0%✅⬆️
process.time_to_main_ms81.07 ± (80.87 - 81.26) ms81.90 ± (81.63 - 82.18) ms+1.0%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.08 ± (16.06 - 16.10) MB16.11 ± (16.08 - 16.13) MB+0.2%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (19 - 20)-0.3%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms187.20 ± (186.84 - 187.56) ms187.86 ± (187.61 - 188.10) ms+0.4%✅⬆️
process.time_to_main_ms82.47 ± (82.30 - 82.64) ms82.69 ± (82.57 - 82.82) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.13 ± (16.10 - 16.15) MB16.14 ± (16.12 - 16.16) MB+0.1%✅⬆️
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (20 - 21)+0.0%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms431.62 ± (429.02 - 434.22) ms431.56 ± (428.89 - 434.22) ms-0.0%✅
process.time_to_main_ms479.81 ± (479.26 - 480.36) ms480.51 ± (479.84 - 481.18) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed59.00 ± (58.90 - 59.11) MB59.07 ± (58.95 - 59.18) MB+0.1%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 30)+0.2%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms191.63 ± (191.33 - 191.93) ms193.18 ± (192.71 - 193.65) ms+0.8%✅⬆️
process.time_to_main_ms70.51 ± (70.32 - 70.71) ms70.58 ± (70.39 - 70.77) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.39 ± (16.37 - 16.42) MB16.39 ± (16.36 - 16.42) MB-0.0%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.6%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms190.78 ± (190.51 - 191.06) ms191.41 ± (191.15 - 191.67) ms+0.3%✅⬆️
process.time_to_main_ms71.11 ± (70.99 - 71.24) ms71.41 ± (71.28 - 71.54) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.10 ± (15.95 - 16.25) MB16.06 ± (15.91 - 16.22) MB-0.2%✅
runtime.dotnet.threads.count19 ± (19 - 19)20 ± (19 - 20)+2.6%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms441.73 ± (438.29 - 445.16) ms442.64 ± (439.32 - 445.95) ms+0.2%✅⬆️
process.time_to_main_ms458.06 ± (457.46 - 458.65) ms458.20 ± (457.70 - 458.69) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed58.89 ± (58.77 - 59.01) MB59.04 ± (58.92 - 59.16) MB+0.3%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms190.18 ± (189.84 - 190.51) ms190.33 ± (189.90 - 190.77) ms+0.1%✅⬆️
process.time_to_main_ms69.65 ± (69.49 - 69.81) ms70.32 ± (70.11 - 70.53) ms+1.0%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.81 ± (11.79 - 11.84) MB11.78 ± (11.75 - 11.80) MB-0.3%✅
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.1%✅
.NET 8 - Bailout
process.internal_duration_ms189.48 ± (189.21 - 189.74) ms189.44 ± (189.23 - 189.66) ms-0.0%✅
process.time_to_main_ms71.02 ± (70.90 - 71.15) ms71.18 ± (71.09 - 71.27) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.85 ± (11.82 - 11.88) MB11.84 ± (11.81 - 11.87) MB-0.1%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.1%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms366.11 ± (364.75 - 367.47) ms367.67 ± (366.16 - 369.18) ms+0.4%✅⬆️
process.time_to_main_ms441.01 ± (440.19 - 441.83) ms441.29 ± (440.69 - 441.90) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed48.42 ± (48.39 - 48.45) MB48.39 ± (48.35 - 48.43) MB-0.1%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+1.0%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8113) - mean (68ms)  : 67, 70
    master - mean (68ms)  : 67, 70

    section Bailout
    This PR (8113) - mean (72ms)  : 71, 73
    master - mean (72ms)  : 71, 73

    section CallTarget+Inlining+NGEN
    This PR (8113) - mean (1,037ms)  : 954, 1120
    master - mean (1,022ms)  : 978, 1066
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8113) - mean (106ms)  : 103, 109
    master - mean (106ms)  : 103, 109

    section Bailout
    This PR (8113) - mean (107ms)  : 105, 108
    master - mean (107ms)  : 106, 108

    section CallTarget+Inlining+NGEN
    This PR (8113) - mean (747ms)  : 688, 806
    master - mean (742ms)  : 691, 793
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8113) - mean (93ms)  : 91, 95
    master - mean (93ms)  : 91, 96

    section Bailout
    This PR (8113) - mean (94ms)  : 93, 95
    master - mean (94ms)  : 93, 95

    section CallTarget+Inlining+NGEN
    This PR (8113) - mean (722ms)  : 688, 755
    master - mean (723ms)  : 694, 752
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8113) - mean (92ms)  : 90, 94
    master - mean (92ms)  : 90, 94

    section Bailout
    This PR (8113) - mean (93ms)  : 92, 95
    master - mean (93ms)  : 92, 94

    section CallTarget+Inlining+NGEN
    This PR (8113) - mean (640ms)  : 626, 654
    master - mean (640ms)  : 623, 657
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8113) - mean (195ms)  : 190, 199
    master - mean (195ms)  : 191, 198

    section Bailout
    This PR (8113) - mean (198ms)  : 195, 200
    master - mean (198ms)  : 195, 202

    section CallTarget+Inlining+NGEN
    This PR (8113) - mean (1,150ms)  : 1083, 1217
    master - mean (1,148ms)  : 1090, 1205
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8113) - mean (279ms)  : 273, 285
    master - mean (278ms)  : 272, 284

    section Bailout
    This PR (8113) - mean (279ms)  : 275, 282
    master - mean (278ms)  : 274, 282

    section CallTarget+Inlining+NGEN
    This PR (8113) - mean (942ms)  : 905, 978
    master - mean (940ms)  : 904, 976
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8113) - mean (272ms)  : 265, 279
    master - mean (270ms)  : 266, 274

    section Bailout
    This PR (8113) - mean (271ms)  : 267, 274
    master - mean (270ms)  : 266, 273

    section CallTarget+Inlining+NGEN
    This PR (8113) - mean (932ms)  : 887, 977
    master - mean (929ms)  : 872, 986
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8113) - mean (270ms)  : 264, 277
    master - mean (270ms)  : 265, 275

    section Bailout
    This PR (8113) - mean (270ms)  : 267, 273
    master - mean (270ms)  : 266, 275

    section CallTarget+Inlining+NGEN
    This PR (8113) - mean (841ms)  : 819, 862
    master - mean (839ms)  : 817, 861
Loading

@pr-commenter
Copy link

pr-commenter bot commented Jan 28, 2026 •
edited
Loading

Benchmarks

Benchmark execution time: 2026-01-29 07:54:41

Comparing candidate commit 602a22e in PR branch dani/asm/request_telemetry_tags with baseline commit e86e7a3 in branch master.

Found 13 performance improvements and 12 performance regressions! Performance is the same for 157 metrics, 10 unstable metrics.

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+78.231ms; +78.343ms] or [+63.291%; +63.382%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟩 execution_time [-88.571ms; -86.575ms] or [-44.750%; -43.741%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟥 execution_time [+17.555ms; +18.133ms] or [+8.776%; +9.064%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net472

  • 🟩 throughput [+206.966op/s; +210.946op/s] or [+5.773%; +5.884%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟩 execution_time [-26.107ms; -25.405ms] or [-13.007%; -12.657%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟥 execution_time [+31.179µs; +54.864µs] or [+10.060%; +17.702%]
  • 🟥 throughput [-501.896op/s; -295.941op/s] or [-15.503%; -9.141%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472

  • 🟩 throughput [+61436122.690op/s; +62729843.952op/s] or [+44.672%; +45.613%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • 🟩 execution_time [-25.958ms; -22.200ms] or [-21.424%; -18.322%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟩 throughput [+93.845op/s; +122.782op/s] or [+9.110%; +11.919%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+13.976ms; +17.703ms] or [+8.985%; +11.380%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟩 execution_time [-20.383ms; -14.283ms] or [-9.375%; -6.569%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

  • 🟩 execution_time [-84.157µs; -79.110µs] or [-5.747%; -5.403%]
  • 🟩 throughput [+39.052op/s; +41.598op/s] or [+5.718%; +6.091%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1

  • 🟥 throughput [-192.871op/s; -141.359op/s] or [-36.209%; -26.539%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472

  • 🟥 execution_time [+74.979µs; +78.088µs] or [+6.634%; +6.909%]
  • 🟥 throughput [-57.251op/s; -54.968op/s] or [-6.471%; -6.213%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472

  • 🟥 execution_time [+139.446µs; +144.327µs] or [+5.418%; +5.608%]
  • 🟥 throughput [-20.645op/s; -19.959op/s] or [-5.313%; -5.137%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 throughput [-25533.745op/s; -21196.645op/s] or [-6.085%; -5.051%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

  • 🟥 throughput [-52610.550op/s; -42392.133op/s] or [-9.605%; -7.739%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • 🟩 throughput [+934.872op/s; +2388.768op/s] or [+5.136%; +13.123%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟩 execution_time [-104.817ms; -103.506ms] or [-52.767%; -52.107%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟩 execution_time [-15.597ms; -11.610ms] or [-7.319%; -5.448%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 execution_time [-18.203ms; -13.685ms] or [-8.333%; -6.265%]

@daniel-romano-DD daniel-romano-DD marked this pull request as ready for review January 28, 2026 22:21
@daniel-romano-DD daniel-romano-DD requested review from a team as code owners January 28, 2026 22:21
chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Jan 28, 2026
View reviewed changes
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d44109170e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@daniel-romano-DD
Added missing appsec.waf.request metics tags
602a22e 
Fix test mock

Fixed tests

Fix condition
@daniel-romano-DD daniel-romano-DD force-pushed the dani/asm/request_telemetry_tags branch from d441091 to 602a22e Compare January 29, 2026 07:12
e-n-0
e-n-0 approved these changes Jan 29, 2026
View reviewed changes
Copy link
Member

@e-n-0 e-n-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Be sure it passes new system tests correctly!

@daniel-romano-DD daniel-romano-DD enabled auto-merge (squash) January 29, 2026 16:48
@lucaspimentel lucaspimentel changed the title [ASM] Added missing appsec.waf.request metics tags [ASM] Added missing appsec.waf.request telemetry metric tags Jan 29, 2026
@daniel-romano-DD daniel-romano-DD merged commit 3d020db into master Jan 29, 2026
142 checks passed
@daniel-romano-DD daniel-romano-DD deleted the dani/asm/request_telemetry_tags branch January 29, 2026 17:02
@github-actions github-actions bot added this to the vNext-v3 milestone Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@lucaspimentel lucaspimentel lucaspimentel approved these changes

@e-n-0 e-n-0 e-n-0 approved these changes

Assignees

No one assigned

Labels

area:asm

Projects

None yet

Milestone

3.37.0

Development

Successfully merging this pull request may close these issues.

3 participants

@daniel-romano-DD @lucaspimentel @e-n-0