Skip to content

Fix compilation issues under VS 2022#8111

Merged
NachoEchevarria merged 4 commits intomasterfrom
nacho/AvoidVSCompilationErrors
Feb 5, 2026
Merged

Fix compilation issues under VS 2022#8111
NachoEchevarria merged 4 commits intomasterfrom
nacho/AvoidVSCompilationErrors

Conversation

@NachoEchevarria
Copy link
Collaborator

@NachoEchevarria NachoEchevarria commented Jan 28, 2026 •
edited
Loading

Summary of changes

Adds <NoWarn>NU1510</NoWarn> to Datadog.Trace.Manual.csproj to suppress package pruning warnings when building in Visual Studio.
Removed from Datadog.InstrumentedAssemblyGeneration since it does not provide any value and causes compilation problems.

Add a #pragma warning disable SYSLIB0014 to avoid compilation problems.

Reason for change

With the .NET 10 SDK, Visual Studio shows NU1510 warnings ("PackageReference X will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary") that block compilation in src projects due to TreatWarningsAsErrors=true.

Additionally, Datadog.Trace.csproj shows SYSLIB0014 errors about obsolete WebRequest APIs in AWS Lambda integration code:

error SYSLIB0014: 'WebRequest.Create(string)' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.'

These warnings appear specifically in Visual Studio 2022 builds but not in:

  • Command-line builds via tracer\build BuildTracerHome
  • Test projects (already suppressed in tracer/test/Directory.Build.props)

Implementation details

Test coverage

Other details

@NachoEchevarria NachoEchevarria added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jan 28, 2026
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Jan 28, 2026 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8111) and master.

⚠️ Potential regressions detected

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration197.28 ± (197.08 - 197.93) ms209.55 ± (209.78 - 211.34) ms+6.2%❌⬆️
.NET Framework 4.8 - Bailout
duration199.70 ± (199.70 - 200.40) ms212.83 ± (212.55 - 213.90) ms+6.6%❌⬆️
Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration68.14 ± (68.15 - 68.36) ms68.24 ± (68.24 - 68.44) ms+0.2%✅⬆️
.NET Framework 4.8 - Bailout
duration72.17 ± (72.09 - 72.38) ms72.10 ± (71.95 - 72.19) ms-0.1%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1026.21 ± (1027.96 - 1034.94) ms1030.52 ± (1031.13 - 1038.31) ms+0.4%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.34 ± (22.31 - 22.38) ms22.45 ± (22.40 - 22.50) ms+0.5%✅⬆️
process.time_to_main_ms86.36 ± (86.24 - 86.47) ms86.83 ± (86.67 - 87.00) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed15.47 ± (15.47 - 15.47) MB15.52 ± (15.52 - 15.53) MB+0.3%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.37 ± (22.31 - 22.43) ms22.34 ± (22.31 - 22.37) ms-0.1%✅
process.time_to_main_ms87.81 ± (87.56 - 88.05) ms87.85 ± (87.72 - 87.98) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed15.53 ± (15.53 - 15.53) MB15.55 ± (15.55 - 15.56) MB+0.1%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms262.40 ± (259.58 - 265.21) ms263.44 ± (260.55 - 266.33) ms+0.4%✅⬆️
process.time_to_main_ms504.38 ± (503.87 - 504.89) ms507.22 ± (506.59 - 507.84) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed53.19 ± (53.16 - 53.21) MB53.34 ± (53.31 - 53.36) MB+0.3%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅
.NET 6 - Baseline
process.internal_duration_ms20.98 ± (20.95 - 21.00) ms21.01 ± (20.99 - 21.04) ms+0.2%✅⬆️
process.time_to_main_ms74.52 ± (74.41 - 74.63) ms75.05 ± (74.93 - 75.17) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed15.21 ± (15.21 - 15.21) MB15.24 ± (15.23 - 15.24) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms20.80 ± (20.78 - 20.83) ms20.92 ± (20.89 - 20.95) ms+0.6%✅⬆️
process.time_to_main_ms75.47 ± (75.41 - 75.52) ms75.80 ± (75.72 - 75.88) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed15.32 ± (15.32 - 15.32) MB15.34 ± (15.34 - 15.34) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms252.83 ± (251.97 - 253.70) ms253.71 ± (252.75 - 254.67) ms+0.3%✅⬆️
process.time_to_main_ms479.14 ± (478.52 - 479.76) ms479.89 ± (479.35 - 480.43) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed53.97 ± (53.94 - 54.01) MB54.12 ± (54.09 - 54.15) MB+0.3%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.3%✅
.NET 8 - Baseline
process.internal_duration_ms19.29 ± (19.26 - 19.31) ms19.29 ± (19.27 - 19.32) ms+0.0%✅⬆️
process.time_to_main_ms73.87 ± (73.76 - 73.97) ms74.16 ± (74.03 - 74.30) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed12.26 ± (12.26 - 12.27) MB12.26 ± (12.26 - 12.27) MB+0.0%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.25 ± (19.22 - 19.27) ms19.27 ± (19.24 - 19.29) ms+0.1%✅⬆️
process.time_to_main_ms75.15 ± (75.08 - 75.22) ms75.34 ± (75.27 - 75.41) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed12.32 ± (12.31 - 12.33) MB12.31 ± (12.31 - 12.32) MB-0.1%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms182.62 ± (181.76 - 183.48) ms182.83 ± (181.99 - 183.67) ms+0.1%✅⬆️
process.time_to_main_ms460.07 ± (459.55 - 460.59) ms461.33 ± (460.79 - 461.88) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed41.22 ± (41.20 - 41.25) MB41.28 ± (41.24 - 41.32) MB+0.1%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.4%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration197.28 ± (197.08 - 197.93) ms209.55 ± (209.78 - 211.34) ms+6.2%❌⬆️
.NET Framework 4.8 - Bailout
duration199.70 ± (199.70 - 200.40) ms212.83 ± (212.55 - 213.90) ms+6.6%❌⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1157.85 ± (1162.34 - 1171.13) ms1206.04 ± (1205.76 - 1215.11) ms+4.2%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms195.30 ± (194.90 - 195.71) ms212.10 ± (211.19 - 213.01) ms+8.6%✅⬆️
process.time_to_main_ms90.63 ± (90.36 - 90.90) ms97.83 ± (97.40 - 98.26) ms+7.9%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed20.71 ± (20.69 - 20.73) MB20.57 ± (20.55 - 20.58) MB-0.7%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+1.5%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms194.59 ± (194.13 - 195.06) ms213.37 ± (212.54 - 214.21) ms+9.7%✅⬆️
process.time_to_main_ms91.75 ± (91.50 - 91.99) ms100.38 ± (100.06 - 100.69) ms+9.4%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed20.68 ± (20.65 - 20.70) MB20.56 ± (20.54 - 20.57) MB-0.6%✅
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)+0.1%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms443.31 ± (440.61 - 446.02) ms465.94 ± (462.68 - 469.20) ms+5.1%✅⬆️
process.time_to_main_ms515.13 ± (514.43 - 515.84) ms548.86 ± (547.15 - 550.56) ms+6.5%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed63.52 ± (63.42 - 63.62) MB62.75 ± (62.58 - 62.91) MB-1.2%✅
runtime.dotnet.threads.count29 ± (29 - 29)30 ± (30 - 30)+0.5%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms199.88 ± (199.43 - 200.34) ms213.76 ± (212.99 - 214.52) ms+6.9%✅⬆️
process.time_to_main_ms78.56 ± (78.36 - 78.75) ms84.08 ± (83.82 - 84.35) ms+7.0%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed20.95 ± (20.93 - 20.97) MB20.75 ± (20.73 - 20.76) MB-1.0%✅
runtime.dotnet.threads.count19 ± (19 - 20)20 ± (20 - 20)+1.0%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms198.17 ± (197.75 - 198.59) ms212.71 ± (212.08 - 213.33) ms+7.3%✅⬆️
process.time_to_main_ms79.30 ± (79.13 - 79.46) ms85.47 ± (85.23 - 85.71) ms+7.8%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed21.06 ± (21.04 - 21.09) MB20.86 ± (20.85 - 20.88) MB-1.0%✅
runtime.dotnet.threads.count20 ± (20 - 20)21 ± (21 - 21)+0.8%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms465.39 ± (463.71 - 467.07) ms487.28 ± (484.67 - 489.88) ms+4.7%✅⬆️
process.time_to_main_ms489.70 ± (489.01 - 490.39) ms519.01 ± (517.70 - 520.32) ms+6.0%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed63.02 ± (62.91 - 63.12) MB62.56 ± (62.44 - 62.68) MB-0.7%✅
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.7%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms197.92 ± (197.44 - 198.39) ms220.91 ± (219.46 - 222.35) ms+11.6%✅⬆️
process.time_to_main_ms77.77 ± (77.57 - 77.96) ms84.91 ± (84.51 - 85.30) ms+9.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.30 ± (16.28 - 16.32) MB16.02 ± (16.00 - 16.04) MB-1.7%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.4%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms196.86 ± (196.51 - 197.22) ms214.56 ± (213.70 - 215.42) ms+9.0%✅⬆️
process.time_to_main_ms79.04 ± (78.90 - 79.19) ms85.55 ± (85.27 - 85.84) ms+8.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.38 ± (16.36 - 16.41) MB16.16 ± (16.14 - 16.18) MB-1.4%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+1.0%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms377.62 ± (376.06 - 379.18) ms514.07 ± (509.68 - 518.47) ms+36.1%✅⬆️
process.time_to_main_ms473.91 ± (473.20 - 474.62) ms521.51 ± (518.65 - 524.37) ms+10.0%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed52.92 ± (52.87 - 52.96) MB55.02 ± (54.97 - 55.06) MB+4.0%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.5%✅
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8111) - mean (68ms)  : 67, 70
    master - mean (68ms)  : 67, 70

    section Bailout
    This PR (8111) - mean (72ms)  : 71, 73
    master - mean (72ms)  : 71, 74

    section CallTarget+Inlining+NGEN
    This PR (8111) - mean (1,035ms)  : 983, 1086
    master - mean (1,031ms)  : 981, 1082
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8111) - mean (116ms)  : 113, 118
    master - mean (115ms)  : 112, 117

    section Bailout
    This PR (8111) - mean (116ms)  : 115, 118
    master - mean (116ms)  : 113, 119

    section CallTarget+Inlining+NGEN
    This PR (8111) - mean (807ms)  : 757, 857
    master - mean (802ms)  : 753, 852
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8111) - mean (101ms)  : 99, 104
    master - mean (101ms)  : 98, 103

    section Bailout
    This PR (8111) - mean (102ms)  : 101, 103
    master - mean (101ms)  : 100, 103

    section CallTarget+Inlining+NGEN
    This PR (8111) - mean (775ms)  : 752, 797
    master - mean (770ms)  : 751, 789
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8111) - mean (100ms)  : 98, 102
    master - mean (100ms)  : 98, 102

    section Bailout
    This PR (8111) - mean (101ms)  : 100, 102
    master - mean (101ms)  : 100, 102

    section CallTarget+Inlining+NGEN
    This PR (8111) - mean (689ms)  : 672, 706
    master - mean (686ms)  : 668, 704
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8111) - mean (211ms)  : 199, 222
    master - mean (198ms)  : 193, 202

    section Bailout
    This PR (8111) - mean (213ms)  : crit, 203, 223
    master - mean (200ms)  : 197, 203

    section CallTarget+Inlining+NGEN
    This PR (8111) - mean (1,210ms)  : 1139, 1282
    master - mean (1,167ms)  : 1101, 1232
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8111) - mean (321ms)  : 303, 339
    master - mean (296ms)  : 288, 303

    section Bailout
    This PR (8111) - mean (324ms)  : crit, 310, 339
    master - mean (296ms)  : 289, 303

    section CallTarget+Inlining+NGEN
    This PR (8111) - mean (1,056ms)  : crit, 992, 1120
    master - mean (995ms)  : 945, 1046
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8111) - mean (309ms)  : 294, 323
    master - mean (288ms)  : 281, 294

    section Bailout
    This PR (8111) - mean (308ms)  : crit, 297, 319
    master - mean (286ms)  : 281, 291

    section CallTarget+Inlining+NGEN
    This PR (8111) - mean (1,045ms)  : 987, 1102
    master - mean (991ms)  : 955, 1026
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8111) - mean (318ms)  : 292, 345
    master - mean (286ms)  : 280, 293

    section Bailout
    This PR (8111) - mean (311ms)  : crit, 293, 330
    master - mean (287ms)  : 282, 291

    section CallTarget+Inlining+NGEN
    This PR (8111) - mean (1,089ms)  : crit, 985, 1193
    master - mean (885ms)  : 861, 910
Loading

@NachoEchevarria NachoEchevarria changed the title Fix compilation issues under VS Fix compilation issues under VS 2022 Feb 5, 2026
@NachoEchevarria NachoEchevarria marked this pull request as ready for review February 5, 2026 10:08
@NachoEchevarria NachoEchevarria requested review from a team as code owners February 5, 2026 10:08
@NachoEchevarria NachoEchevarria requested a review from a team as a code owner February 5, 2026 10:49
@pr-commenter
Copy link

pr-commenter bot commented Feb 5, 2026 •
edited
Loading

Benchmarks

Benchmark execution time: 2026-02-05 14:47:20

Comparing candidate commit 9f436ea in PR branch nacho/AvoidVSCompilationErrors with baseline commit 352de05 in branch master.

Found 7 performance improvements and 15 performance regressions! Performance is the same for 155 metrics, 15 unstable metrics.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟩 execution_time [-103.541ms; -100.179ms] or [-52.283%; -50.585%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 throughput [-79.519op/s; -77.128op/s] or [-13.559%; -13.151%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+106.098ms; +106.414ms] or [+104.816%; +105.128%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟩 execution_time [-17.599ms; -11.411ms] or [-8.280%; -5.368%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟥 execution_time [+15.266ms; +21.349ms] or [+7.769%; +10.865%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟩 execution_time [-20.535ms; -19.801ms] or [-10.163%; -9.800%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟩 throughput [+172.710op/s; +199.615op/s] or [+17.292%; +19.986%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+7.006ms; +12.933ms] or [+5.099%; +9.413%]
  • 🟥 throughput [-248.386op/s; -186.509op/s] or [-15.220%; -11.429%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0

  • 🟥 execution_time [+156.816µs; +164.224µs] or [+15.505%; +16.238%]
  • 🟥 throughput [-138.907op/s; -132.027op/s] or [-14.048%; -13.352%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice netcoreapp3.1

  • 🟥 throughput [-167.192op/s; -128.242op/s] or [-41.148%; -31.562%]

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net472

  • 🟩 throughput [+21696.542op/s; +24798.352op/s] or [+6.107%; +6.980%]

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net6.0

  • 🟥 execution_time [+11.812ms; +17.053ms] or [+6.011%; +8.678%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net472

  • 🟥 throughput [-20520.259op/s; -18711.366op/s] or [-6.863%; -6.258%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 throughput [-52087.179op/s; -40626.058op/s] or [-8.713%; -6.796%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0

  • 🟩 throughput [+1995.702op/s; +3785.652op/s] or [+9.681%; +18.364%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟩 throughput [+9433.770op/s; +11838.012op/s] or [+5.582%; +7.005%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0

  • 🟥 execution_time [+102.726ms; +104.702ms] or [+106.471%; +108.519%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟥 execution_time [+15.183ms; +20.076ms] or [+7.633%; +10.093%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟥 execution_time [+18.209ms; +22.210ms] or [+9.191%; +11.210%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0

  • 🟥 execution_time [+12.637ms; +16.887ms] or [+6.350%; +8.485%]

andrewlock
andrewlock approved these changes Feb 5, 2026
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

tracer/src/Datadog.Trace/Datadog.Trace.csproj Outdated
<!--DuckTyping-->
<PackageReference Include="System.Reflection.Emit" Version="4.3.0" />
<PackageReference Include="System.Reflection.Emit.Lightweight" Version="4.3.0" />
<PackageReference Include="System.Diagnostics.DiagnosticSource" Version="4.4.1" />
Copy link
Member

@andrewlock andrewlock Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd move this above the <!--DuckTyping--> comment, because it's not about duck typing 😄

Copy link
Collaborator Author

@NachoEchevarria NachoEchevarria Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, thanks!!!

GreenMatan
GreenMatan approved these changes Feb 5, 2026
View reviewed changes
Copy link
Contributor

@GreenMatan GreenMatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NachoEchevarria NachoEchevarria merged commit dcdc23f into master Feb 5, 2026
145 checks passed
@NachoEchevarria NachoEchevarria deleted the nacho/AvoidVSCompilationErrors branch February 5, 2026 16:59
@github-actions github-actions bot added this to the vNext-v3 milestone Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewlock andrewlock andrewlock approved these changes

+1 more reviewer

@GreenMatan GreenMatan GreenMatan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.37.0

Development

Successfully merging this pull request may close these issues.

3 participants

@NachoEchevarria @GreenMatan @andrewlock