Skip to content

fix benchmark code#8104

Merged
NachoEchevarria merged 1 commit intomasterfrom
vandonr/process
Jan 26, 2026
Merged

fix benchmark code#8104
NachoEchevarria merged 1 commit intomasterfrom
vandonr/process

Conversation

@vandonr
Copy link
Contributor

@vandonr vandonr commented Jan 26, 2026

Summary of changes

signature changed in #7871, and since the benchmark CI step was broken for another reason, I missed that.

Reason for change

Implementation details

Test coverage

Other details

@vandonr vandonr requested a review from a team as a code owner January 26, 2026 09:50
@github-actions github-actions bot added the area:tests unit tests, integration tests label Jan 26, 2026
@pr-commenter
Copy link

pr-commenter bot commented Jan 26, 2026

Benchmarks

Benchmark execution time: 2026-01-26 10:31:58

Comparing candidate commit 9ed2268 in PR branch vandonr/process with baseline commit aaaf6e1 in branch master.

Found 7 performance improvements and 10 performance regressions! Performance is the same for 160 metrics, 15 unstable metrics.

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+20.054ms; +20.208ms] or [+19.872%; +20.024%]

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+88.386ms; +88.592ms] or [+79.210%; +79.394%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟥 execution_time [+16.997ms; +23.421ms] or [+8.525%; +11.747%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-23.638ms; -17.624ms] or [-10.925%; -8.146%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+24.435ms; +24.583ms] or [+13.826%; +13.910%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark net6.0

  • 🟩 execution_time [-59.481µs; -31.882µs] or [-12.539%; -6.721%]
  • 🟩 throughput [+162.608op/s; +276.513op/s] or [+7.686%; +13.070%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • 🟥 throughput [-7461.706op/s; -7376.291op/s] or [-62.778%; -62.060%]
  • 🟩 execution_time [-198.626ms; -198.055ms] or [-98.367%; -98.084%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+25.564ms; +29.610ms] or [+13.355%; +15.469%]
  • 🟥 throughput [-84.653op/s; -63.650op/s] or [-7.233%; -5.439%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1

  • 🟩 throughput [+22903.818op/s; +32929.642op/s] or [+5.387%; +7.744%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 execution_time [-907.998µs; -850.616µs] or [-67.174%; -62.928%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1

  • 🟥 throughput [-34959.890op/s; -23528.419op/s] or [-8.410%; -5.660%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 throughput [-25278430.086op/s; -23802417.951op/s] or [-10.485%; -9.873%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0

  • 🟥 execution_time [+18.200ms; +23.670ms] or [+9.179%; +11.939%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟩 execution_time [-18.154ms; -12.512ms] or [-8.541%; -5.886%]

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Jan 26, 2026

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8104) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration68.40 ± (68.45 - 68.70) ms68.36 ± (68.42 - 68.68) ms-0.1%✅
.NET Framework 4.8 - Bailout
duration72.53 ± (72.53 - 72.75) ms72.33 ± (72.28 - 72.49) ms-0.3%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1004.87 ± (1010.46 - 1020.35) ms1010.64 ± (1017.69 - 1029.06) ms+0.6%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms21.92 ± (21.89 - 21.96) ms21.89 ± (21.86 - 21.91) ms-0.2%✅
process.time_to_main_ms78.97 ± (78.80 - 79.13) ms79.04 ± (78.89 - 79.18) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.92 ± (10.92 - 10.92) MB10.92 ± (10.92 - 10.93) MB+0.0%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms21.83 ± (21.81 - 21.85) ms21.82 ± (21.80 - 21.84) ms-0.0%✅
process.time_to_main_ms80.10 ± (79.98 - 80.21) ms79.96 ± (79.84 - 80.08) ms-0.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.97 ± (10.96 - 10.97) MB10.95 ± (10.94 - 10.95) MB-0.2%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms248.02 ± (244.60 - 251.43) ms252.15 ± (248.63 - 255.67) ms+1.7%✅⬆️
process.time_to_main_ms471.22 ± (470.54 - 471.90) ms471.33 ± (470.73 - 471.92) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.34 ± (48.32 - 48.36) MB48.42 ± (48.39 - 48.45) MB+0.2%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.1%✅
.NET 6 - Baseline
process.internal_duration_ms20.65 ± (20.62 - 20.67) ms20.64 ± (20.62 - 20.67) ms-0.0%✅
process.time_to_main_ms68.49 ± (68.37 - 68.61) ms68.45 ± (68.34 - 68.56) ms-0.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.61 ± (10.61 - 10.62) MB10.63 ± (10.63 - 10.63) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms20.57 ± (20.55 - 20.59) ms20.52 ± (20.50 - 20.54) ms-0.2%✅
process.time_to_main_ms69.35 ± (69.29 - 69.42) ms69.28 ± (69.24 - 69.33) ms-0.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.67 ± (10.67 - 10.68) MB10.73 ± (10.73 - 10.73) MB+0.5%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms249.27 ± (247.98 - 250.55) ms242.77 ± (239.97 - 245.56) ms-2.6%✅
process.time_to_main_ms447.84 ± (447.33 - 448.36) ms448.34 ± (447.82 - 448.86) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed49.18 ± (49.15 - 49.21) MB49.11 ± (49.08 - 49.14) MB-0.1%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms18.82 ± (18.79 - 18.84) ms18.96 ± (18.93 - 18.98) ms+0.7%✅⬆️
process.time_to_main_ms67.54 ± (67.42 - 67.65) ms67.53 ± (67.42 - 67.65) ms-0.0%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.69 ± (7.68 - 7.70) MB7.67 ± (7.66 - 7.68) MB-0.2%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms18.78 ± (18.75 - 18.81) ms18.96 ± (18.94 - 18.99) ms+1.0%✅⬆️
process.time_to_main_ms68.56 ± (68.48 - 68.64) ms68.50 ± (68.45 - 68.55) ms-0.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.74 ± (7.73 - 7.75) MB7.72 ± (7.71 - 7.73) MB-0.3%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms177.60 ± (176.79 - 178.42) ms178.14 ± (177.20 - 179.08) ms+0.3%✅⬆️
process.time_to_main_ms429.48 ± (428.82 - 430.14) ms429.32 ± (428.71 - 429.93) ms-0.0%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.63 ± (36.60 - 36.66) MB36.54 ± (36.50 - 36.57) MB-0.3%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.0%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration192.95 ± (192.72 - 193.62) ms192.30 ± (192.20 - 193.07) ms-0.3%✅
.NET Framework 4.8 - Bailout
duration195.48 ± (195.44 - 196.02) ms195.99 ± (195.73 - 196.26) ms+0.3%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1128.47 ± (1134.67 - 1146.45) ms1113.69 ± (1114.95 - 1122.61) ms-1.3%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms187.27 ± (186.91 - 187.64) ms186.26 ± (185.96 - 186.55) ms-0.5%✅
process.time_to_main_ms80.70 ± (80.49 - 80.90) ms80.19 ± (80.01 - 80.37) ms-0.6%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.08 ± (16.06 - 16.10) MB16.17 ± (16.14 - 16.19) MB+0.5%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (19 - 20)-0.2%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms186.52 ± (186.19 - 186.85) ms185.87 ± (185.53 - 186.20) ms-0.3%✅
process.time_to_main_ms81.76 ± (81.58 - 81.93) ms81.58 ± (81.45 - 81.70) ms-0.2%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.11 ± (16.09 - 16.13) MB16.13 ± (16.08 - 16.18) MB+0.1%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (20 - 21)-0.6%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms432.73 ± (429.54 - 435.93) ms429.85 ± (427.09 - 432.61) ms-0.7%✅
process.time_to_main_ms472.25 ± (471.59 - 472.91) ms469.50 ± (469.01 - 469.99) ms-0.6%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.84 ± (58.71 - 58.97) MB58.57 ± (58.45 - 58.69) MB-0.5%✅
runtime.dotnet.threads.count29 ± (29 - 30)29 ± (29 - 29)-0.0%✅
.NET 6 - Baseline
process.internal_duration_ms190.59 ± (190.27 - 190.91) ms190.80 ± (190.42 - 191.19) ms+0.1%✅⬆️
process.time_to_main_ms69.61 ± (69.44 - 69.78) ms69.74 ± (69.57 - 69.91) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed15.92 ± (15.76 - 16.08) MB16.06 ± (15.91 - 16.21) MB+0.9%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)+0.9%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms189.51 ± (189.28 - 189.75) ms189.74 ± (189.50 - 189.98) ms+0.1%✅⬆️
process.time_to_main_ms70.71 ± (70.61 - 70.81) ms70.83 ± (70.72 - 70.94) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed15.72 ± (15.55 - 15.88) MB15.99 ± (15.83 - 16.15) MB+1.7%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+1.2%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms444.58 ± (441.77 - 447.38) ms439.62 ± (436.39 - 442.86) ms-1.1%✅
process.time_to_main_ms448.36 ± (447.87 - 448.85) ms448.22 ± (447.76 - 448.69) ms-0.0%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed58.85 ± (58.72 - 58.97) MB58.95 ± (58.82 - 59.07) MB+0.2%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.1%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms188.59 ± (188.29 - 188.89) ms188.52 ± (188.22 - 188.83) ms-0.0%✅
process.time_to_main_ms69.28 ± (69.16 - 69.40) ms69.68 ± (69.46 - 69.91) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.80 ± (11.77 - 11.83) MB11.78 ± (11.75 - 11.81) MB-0.2%✅
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.0%✅
.NET 8 - Bailout
process.internal_duration_ms187.87 ± (187.65 - 188.08) ms187.92 ± (187.56 - 188.27) ms+0.0%✅⬆️
process.time_to_main_ms70.54 ± (70.46 - 70.63) ms70.47 ± (70.34 - 70.60) ms-0.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.89 ± (11.86 - 11.92) MB11.85 ± (11.82 - 11.89) MB-0.3%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.2%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms363.87 ± (362.42 - 365.33) ms367.27 ± (366.03 - 368.52) ms+0.9%✅⬆️
process.time_to_main_ms433.14 ± (432.53 - 433.75) ms436.99 ± (436.30 - 437.67) ms+0.9%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed48.28 ± (48.23 - 48.32) MB48.27 ± (48.24 - 48.31) MB-0.0%✅
runtime.dotnet.threads.count29 ± (28 - 29)29 ± (29 - 29)+0.6%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8104) - mean (69ms)  : 67, 70
    master - mean (69ms)  : 67, 70

    section Bailout
    This PR (8104) - mean (72ms)  : 71, 73
    master - mean (73ms)  : 72, 74

    section CallTarget+Inlining+NGEN
    This PR (8104) - mean (1,023ms)  : 936, 1110
    master - mean (1,015ms)  : 943, 1088
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8104) - mean (106ms)  : 103, 109
    master - mean (106ms)  : 103, 109

    section Bailout
    This PR (8104) - mean (107ms)  : 106, 108
    master - mean (107ms)  : 105, 109

    section CallTarget+Inlining+NGEN
    This PR (8104) - mean (750ms)  : 704, 796
    master - mean (746ms)  : 697, 796
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8104) - mean (94ms)  : 92, 96
    master - mean (94ms)  : 92, 96

    section Bailout
    This PR (8104) - mean (94ms)  : 93, 96
    master - mean (95ms)  : 94, 96

    section CallTarget+Inlining+NGEN
    This PR (8104) - mean (715ms)  : 675, 755
    master - mean (720ms)  : 694, 746
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8104) - mean (93ms)  : 90, 96
    master - mean (92ms)  : 90, 95

    section Bailout
    This PR (8104) - mean (93ms)  : 92, 95
    master - mean (93ms)  : 92, 94

    section CallTarget+Inlining+NGEN
    This PR (8104) - mean (635ms)  : 620, 650
    master - mean (635ms)  : 623, 647
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8104) - mean (193ms)  : 188, 197
    master - mean (193ms)  : 189, 198

    section Bailout
    This PR (8104) - mean (196ms)  : 194, 198
    master - mean (196ms)  : 193, 199

    section CallTarget+Inlining+NGEN
    This PR (8104) - mean (1,119ms)  : 1064, 1173
    master - mean (1,141ms)  : 1054, 1227
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8104) - mean (274ms)  : 270, 279
    master - mean (277ms)  : 271, 283

    section Bailout
    This PR (8104) - mean (275ms)  : 271, 279
    master - mean (276ms)  : 272, 281

    section CallTarget+Inlining+NGEN
    This PR (8104) - mean (926ms)  : 888, 964
    master - mean (933ms)  : 896, 970
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8104) - mean (269ms)  : 263, 275
    master - mean (268ms)  : 264, 273

    section Bailout
    This PR (8104) - mean (269ms)  : 266, 271
    master - mean (268ms)  : 265, 271

    section CallTarget+Inlining+NGEN
    This PR (8104) - mean (918ms)  : 871, 965
    master - mean (922ms)  : 879, 965
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8104) - mean (268ms)  : 264, 272
    master - mean (268ms)  : 262, 273

    section Bailout
    This PR (8104) - mean (268ms)  : 263, 272
    master - mean (268ms)  : 264, 272

    section CallTarget+Inlining+NGEN
    This PR (8104) - mean (835ms)  : 810, 861
    master - mean (829ms)  : 811, 846
Loading

@NachoEchevarria NachoEchevarria merged commit e62315b into master Jan 26, 2026
146 of 147 checks passed
@NachoEchevarria NachoEchevarria deleted the vandonr/process branch January 26, 2026 11:21
@github-actions github-actions bot added this to the vNext-v3 milestone Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NachoEchevarria NachoEchevarria NachoEchevarria approved these changes

Assignees

No one assigned

Labels

area:tests unit tests, integration tests

Projects

None yet

Milestone

3.36.0

Development

Successfully merging this pull request may close these issues.

2 participants

@vandonr @NachoEchevarria