Skip to content

Add feature-flagging-and-experimentation-sdk as code owners for FFE code#8095

Merged
leoromanovsky merged 2 commits intomasterfrom
leo/add-ffe-codeowners
Jan 23, 2026
Merged

Add feature-flagging-and-experimentation-sdk as code owners for FFE code#8095
leoromanovsky merged 2 commits intomasterfrom
leo/add-ffe-codeowners

Conversation

@leoromanovsky
Copy link
Contributor

Update CODEOWNERS to make @DataDog/feature-flagging-and-experimentation-sdk the primary code owner for Feature Flags code, with @DataDog/tracing-dotnet as secondary owner.

Paths covered:

  • /tracer/src/Datadog.Trace/FeatureFlags/
  • /tracer/src/Datadog.Trace.Manual/FeatureFlags/
  • /tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/ManualInstrumentation/FeatureFlags/
  • /tracer/test/Datadog.Trace.Tests/FeatureFlags/
  • /tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/FeatureFlags/
  • /tracer/test/test-applications/integrations/Samples.FeatureFlags/
  • /tracer/test/test-applications/integrations/Samples.OpenFeature/

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Update CODEOWNERS to make @DataDog/feature-flagging-and-experimentation-sdk
the primary code owner for Feature Flags code, with @DataDog/tracing-dotnet
as secondary owner.

Paths covered:
- /tracer/src/Datadog.Trace/FeatureFlags/
- /tracer/src/Datadog.Trace.Manual/FeatureFlags/
- /tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/ManualInstrumentation/FeatureFlags/
- /tracer/test/Datadog.Trace.Tests/FeatureFlags/
- /tracer/test/Datadog.Trace.ClrProfiler.IntegrationTests/FeatureFlags/
- /tracer/test/test-applications/integrations/Samples.FeatureFlags/
- /tracer/test/test-applications/integrations/Samples.OpenFeature/
@github-actions github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jan 22, 2026
@pr-commenter
Copy link

pr-commenter bot commented Jan 22, 2026

Benchmarks

Benchmark execution time: 2026-01-22 17:42:46

Comparing candidate commit b7a2620 in PR branch leo/add-ffe-codeowners with baseline commit 5636843 in branch master.

Found 7 performance improvements and 6 performance regressions! Performance is the same for 155 metrics, 24 unstable metrics.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • 🟩 throughput [+6261.688op/s; +8531.420op/s] or [+5.203%; +7.088%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟩 execution_time [-27.674ms; -21.184ms] or [-12.445%; -9.526%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody net6.0

  • 🟩 execution_time [-17.184ms; -11.777ms] or [-8.138%; -5.577%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟩 execution_time [-20.386ms; -19.636ms] or [-10.177%; -9.802%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • 🟥 execution_time [+43.341ms; +46.072ms] or [+28.298%; +30.081%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

  • 🟥 execution_time [+91.599µs; +97.388µs] or [+6.515%; +6.927%]
  • 🟥 throughput [-46.147op/s; -43.439op/s] or [-6.488%; -6.107%]

scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync netcoreapp3.1

  • 🟥 execution_time [+88.448ms; +91.047ms] or [+81.980%; +84.389%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟩 throughput [+15125.460op/s; +16820.016op/s] or [+9.375%; +10.425%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟩 throughput [+14684937.116op/s; +15836823.997op/s] or [+6.511%; +7.021%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟥 execution_time [+11.453ms; +16.593ms] or [+5.768%; +8.357%]
  • 🟥 throughput [-87394.128op/s; -64074.109op/s] or [-9.588%; -7.029%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟩 execution_time [-16.421ms; -12.580ms] or [-7.687%; -5.889%]

@leoromanovsky leoromanovsky marked this pull request as ready for review January 22, 2026 17:49
@leoromanovsky leoromanovsky requested a review from a team as a code owner January 22, 2026 17:49
@lucaspimentel
Copy link
Member

Does the order of owners make any difference? 😅

@leoromanovsky leoromanovsky merged commit 742ef61 into master Jan 23, 2026
115 of 118 checks passed
@leoromanovsky leoromanovsky deleted the leo/add-ffe-codeowners branch January 23, 2026 09:55
@github-actions github-actions bot added this to the vNext-v3 milestone Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants