[Build] Clean up SuppressTfmSupportBuildWarnings usage#8078
Merged
lucaspimentel merged 6 commits intomasterfrom Jan 16, 2026
Merged
[Build] Clean up SuppressTfmSupportBuildWarnings usage#8078lucaspimentel merged 6 commits intomasterfrom
SuppressTfmSupportBuildWarnings usage#8078lucaspimentel merged 6 commits intomasterfrom
Conversation
…dy covered by Directory.Build.props
SuppressTfmSupportBuildWarnings
lucaspimentel
commented
Jan 16, 2026
| <GeneratePackageOnBuild>true</GeneratePackageOnBuild> | ||
| <!-- NU* are workaround for Rider bug: https://youtrack.jetbrains.com/issue/RIDER-103207/Cannot-suppress-vulnerable-package-errors --> | ||
| <NoWarn>$(NoWarn);NU5100;NU5128;NU1901;NU1902;NU1903;NU1904</NoWarn> | ||
| <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> |
Member
Author
There was a problem hiding this comment.
This is the only new one added in this PR. The rest is cleanup.
lucaspimentel
commented
Jan 16, 2026
| <PropertyGroup> | ||
| <!-- System.Diagnostics.DiagnosticSource doesn't support netcoreapp3.1--> | ||
| <!-- https://andrewlock.net/stop-lying-about-netstandard-2-support/ --> | ||
| <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> |
Member
Author
There was a problem hiding this comment.
twice in same file 😅
lucaspimentel
commented
Jan 16, 2026
| @@ -1,9 +1,4 @@ | |||
| <Project> | |||
| <!-- | |||
| This file intentionally left blank... | |||
Member
Author
There was a problem hiding this comment.
This file is no longer blank...
lucaspimentel
commented
Jan 16, 2026
| <!-- NU* are workaround for Rider bug: https://youtrack.jetbrains.com/issue/RIDER-103207/Cannot-suppress-vulnerable-package-errors --> | ||
| <!-- PackageReference X will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary. --> | ||
| <NoWarn>SYSLIB0014;NU1901;NU1902;NU1903;NU1904;NU1510</NoWarn> | ||
| <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> |
Member
Author
There was a problem hiding this comment.
twice in same file 😅
SuppressTfmSupportBuildWarnings usage
zacharycmontoya
approved these changes
Jan 16, 2026
BenchmarksBenchmark execution time: 2026-01-16 17:57:01 Comparing candidate commit 0564f1e in PR branch Found 11 performance improvements and 5 performance regressions! Performance is the same for 160 metrics, 16 unstable metrics. scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery netcoreapp3.1
scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472
scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1
scenario:Benchmarks.Trace.NLogBenchmark.EnrichedLog net6.0
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8078) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8078) - mean (69ms) : 66, 72
master - mean (68ms) : 67, 70
section Bailout
This PR (8078) - mean (74ms) : 71, 77
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (8078) - mean (1,023ms) : 942, 1105
master - mean (1,005ms) : 947, 1063
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8078) - mean (106ms) : 104, 108
master - mean (106ms) : 104, 108
section Bailout
This PR (8078) - mean (107ms) : 105, 110
master - mean (107ms) : 105, 108
section CallTarget+Inlining+NGEN
This PR (8078) - mean (750ms) : 703, 797
master - mean (738ms) : 687, 789
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8078) - mean (94ms) : 92, 96
master - mean (94ms) : 91, 96
section Bailout
This PR (8078) - mean (95ms) : 94, 96
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (8078) - mean (721ms) : 677, 764
master - mean (719ms) : 687, 751
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8078) - mean (93ms) : 90, 95
master - mean (92ms) : 90, 94
section Bailout
This PR (8078) - mean (93ms) : 92, 94
master - mean (93ms) : 92, 94
section CallTarget+Inlining+NGEN
This PR (8078) - mean (638ms) : 619, 657
master - mean (684ms) : 576, 791
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8078) - mean (194ms) : 190, 199
master - mean (193ms) : 189, 197
section Bailout
This PR (8078) - mean (197ms) : 194, 201
master - mean (197ms) : 193, 200
section CallTarget+Inlining+NGEN
This PR (8078) - mean (1,132ms) : 1066, 1198
master - mean (1,133ms) : 1064, 1203
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8078) - mean (279ms) : 273, 285
master - mean (278ms) : 270, 285
section Bailout
This PR (8078) - mean (280ms) : 273, 288
master - mean (278ms) : 275, 281
section CallTarget+Inlining+NGEN
This PR (8078) - mean (936ms) : 891, 980
master - mean (935ms) : 889, 981
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8078) - mean (274ms) : 266, 282
master - mean (271ms) : 265, 276
section Bailout
This PR (8078) - mean (275ms) : 268, 282
master - mean (270ms) : 266, 273
section CallTarget+Inlining+NGEN
This PR (8078) - mean (918ms) : 856, 980
master - mean (922ms) : 874, 969
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8078) - mean (272ms) : 267, 277
master - mean (271ms) : 265, 276
section Bailout
This PR (8078) - mean (271ms) : 266, 277
master - mean (270ms) : 266, 275
section CallTarget+Inlining+NGEN
This PR (8078) - mean (843ms) : 798, 887
master - mean (833ms) : 816, 851
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
SuppressTfmSupportBuildWarningsMSBuild property toDatadog.Trace.BenchmarkDotNet.SuppressTfmSupportBuildWarningsusage across the repository to reduce redundancy and improve maintainability.Reason for change
Building
Datadog.Trace.BenchmarkDotNetresulted in several warning like:Many individual test projects had redundant
SuppressTfmSupportBuildWarningssettings that were already inherited from parentDirectory.Build.propsfiles.Implementation details
SuppressTfmSupportBuildWarningstoDatadog.Trace.BenchmarkDotNet.csprojwhich targets EOL frameworks but wasn't covered by Directory.Build.props.csprojfiles undertracer/test/that hadSuppressTfmSupportBuildWarningsalready inherited fromDirectory.Build.props.SuppressTfmSupportBuildWarningsin the case fileDirectory.Build.propsto clarify purpose of warning suppressionsTest coverage
Not required. The only visible change is the suppression of warnings when building
Datadog.Trace.BenchmarkDotNet.Other details
See https://andrewlock.net/stop-lying-about-netstandard-2-support
Projects now inherit
SuppressTfmSupportBuildWarningsfrom:tracer/test/Directory.Build.props(covers all test projects)tracer/test/test-applications/Directory.Build.props(covers test applications)tracer/test/test-applications/integrations/dependency-libs/Directory.Build.props(covers dependency libs)Datadog.Trace.BenchmarkDotNet,Datadog.Trace.Coverage.collector)