[Profiler] Fix crash when calling GetAppDomainInfo#8076
Conversation
BenchmarksBenchmark execution time: 2026-01-19 09:22:33 Comparing candidate commit d286b90 in PR branch Found 9 performance improvements and 4 performance regressions! Performance is the same for 159 metrics, 20 unstable metrics. scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0
scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net472
scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0
scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8076) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8076) - mean (68ms) : 67, 70
master - mean (68ms) : 67, 70
section Bailout
This PR (8076) - mean (72ms) : 71, 73
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (8076) - mean (1,022ms) : 938, 1106
master - mean (1,013ms) : 943, 1082
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8076) - mean (106ms) : 103, 108
master - mean (106ms) : 103, 108
section Bailout
This PR (8076) - mean (107ms) : 106, 108
master - mean (107ms) : 105, 108
section CallTarget+Inlining+NGEN
This PR (8076) - mean (740ms) : 685, 794
master - mean (736ms) : 685, 786
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8076) - mean (94ms) : 92, 96
master - mean (94ms) : 92, 96
section Bailout
This PR (8076) - mean (95ms) : 94, 96
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (8076) - mean (718ms) : 685, 752
master - mean (715ms) : 680, 750
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8076) - mean (92ms) : 90, 94
master - mean (92ms) : 90, 95
section Bailout
This PR (8076) - mean (93ms) : 92, 94
master - mean (93ms) : 92, 95
section CallTarget+Inlining+NGEN
This PR (8076) - mean (636ms) : 617, 656
master - mean (636ms) : 622, 651
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8076) - mean (194ms) : 189, 199
master - mean (192ms) : 188, 196
section Bailout
This PR (8076) - mean (200ms) : 195, 205
master - mean (195ms) : 193, 198
section CallTarget+Inlining+NGEN
This PR (8076) - mean (1,139ms) : 1066, 1211
master - mean (1,124ms) : 1053, 1195
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8076) - mean (276ms) : 271, 281
master - mean (275ms) : 270, 280
section Bailout
This PR (8076) - mean (277ms) : 272, 282
master - mean (276ms) : 271, 280
section CallTarget+Inlining+NGEN
This PR (8076) - mean (930ms) : 889, 972
master - mean (926ms) : 880, 972
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8076) - mean (270ms) : 264, 276
master - mean (269ms) : 264, 274
section Bailout
This PR (8076) - mean (271ms) : 265, 277
master - mean (268ms) : 265, 272
section CallTarget+Inlining+NGEN
This PR (8076) - mean (914ms) : 856, 973
master - mean (916ms) : 855, 976
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8076) - mean (270ms) : 263, 277
master - mean (268ms) : 263, 272
section Bailout
This PR (8076) - mean (269ms) : 264, 273
master - mean (268ms) : 263, 273
section CallTarget+Inlining+NGEN
This PR (8076) - mean (829ms) : 814, 845
master - mean (829ms) : 811, 847
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
bb0ae70 to
d286b90
Compare
Summary of changes
Fixing a crash when the profiler calls
GetAppDomainInfo.Reason for change
There might be a race at some point (the appdomain being destroyed and the profiler calling into the CLR to get the AppDomain name).
Implementation details
GetAppDomainInfo.Test coverage
GetAppDomainInfofor an unloaded AppDomain does not crash.Other details