Skip to content

[FFE] Fix exposures url#8074

Merged
daniel-romano-DD merged 5 commits intomasterfrom
dani/ffe/fix_exposures_url
Jan 16, 2026
Merged

[FFE] Fix exposures url#8074
daniel-romano-DD merged 5 commits intomasterfrom
dani/ffe/fix_exposures_url

Conversation

@daniel-romano-DD
Copy link
Contributor

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@daniel-romano-DD daniel-romano-DD marked this pull request as ready for review January 15, 2026 17:16
@daniel-romano-DD daniel-romano-DD requested review from a team as code owners January 15, 2026 17:16
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:oops: we should definitely add some integration tests to make it easy to confirm behaviours once we get the system tests locked down 😅

Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:oops: we should definitely add some integration tests to make it easy to confirm behaviours once we get the system tests locked down 😅

@pr-commenter
Copy link

pr-commenter bot commented Jan 15, 2026

Benchmarks

Benchmark execution time: 2026-01-16 01:30:22

Comparing candidate commit 36f5e1f in PR branch dani/ffe/fix_exposures_url with baseline commit 1863e47 in branch master.

Found 9 performance improvements and 8 performance regressions! Performance is the same for 158 metrics, 17 unstable metrics.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0

  • 🟥 throughput [-82271.938op/s; -81176.169op/s] or [-66.356%; -65.472%]

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟥 throughput [-9212.946op/s; -7552.240op/s] or [-9.455%; -7.751%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟩 execution_time [-19.374ms; -13.972ms] or [-9.013%; -6.500%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-21.055ms; -15.527ms] or [-9.926%; -7.320%]
  • 🟩 throughput [+165779.320op/s; +236389.568op/s] or [+7.055%; +10.060%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟥 execution_time [+23.045ms; +23.414ms] or [+12.912%; +13.119%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟩 execution_time [-20.552ms; -20.123ms] or [-10.223%; -10.010%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟩 execution_time [-37.985ms; -33.990ms] or [-19.723%; -17.649%]
  • 🟩 throughput [+86.695op/s; +114.224op/s] or [+6.519%; +8.589%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0

  • 🟥 throughput [-42473.493op/s; -32780.215op/s] or [-7.030%; -5.426%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472

  • 🟩 throughput [+26669.991op/s; +28332.812op/s] or [+7.128%; +7.572%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1

  • 🟥 execution_time [+3.841µs; +8.524µs] or [+8.040%; +17.841%]
  • 🟥 throughput [-2899.435op/s; -1511.163op/s] or [-13.804%; -7.195%]

scenario:Benchmarks.Trace.NLogBenchmark.EnrichedLog netcoreapp3.1

  • 🟩 execution_time [-80.267ms; -77.562ms] or [-40.323%; -38.964%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472

  • 🟩 throughput [+18585.283op/s; +20744.102op/s] or [+5.609%; +6.260%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472

  • 🟥 throughput [-12901.469op/s; -11839.084op/s] or [-8.652%; -7.940%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟥 execution_time [+11.287ms; +17.147ms] or [+5.758%; +8.748%]

@datadog-official

This comment has been minimized.

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Jan 15, 2026

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8074) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration68.18 ± (68.14 - 68.35) ms68.45 ± (68.40 - 68.63) ms+0.4%✅⬆️
.NET Framework 4.8 - Bailout
duration72.21 ± (72.12 - 72.37) ms72.09 ± (72.03 - 72.25) ms-0.2%
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1002.41 ± (1004.99 - 1013.95) ms997.78 ± (1002.08 - 1010.07) ms-0.5%
.NET Core 3.1 - Baseline
process.internal_duration_ms21.87 ± (21.84 - 21.91) ms21.80 ± (21.77 - 21.83) ms-0.3%
process.time_to_main_ms78.64 ± (78.49 - 78.78) ms78.62 ± (78.47 - 78.77) ms-0.0%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.90 ± (10.90 - 10.91) MB10.91 ± (10.90 - 10.91) MB+0.0%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%
.NET Core 3.1 - Bailout
process.internal_duration_ms21.85 ± (21.83 - 21.87) ms21.74 ± (21.71 - 21.76) ms-0.5%
process.time_to_main_ms79.79 ± (79.69 - 79.88) ms79.91 ± (79.80 - 80.02) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.93 ± (10.93 - 10.94) MB10.95 ± (10.94 - 10.95) MB+0.1%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms243.68 ± (240.27 - 247.09) ms238.86 ± (235.33 - 242.40) ms-2.0%
process.time_to_main_ms467.73 ± (467.21 - 468.25) ms468.13 ± (467.56 - 468.70) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed48.32 ± (48.30 - 48.35) MB48.35 ± (48.33 - 48.38) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.1%
.NET 6 - Baseline
process.internal_duration_ms20.74 ± (20.71 - 20.76) ms20.76 ± (20.73 - 20.78) ms+0.1%✅⬆️
process.time_to_main_ms68.34 ± (68.20 - 68.48) ms68.39 ± (68.27 - 68.51) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.61 ± (10.61 - 10.62) MB10.62 ± (10.62 - 10.63) MB+0.1%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 6 - Bailout
process.internal_duration_ms20.69 ± (20.67 - 20.71) ms20.68 ± (20.66 - 20.70) ms-0.0%
process.time_to_main_ms69.09 ± (69.01 - 69.16) ms69.13 ± (69.08 - 69.18) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.71 ± (10.70 - 10.71) MB10.71 ± (10.71 - 10.72) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms247.75 ± (246.15 - 249.35) ms239.91 ± (236.90 - 242.93) ms-3.2%
process.time_to_main_ms445.88 ± (445.42 - 446.33) ms445.68 ± (445.25 - 446.12) ms-0.0%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed49.12 ± (49.09 - 49.15) MB49.16 ± (49.12 - 49.19) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.1%
.NET 8 - Baseline
process.internal_duration_ms18.79 ± (18.76 - 18.82) ms18.86 ± (18.83 - 18.89) ms+0.4%✅⬆️
process.time_to_main_ms67.22 ± (67.09 - 67.36) ms67.46 ± (67.34 - 67.57) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.67 ± (7.67 - 7.68) MB7.65 ± (7.64 - 7.65) MB-0.4%
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 8 - Bailout
process.internal_duration_ms18.86 ± (18.84 - 18.88) ms18.91 ± (18.88 - 18.94) ms+0.2%✅⬆️
process.time_to_main_ms68.46 ± (68.40 - 68.51) ms68.56 ± (68.47 - 68.65) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.72 ± (7.71 - 7.73) MB7.71 ± (7.70 - 7.72) MB-0.1%
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms178.77 ± (177.95 - 179.59) ms177.54 ± (176.63 - 178.45) ms-0.7%
process.time_to_main_ms429.13 ± (428.46 - 429.79) ms429.86 ± (429.20 - 430.53) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed36.50 ± (36.47 - 36.53) MB36.53 ± (36.50 - 36.57) MB+0.1%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)26 ± (26 - 26)-0.4%

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration195.38 ± (195.36 - 196.27) ms193.68 ± (193.45 - 194.28) ms-0.9%
.NET Framework 4.8 - Bailout
duration198.69 ± (198.51 - 199.44) ms197.61 ± (197.64 - 198.39) ms-0.5%
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1144.33 ± (1143.77 - 1151.74) ms1119.86 ± (1122.28 - 1130.18) ms-2.1%
.NET Core 3.1 - Baseline
process.internal_duration_ms194.70 ± (194.25 - 195.16) ms188.25 ± (187.85 - 188.64) ms-3.3%
process.time_to_main_ms84.19 ± (83.97 - 84.41) ms81.13 ± (80.89 - 81.36) ms-3.6%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.05 ± (16.02 - 16.07) MB16.10 ± (16.08 - 16.13) MB+0.3%✅⬆️
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (19 - 20)-0.2%
.NET Core 3.1 - Bailout
process.internal_duration_ms193.36 ± (192.99 - 193.73) ms186.98 ± (186.69 - 187.27) ms-3.3%
process.time_to_main_ms85.00 ± (84.80 - 85.21) ms82.23 ± (82.10 - 82.37) ms-3.3%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.12 ± (16.09 - 16.15) MB16.20 ± (16.17 - 16.23) MB+0.5%✅⬆️
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (21 - 21)+0.8%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms425.23 ± (421.71 - 428.74) ms429.76 ± (426.73 - 432.79) ms+1.1%✅⬆️
process.time_to_main_ms480.85 ± (479.90 - 481.81) ms473.81 ± (473.19 - 474.43) ms-1.5%
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed58.80 ± (58.68 - 58.92) MB58.80 ± (58.69 - 58.91) MB+0.0%✅⬆️
runtime.dotnet.threads.count30 ± (29 - 30)29 ± (29 - 30)-0.1%
.NET 6 - Baseline
process.internal_duration_ms194.45 ± (194.00 - 194.91) ms192.32 ± (191.93 - 192.71) ms-1.1%
process.time_to_main_ms70.87 ± (70.66 - 71.09) ms70.17 ± (69.98 - 70.36) ms-1.0%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.29 ± (16.21 - 16.36) MB16.09 ± (15.94 - 16.23) MB-1.2%
runtime.dotnet.threads.count19 ± (19 - 19)18 ± (18 - 18)-3.4%
.NET 6 - Bailout
process.internal_duration_ms192.99 ± (192.67 - 193.31) ms191.22 ± (190.96 - 191.49) ms-0.9%
process.time_to_main_ms71.73 ± (71.54 - 71.92) ms71.18 ± (71.06 - 71.30) ms-0.8%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.25 ± (16.14 - 16.37) MB16.37 ± (16.27 - 16.47) MB+0.7%✅⬆️
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (20 - 20)+0.7%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms442.40 ± (439.04 - 445.75) ms443.31 ± (439.97 - 446.64) ms+0.2%✅⬆️
process.time_to_main_ms457.39 ± (456.57 - 458.21) ms453.01 ± (452.43 - 453.58) ms-1.0%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed59.08 ± (58.95 - 59.20) MB59.03 ± (58.90 - 59.16) MB-0.1%
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.0%
.NET 8 - Baseline
process.internal_duration_ms196.26 ± (195.39 - 197.12) ms190.04 ± (189.69 - 190.40) ms-3.2%
process.time_to_main_ms71.81 ± (71.49 - 72.13) ms70.18 ± (69.96 - 70.41) ms-2.3%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.67 ± (11.65 - 11.69) MB11.79 ± (11.76 - 11.81) MB+1.1%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.9%
.NET 8 - Bailout
process.internal_duration_ms193.01 ± (192.52 - 193.50) ms189.43 ± (189.11 - 189.74) ms-1.9%
process.time_to_main_ms71.94 ± (71.77 - 72.11) ms71.02 ± (70.88 - 71.17) ms-1.3%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.75 ± (11.73 - 11.77) MB11.84 ± (11.81 - 11.87) MB+0.8%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.5%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms371.92 ± (370.61 - 373.24) ms366.06 ± (364.66 - 367.46) ms-1.6%
process.time_to_main_ms440.75 ± (439.98 - 441.51) ms436.23 ± (435.38 - 437.07) ms-1.0%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed48.17 ± (48.14 - 48.20) MB48.23 ± (48.19 - 48.27) MB+0.1%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.9%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8)
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8074) - mean (69ms)  : 67, 70
    master - mean (68ms)  : 67, 70

    section Bailout
    This PR (8074) - mean (72ms)  : 71, 73
    master - mean (72ms)  : 71, 73

    section CallTarget+Inlining+NGEN
    This PR (8074) - mean (1,006ms)  : 949, 1063
    master - mean (1,009ms)  : 946, 1073

Loading
FakeDbCommand (.NET Core 3.1)
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8074) - mean (106ms)  : 103, 108
    master - mean (106ms)  : 103, 108

    section Bailout
    This PR (8074) - mean (107ms)  : 105, 108
    master - mean (107ms)  : 106, 108

    section CallTarget+Inlining+NGEN
    This PR (8074) - mean (734ms)  : 678, 789
    master - mean (736ms)  : 685, 786

Loading
FakeDbCommand (.NET 6)
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8074) - mean (94ms)  : 92, 96
    master - mean (94ms)  : 92, 96

    section Bailout
    This PR (8074) - mean (95ms)  : 94, 95
    master - mean (94ms)  : 94, 95

    section CallTarget+Inlining+NGEN
    This PR (8074) - mean (708ms)  : 655, 761
    master - mean (717ms)  : 691, 743

Loading
FakeDbCommand (.NET 8)
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8074) - mean (93ms)  : 90, 96
    master - mean (92ms)  : 89, 95

    section Bailout
    This PR (8074) - mean (93ms)  : 92, 95
    master - mean (93ms)  : 92, 94

    section CallTarget+Inlining+NGEN
    This PR (8074) - mean (636ms)  : 622, 649
    master - mean (636ms)  : 616, 656

Loading
HttpMessageHandler (.NET Framework 4.8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8074) - mean (194ms)  : 190, 198
    master - mean (196ms)  : 190, 202

    section Bailout
    This PR (8074) - mean (198ms)  : 194, 202
    master - mean (199ms)  : 195, 203

    section CallTarget+Inlining+NGEN
    This PR (8074) - mean (1,126ms)  : 1070, 1183
    master - mean (1,148ms)  : 1091, 1205

Loading
HttpMessageHandler (.NET Core 3.1)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8074) - mean (278ms)  : 269, 288
    master - mean (288ms)  : 280, 296

    section Bailout
    This PR (8074) - mean (278ms)  : 275, 281
    master - mean (287ms)  : 283, 292

    section CallTarget+Inlining+NGEN
    This PR (8074) - mean (930ms)  : 879, 981
    master - mean (941ms)  : 896, 986

Loading
HttpMessageHandler (.NET 6)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8074) - mean (271ms)  : 264, 277
    master - mean (274ms)  : 266, 282

    section Bailout
    This PR (8074) - mean (270ms)  : 267, 273
    master - mean (273ms)  : 268, 277

    section CallTarget+Inlining+NGEN
    This PR (8074) - mean (927ms)  : 866, 987
    master - mean (933ms)  : 887, 979

Loading
HttpMessageHandler (.NET 8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8074) - mean (270ms)  : 264, 275
    master - mean (279ms)  : 261, 297

    section Bailout
    This PR (8074) - mean (270ms)  : 265, 275
    master - mean (275ms)  : 265, 284

    section CallTarget+Inlining+NGEN
    This PR (8074) - mean (832ms)  : 814, 850
    master - mean (843ms)  : 813, 873

Loading

@daniel-romano-DD daniel-romano-DD merged commit a598077 into master Jan 16, 2026
151 checks passed
@daniel-romano-DD daniel-romano-DD deleted the dani/ffe/fix_exposures_url branch January 16, 2026 06:11
@github-actions github-actions bot added this to the vNext-v3 milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants