Conversation
andrewlock
left a comment
There was a problem hiding this comment.
:oops: we should definitely add some integration tests to make it easy to confirm behaviours once we get the system tests locked down 😅
andrewlock
left a comment
There was a problem hiding this comment.
:oops: we should definitely add some integration tests to make it easy to confirm behaviours once we get the system tests locked down 😅
BenchmarksBenchmark execution time: 2026-01-16 01:30:22 Comparing candidate commit 36f5e1f in PR branch Found 9 performance improvements and 8 performance regressions! Performance is the same for 158 metrics, 17 unstable metrics. scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1
scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch net6.0
scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net472
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1
scenario:Benchmarks.Trace.NLogBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net472
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1
|
This comment has been minimized.
This comment has been minimized.
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8074) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8074) - mean (69ms) : 67, 70
master - mean (68ms) : 67, 70
section Bailout
This PR (8074) - mean (72ms) : 71, 73
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (8074) - mean (1,006ms) : 949, 1063
master - mean (1,009ms) : 946, 1073
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8074) - mean (106ms) : 103, 108
master - mean (106ms) : 103, 108
section Bailout
This PR (8074) - mean (107ms) : 105, 108
master - mean (107ms) : 106, 108
section CallTarget+Inlining+NGEN
This PR (8074) - mean (734ms) : 678, 789
master - mean (736ms) : 685, 786
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8074) - mean (94ms) : 92, 96
master - mean (94ms) : 92, 96
section Bailout
This PR (8074) - mean (95ms) : 94, 95
master - mean (94ms) : 94, 95
section CallTarget+Inlining+NGEN
This PR (8074) - mean (708ms) : 655, 761
master - mean (717ms) : 691, 743
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8074) - mean (93ms) : 90, 96
master - mean (92ms) : 89, 95
section Bailout
This PR (8074) - mean (93ms) : 92, 95
master - mean (93ms) : 92, 94
section CallTarget+Inlining+NGEN
This PR (8074) - mean (636ms) : 622, 649
master - mean (636ms) : 616, 656
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8074) - mean (194ms) : 190, 198
master - mean (196ms) : 190, 202
section Bailout
This PR (8074) - mean (198ms) : 194, 202
master - mean (199ms) : 195, 203
section CallTarget+Inlining+NGEN
This PR (8074) - mean (1,126ms) : 1070, 1183
master - mean (1,148ms) : 1091, 1205
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8074) - mean (278ms) : 269, 288
master - mean (288ms) : 280, 296
section Bailout
This PR (8074) - mean (278ms) : 275, 281
master - mean (287ms) : 283, 292
section CallTarget+Inlining+NGEN
This PR (8074) - mean (930ms) : 879, 981
master - mean (941ms) : 896, 986
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8074) - mean (271ms) : 264, 277
master - mean (274ms) : 266, 282
section Bailout
This PR (8074) - mean (270ms) : 267, 273
master - mean (273ms) : 268, 277
section CallTarget+Inlining+NGEN
This PR (8074) - mean (927ms) : 866, 987
master - mean (933ms) : 887, 979
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8074) - mean (270ms) : 264, 275
master - mean (279ms) : 261, 297
section Bailout
This PR (8074) - mean (270ms) : 265, 275
master - mean (275ms) : 265, 284
section CallTarget+Inlining+NGEN
This PR (8074) - mean (832ms) : 814, 850
master - mean (843ms) : 813, 873
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary of changes
Reason for change
Implementation details
Test coverage
Other details