[ASM] Fix RC configs apply order#8066
Merged
daniel-romano-DD merged 1 commit intomasterfrom Jan 15, 2026
Merged
Conversation
e-n-0
approved these changes
Jan 15, 2026
| if (files is { Count: > 0 }) | ||
| { | ||
| configurationStatus.RulesetConfigs.Remove(removedConfig.Path); | ||
| // var file = files.First(); |
BenchmarksBenchmark execution time: 2026-01-15 15:39:01 Comparing candidate commit 952e07d in PR branch Found 10 performance improvements and 1 performance regressions! Performance is the same for 168 metrics, 13 unstable metrics. scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0
scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch netcoreapp3.1
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark net6.0
scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8066) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8066) - mean (69ms) : 67, 71
master - mean (68ms) : 67, 70
section Bailout
This PR (8066) - mean (73ms) : 71, 74
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (8066) - mean (1,015ms) : 962, 1069
master - mean (1,008ms) : 946, 1070
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8066) - mean (109ms) : 103, 115
master - mean (106ms) : 104, 109
section Bailout
This PR (8066) - mean (109ms) : 105, 113
master - mean (107ms) : 105, 108
section CallTarget+Inlining+NGEN
This PR (8066) - mean (751ms) : 688, 814
master - mean (754ms) : 729, 778
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8066) - mean (96ms) : 91, 101
master - mean (94ms) : 91, 97
section Bailout
This PR (8066) - mean (100ms) : crit, 96, 105
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (8066) - mean (737ms) : 694, 780
master - mean (719ms) : 694, 743
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8066) - mean (94ms) : 91, 97
master - mean (92ms) : 90, 94
section Bailout
This PR (8066) - mean (94ms) : 92, 96
master - mean (93ms) : 92, 94
section CallTarget+Inlining+NGEN
This PR (8066) - mean (641ms) : 622, 660
master - mean (634ms) : 618, 650
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8066) - mean (194ms) : 190, 198
master - mean (193ms) : 187, 199
section Bailout
This PR (8066) - mean (198ms) : 196, 200
master - mean (196ms) : 193, 200
section CallTarget+Inlining+NGEN
This PR (8066) - mean (1,138ms) : 1071, 1205
master - mean (1,133ms) : 1063, 1203
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8066) - mean (279ms) : 273, 285
master - mean (278ms) : 271, 284
section Bailout
This PR (8066) - mean (279ms) : 275, 283
master - mean (277ms) : 273, 282
section CallTarget+Inlining+NGEN
This PR (8066) - mean (937ms) : 886, 988
master - mean (938ms) : 904, 973
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8066) - mean (272ms) : 267, 278
master - mean (270ms) : 266, 274
section Bailout
This PR (8066) - mean (272ms) : 267, 276
master - mean (270ms) : 266, 274
section CallTarget+Inlining+NGEN
This PR (8066) - mean (937ms) : 895, 980
master - mean (929ms) : 880, 977
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8066) - mean (271ms) : 264, 278
master - mean (269ms) : 265, 274
section Bailout
This PR (8066) - mean (271ms) : 267, 275
master - mean (270ms) : 265, 274
section CallTarget+Inlining+NGEN
This PR (8066) - mean (838ms) : 819, 858
master - mean (831ms) : 810, 851
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
Implementation details
Test coverage
Other details