Skip to content

Update CODEOWNERS for feature flagging work#8063

Merged
andrewlock merged 1 commit intomasterfrom
andrew/codeowners
Jan 15, 2026
Merged

Update CODEOWNERS for feature flagging work#8063
andrewlock merged 1 commit intomasterfrom
andrew/codeowners

Conversation

@andrewlock
Copy link
Member

Summary of changes

Adds FFE to codeowners

Reason for change

The FFE work is being owned by ASM at the moment

Implementation details

Add ASM to be co-owners of some core FFE-specific parts

@andrewlock andrewlock requested a review from a team as a code owner January 15, 2026 10:10
@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jan 15, 2026
@pr-commenter
Copy link

pr-commenter bot commented Jan 15, 2026

Benchmarks

Benchmark execution time: 2026-01-15 10:57:52

Comparing candidate commit 60e3b65 in PR branch andrew/codeowners with baseline commit 3ad282c in branch master.

Found 3 performance improvements and 8 performance regressions! Performance is the same for 166 metrics, 15 unstable metrics.

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟩 execution_time [-80.593ms; -80.400ms] or [-39.783%; -39.688%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • 🟥 execution_time [+106.373ms; +107.703ms] or [+112.158%; +113.560%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+10.717ms; +15.255ms] or [+5.392%; +7.675%]
  • 🟥 throughput [-156.566op/s; -133.020op/s] or [-13.889%; -11.800%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 throughput [-163.410op/s; -126.444op/s] or [-10.733%; -8.305%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟥 execution_time [+17.242ms; +20.817ms] or [+12.316%; +14.869%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0

  • 🟩 execution_time [-138.523µs; -133.463µs] or [-11.978%; -11.541%]
  • 🟩 throughput [+113.265op/s; +117.184op/s] or [+13.098%; +13.552%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

  • 🟥 throughput [-19465076.271op/s; -18347817.984op/s] or [-7.961%; -7.504%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • 🟥 execution_time [+24.838ms; +30.103ms] or [+14.264%; +17.287%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟥 execution_time [+10.180ms; +15.100ms] or [+5.144%; +7.630%]

Copy link
Contributor

@daniel-romano-DD daniel-romano-DD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot :)

@andrewlock andrewlock merged commit 5f950df into master Jan 15, 2026
100 of 103 checks passed
@andrewlock andrewlock deleted the andrew/codeowners branch January 15, 2026 15:11
@github-actions github-actions bot added this to the vNext-v3 milestone Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants