Fix build by splitting FleetInstaller integration tests into their own test project#8044
Fix build by splitting FleetInstaller integration tests into their own test project#8044andrewlock merged 7 commits intomasterfrom
FleetInstaller integration tests into their own test project#8044Conversation
BenchmarksBenchmark execution time: 2026-01-13 08:51:55 Comparing candidate commit 5bcbc9b in PR branch Found 7 performance improvements and 12 performance regressions! Performance is the same for 150 metrics, 17 unstable metrics. scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472
scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1
scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0
scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1
scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0
scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net6.0
scenario:Benchmarks.Trace.HttpClientBenchmark.SendAsync netcoreapp3.1
scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark netcoreapp3.1
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net6.0
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8044) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8044) - mean (68ms) : 67, 70
master - mean (68ms) : 67, 70
section Bailout
This PR (8044) - mean (72ms) : 71, 73
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (8044) - mean (1,013ms) : 962, 1063
master - mean (1,008ms) : 965, 1051
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8044) - mean (106ms) : 103, 108
master - mean (106ms) : 104, 108
section Bailout
This PR (8044) - mean (107ms) : 106, 108
master - mean (107ms) : 106, 108
section CallTarget+Inlining+NGEN
This PR (8044) - mean (741ms) : 685, 796
master - mean (740ms) : 677, 802
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8044) - mean (94ms) : 92, 96
master - mean (93ms) : 92, 95
section Bailout
This PR (8044) - mean (94ms) : 93, 95
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (8044) - mean (711ms) : 681, 741
master - mean (716ms) : 686, 746
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8044) - mean (92ms) : 89, 94
master - mean (92ms) : 90, 94
section Bailout
This PR (8044) - mean (93ms) : 92, 94
master - mean (93ms) : 92, 94
section CallTarget+Inlining+NGEN
This PR (8044) - mean (631ms) : 613, 649
master - mean (632ms) : 611, 652
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8044) - mean (193ms) : 189, 197
master - mean (193ms) : 188, 197
section Bailout
This PR (8044) - mean (196ms) : 193, 199
master - mean (196ms) : 193, 199
section CallTarget+Inlining+NGEN
This PR (8044) - mean (1,113ms) : 1061, 1165
master - mean (1,118ms) : 1059, 1177
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8044) - mean (276ms) : 272, 280
master - mean (276ms) : 271, 281
section Bailout
This PR (8044) - mean (276ms) : 271, 280
master - mean (277ms) : 273, 281
section CallTarget+Inlining+NGEN
This PR (8044) - mean (931ms) : 888, 974
master - mean (927ms) : 885, 970
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8044) - mean (271ms) : 266, 277
master - mean (270ms) : 265, 275
section Bailout
This PR (8044) - mean (270ms) : 265, 275
master - mean (269ms) : 266, 271
section CallTarget+Inlining+NGEN
This PR (8044) - mean (926ms) : 886, 966
master - mean (924ms) : 880, 969
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8044) - mean (269ms) : 263, 275
master - mean (269ms) : 264, 274
section Bailout
This PR (8044) - mean (269ms) : 266, 271
master - mean (268ms) : 266, 271
section CallTarget+Inlining+NGEN
This PR (8044) - mean (828ms) : 805, 852
master - mean (824ms) : 805, 843
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This comment has been minimized.
This comment has been minimized.
ad76ea4 to
c9e2e03
Compare
…adog.FleetInstaller stuff
… right platform + FX
d17ae3e to
2f55b90
Compare
.../test/Datadog.FleetInstaller.IntegrationTests/Datadog.FleetInstaller.IntegrationTests.csproj
Outdated
Show resolved
Hide resolved
FleetInstaller integration tests into their own test project
Summary of changes
FleetInstallerintegration tests to their own projectReason for change
The integration tests on .NET Framrework, x86, are failing due to a missing binary, and have been for some time 😬 This fixes those tests so that they actually run. Separately we will do work to detect if/when that scenario happens again.
Implementation details
Before resorting to this approach, I tried a bunch of other things, such as building the project for
AnyCPUinstead of thex64that we currently have. However, then NuGet restore failed, which I remember is the reason why it is like this in the first place 🙄Its not pretty, but at least now it works
Test coverage
This is the test. They're actually running now.