Merged
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8014) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8014) - mean (69ms) : 67, 70
master - mean (68ms) : 67, 70
section Bailout
This PR (8014) - mean (72ms) : 71, 73
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (8014) - mean (1,006ms) : 970, 1042
master - mean (1,007ms) : 967, 1048
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8014) - mean (106ms) : 103, 108
master - mean (106ms) : 103, 109
section Bailout
This PR (8014) - mean (107ms) : 106, 109
master - mean (107ms) : 106, 108
section CallTarget+Inlining+NGEN
This PR (8014) - mean (740ms) : 668, 812
master - mean (726ms) : 661, 791
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8014) - mean (93ms) : 92, 95
master - mean (93ms) : 91, 96
section Bailout
This PR (8014) - mean (94ms) : 93, 96
master - mean (94ms) : 93, 96
section CallTarget+Inlining+NGEN
This PR (8014) - mean (708ms) : 661, 754
master - mean (709ms) : 675, 744
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8014) - mean (92ms) : 90, 95
master - mean (92ms) : 90, 94
section Bailout
This PR (8014) - mean (93ms) : 92, 95
master - mean (93ms) : 92, 94
section CallTarget+Inlining+NGEN
This PR (8014) - mean (634ms) : 618, 651
master - mean (632ms) : 618, 646
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8014) - mean (194ms) : 191, 197
master - mean (193ms) : 190, 197
section Bailout
This PR (8014) - mean (197ms) : 194, 200
master - mean (197ms) : 195, 199
section CallTarget+Inlining+NGEN
This PR (8014) - mean (1,115ms) : 1073, 1157
master - mean (1,119ms) : 1057, 1180
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8014) - mean (276ms) : 272, 281
master - mean (276ms) : 270, 282
section Bailout
This PR (8014) - mean (278ms) : 274, 283
master - mean (278ms) : 272, 283
section CallTarget+Inlining+NGEN
This PR (8014) - mean (922ms) : 879, 965
master - mean (928ms) : 885, 972
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8014) - mean (270ms) : 265, 276
master - mean (271ms) : 265, 277
section Bailout
This PR (8014) - mean (271ms) : 267, 274
master - mean (270ms) : 267, 274
section CallTarget+Inlining+NGEN
This PR (8014) - mean (924ms) : 881, 966
master - mean (918ms) : 869, 967
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8014) - mean (270ms) : 265, 276
master - mean (270ms) : 265, 275
section Bailout
This PR (8014) - mean (270ms) : 266, 273
master - mean (269ms) : 265, 273
section CallTarget+Inlining+NGEN
This PR (8014) - mean (824ms) : 804, 844
master - mean (825ms) : 809, 842
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-01-07 11:34:41 Comparing candidate commit 8f877ab in PR branch Found 5 performance improvements and 5 performance regressions! Performance is the same for 164 metrics, 12 unstable metrics. scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery net472
scenario:Benchmarks.Trace.RedisBenchmark.SendReceive netcoreapp3.1
scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope net6.0
|
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add retry logic with exponential backoff to the
DownloadLibDatadogbuild step for Windows to handle transient network failures when vcpkg downloads dependencies from GitHub.Reason for change
CI builds occasionally fail with 504 Gateway Timeout errors when vcpkg attempts to download tools like
7zr.exefrom GitHub during theDownloadLibDatadogstep. These transient failures cause unnecessary build failures.Example error from CI:
error: https://github.com/ip7z/7zip/releases/download/25.01/7zr.exe: failed: status code 504Implementation details
DownloadWafVersionretry implementationTest coverage
Existing CI tests will validate the change. The retry mechanism only activates on failures, so successful builds are unaffected.
Other details