Skip to content

Flaky tests: Tracer#8001

Merged
NachoEchevarria merged 1 commit intomasterfrom
nacho/FlakyTracerTests
Dec 23, 2025
Merged

Flaky tests: Tracer#8001
NachoEchevarria merged 1 commit intomasterfrom
nacho/FlakyTracerTests

Conversation

@NachoEchevarria
Copy link
Collaborator

@NachoEchevarria NachoEchevarria commented Dec 23, 2025 •
edited
Loading

Summary of changes

The following tests we detected as flaky:

Datadog.Trace.Tests.Logging.DirectSubmission.Sink.DatadogSinkTests.SinkSendsMessagesToLogsApi (3 failures in different pipelines the last month)
Datadog.Trace.Tests.Logging.DirectSubmission.Sink.OtlpSinkTests.SinkBatchesMultipleLogs (3 failures in different pipelines the last month)
Datadog.Trace.Tests.Logging.DirectSubmission.Sink.DatadogSinkTests.SinkRejectsGiantMessages (5 failures in different pipelines the last month)

The complete flakiness report can be found here:
https://docs.google.com/spreadsheets/d/1Gftmhb-66Dag4qFEXw9tyXp7U0fOQsdCE2gI-1voWyA/edit?gid=1708590243#gid=1708590243

The affected tests have been marked as flaky by using the flaky decorator.

Reason for change

Implementation details

Test coverage

Other details

@github-actions github-actions bot added the area:tests unit tests, integration tests label Dec 23, 2025
@NachoEchevarria NachoEchevarria changed the title Mark as flaky affected tracer tests Flaky tests: Tracer Dec 23, 2025
@pr-commenter
Copy link

pr-commenter bot commented Dec 23, 2025

Benchmarks

Benchmark execution time: 2025-12-23 12:03:36

Comparing candidate commit 1b8d1a7 in PR branch nacho/FlakyTracerTests with baseline commit 017ba0f in branch master.

Found 9 performance improvements and 2 performance regressions! Performance is the same for 159 metrics, 16 unstable metrics.

scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1

  • 🟥 execution_time [+9.979ms; +15.577ms] or [+5.139%; +8.022%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0

  • 🟩 execution_time [-22.337ms; -16.129ms] or [-10.290%; -7.430%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟩 execution_time [-25.004ms; -18.545ms] or [-11.606%; -8.608%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • 🟩 execution_time [-11.690ms; -9.474ms] or [-11.954%; -9.687%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 throughput [+127.000op/s; +277.457op/s] or [+6.351%; +13.874%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472

  • 🟥 execution_time [+10.232ms; +10.465ms] or [+5.362%; +5.484%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

  • 🟩 execution_time [-36.598ms; -34.822ms] or [-18.122%; -17.242%]

scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net6.0

  • 🟩 execution_time [-17.301ms; -11.951ms] or [-8.101%; -5.596%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0

  • 🟩 execution_time [-20.019ms; -19.137ms] or [-9.149%; -8.746%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟩 execution_time [-16.285ms; -12.503ms] or [-7.604%; -5.838%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟩 execution_time [-18.761ms; -13.246ms] or [-8.860%; -6.256%]

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Dec 23, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8001) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration68.29 ± (68.30 - 68.55) ms68.61 ± (68.63 - 68.83) ms+0.5%✅⬆️
.NET Framework 4.8 - Bailout
duration72.15 ± (72.01 - 72.25) ms72.05 ± (71.96 - 72.15) ms-0.1%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1000.20 ± (1004.21 - 1012.29) ms1006.58 ± (1017.76 - 1029.12) ms+0.6%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms21.91 ± (21.88 - 21.94) ms22.03 ± (21.99 - 22.06) ms+0.5%✅⬆️
process.time_to_main_ms78.44 ± (78.30 - 78.58) ms78.65 ± (78.51 - 78.80) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.91 ± (10.90 - 10.91) MB10.94 ± (10.93 - 10.95) MB+0.3%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms21.84 ± (21.82 - 21.87) ms21.83 ± (21.81 - 21.85) ms-0.1%✅
process.time_to_main_ms79.76 ± (79.67 - 79.85) ms79.72 ± (79.64 - 79.80) ms-0.0%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.94 ± (10.93 - 10.94) MB10.96 ± (10.96 - 10.96) MB+0.2%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms207.58 ± (206.18 - 208.98) ms211.44 ± (210.07 - 212.81) ms+1.9%✅⬆️
process.time_to_main_ms471.07 ± (470.46 - 471.67) ms472.54 ± (471.95 - 473.13) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.09 ± (48.07 - 48.12) MB48.14 ± (48.12 - 48.15) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅
.NET 6 - Baseline
process.internal_duration_ms20.85 ± (20.81 - 20.89) ms20.62 ± (20.59 - 20.64) ms-1.1%✅
process.time_to_main_ms68.23 ± (68.10 - 68.36) ms67.99 ± (67.88 - 68.10) ms-0.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.60 ± (10.60 - 10.61) MB10.63 ± (10.62 - 10.63) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms20.66 ± (20.63 - 20.69) ms20.50 ± (20.48 - 20.53) ms-0.7%✅
process.time_to_main_ms68.85 ± (68.81 - 68.89) ms68.72 ± (68.67 - 68.76) ms-0.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.66 ± (10.65 - 10.66) MB10.66 ± (10.66 - 10.67) MB+0.0%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms200.86 ± (199.65 - 202.07) ms200.43 ± (199.34 - 201.52) ms-0.2%✅
process.time_to_main_ms439.93 ± (439.44 - 440.41) ms439.96 ± (439.38 - 440.53) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.29 ± (48.23 - 48.35) MB48.27 ± (48.20 - 48.33) MB-0.0%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms18.84 ± (18.81 - 18.86) ms18.91 ± (18.89 - 18.94) ms+0.4%✅⬆️
process.time_to_main_ms66.93 ± (66.83 - 67.03) ms67.20 ± (67.10 - 67.30) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.67 ± (7.66 - 7.67) MB7.68 ± (7.68 - 7.69) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms18.78 ± (18.76 - 18.80) ms18.86 ± (18.84 - 18.89) ms+0.4%✅⬆️
process.time_to_main_ms68.05 ± (67.99 - 68.10) ms68.12 ± (68.06 - 68.19) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.71 ± (7.71 - 7.72) MB7.72 ± (7.71 - 7.72) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms177.99 ± (177.15 - 178.83) ms179.20 ± (178.19 - 180.20) ms+0.7%✅⬆️
process.time_to_main_ms422.62 ± (422.04 - 423.20) ms425.59 ± (425.00 - 426.19) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.28 ± (36.25 - 36.32) MB36.31 ± (36.28 - 36.34) MB+0.1%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.1%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration193.60 ± (193.69 - 194.48) ms193.25 ± (192.96 - 193.68) ms-0.2%✅
.NET Framework 4.8 - Bailout
duration196.70 ± (196.63 - 197.22) ms196.86 ± (196.77 - 197.20) ms+0.1%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1106.34 ± (1110.70 - 1119.22) ms1116.46 ± (1124.05 - 1135.23) ms+0.9%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms187.99 ± (187.63 - 188.35) ms187.38 ± (187.03 - 187.72) ms-0.3%✅
process.time_to_main_ms80.45 ± (80.26 - 80.64) ms80.63 ± (80.44 - 80.83) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.08 ± (16.05 - 16.11) MB16.09 ± (16.06 - 16.12) MB+0.1%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (19 - 20)-0.5%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms186.56 ± (186.25 - 186.86) ms187.32 ± (186.95 - 187.69) ms+0.4%✅⬆️
process.time_to_main_ms81.70 ± (81.58 - 81.82) ms81.86 ± (81.73 - 82.00) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.19 ± (16.16 - 16.22) MB16.19 ± (16.16 - 16.22) MB+0.0%✅⬆️
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (21 - 21)+0.4%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms396.85 ± (394.45 - 399.26) ms396.60 ± (393.89 - 399.30) ms-0.1%✅
process.time_to_main_ms473.16 ± (472.64 - 473.67) ms475.05 ± (474.31 - 475.79) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.59 ± (58.45 - 58.73) MB58.61 ± (58.46 - 58.76) MB+0.0%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 30)29 ± (29 - 29)-0.1%✅
.NET 6 - Baseline
process.internal_duration_ms192.75 ± (192.33 - 193.16) ms192.53 ± (192.19 - 192.87) ms-0.1%✅
process.time_to_main_ms69.91 ± (69.75 - 70.07) ms70.13 ± (69.93 - 70.34) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.13 ± (16.01 - 16.25) MB16.05 ± (15.90 - 16.20) MB-0.5%✅
runtime.dotnet.threads.count18 ± (18 - 19)18 ± (18 - 18)-1.1%✅
.NET 6 - Bailout
process.internal_duration_ms191.29 ± (191.04 - 191.54) ms191.42 ± (191.12 - 191.72) ms+0.1%✅⬆️
process.time_to_main_ms70.75 ± (70.66 - 70.84) ms70.72 ± (70.62 - 70.82) ms-0.0%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.06 ± (15.91 - 16.22) MB16.19 ± (16.06 - 16.31) MB+0.8%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)20 ± (19 - 20)+2.9%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms410.74 ± (408.61 - 412.87) ms411.56 ± (408.98 - 414.14) ms+0.2%✅⬆️
process.time_to_main_ms444.61 ± (444.06 - 445.15) ms445.38 ± (444.79 - 445.97) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed59.28 ± (59.16 - 59.40) MB59.01 ± (58.87 - 59.15) MB-0.5%✅
runtime.dotnet.threads.count30 ± (30 - 30)29 ± (29 - 30)-0.3%✅
.NET 8 - Baseline
process.internal_duration_ms191.01 ± (190.59 - 191.43) ms190.04 ± (189.64 - 190.45) ms-0.5%✅
process.time_to_main_ms69.65 ± (69.45 - 69.84) ms69.55 ± (69.35 - 69.75) ms-0.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.72 ± (11.69 - 11.74) MB11.80 ± (11.77 - 11.83) MB+0.7%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)+0.1%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms190.96 ± (190.53 - 191.40) ms189.63 ± (189.28 - 189.98) ms-0.7%✅
process.time_to_main_ms70.98 ± (70.82 - 71.13) ms70.41 ± (70.33 - 70.50) ms-0.8%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.77 ± (11.75 - 11.80) MB11.79 ± (11.76 - 11.82) MB+0.2%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.1%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms367.17 ± (365.42 - 368.93) ms364.87 ± (363.25 - 366.50) ms-0.6%✅
process.time_to_main_ms429.01 ± (428.36 - 429.66) ms428.15 ± (427.45 - 428.85) ms-0.2%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed47.92 ± (47.90 - 47.95) MB48.02 ± (47.99 - 48.06) MB+0.2%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.1%✅
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8001) - mean (69ms)  : 67, 70
    master - mean (68ms)  : 67, 70

    section Bailout
    This PR (8001) - mean (72ms)  : 71, 73
    master - mean (72ms)  : 71, 73

    section CallTarget+Inlining+NGEN
    This PR (8001) - mean (1,023ms)  : 935, 1112
    master - mean (1,008ms)  : 951, 1066
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8001) - mean (106ms)  : 104, 108
    master - mean (106ms)  : 103, 108

    section Bailout
    This PR (8001) - mean (107ms)  : 105, 108
    master - mean (107ms)  : 105, 108

    section CallTarget+Inlining+NGEN
    This PR (8001) - mean (712ms)  : 678, 746
    master - mean (705ms)  : 676, 735
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8001) - mean (93ms)  : 91, 96
    master - mean (94ms)  : 92, 96

    section Bailout
    This PR (8001) - mean (94ms)  : 93, 95
    master - mean (94ms)  : 93, 95

    section CallTarget+Inlining+NGEN
    This PR (8001) - mean (668ms)  : 644, 692
    master - mean (669ms)  : 649, 689
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8001) - mean (92ms)  : 90, 94
    master - mean (92ms)  : 90, 94

    section Bailout
    This PR (8001) - mean (93ms)  : 92, 94
    master - mean (93ms)  : 92, 94

    section CallTarget+Inlining+NGEN
    This PR (8001) - mean (632ms)  : 619, 644
    master - mean (628ms)  : 615, 641
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8001) - mean (193ms)  : 190, 197
    master - mean (194ms)  : 190, 199

    section Bailout
    This PR (8001) - mean (197ms)  : 195, 199
    master - mean (197ms)  : 194, 200

    section CallTarget+Inlining+NGEN
    This PR (8001) - mean (1,130ms)  : 1042, 1217
    master - mean (1,115ms)  : 1052, 1178
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8001) - mean (277ms)  : 271, 282
    master - mean (277ms)  : 272, 282

    section Bailout
    This PR (8001) - mean (278ms)  : 273, 282
    master - mean (277ms)  : 273, 280

    section CallTarget+Inlining+NGEN
    This PR (8001) - mean (911ms)  : 865, 957
    master - mean (907ms)  : 869, 944
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8001) - mean (271ms)  : 266, 276
    master - mean (271ms)  : 265, 277

    section Bailout
    This PR (8001) - mean (270ms)  : 267, 274
    master - mean (270ms)  : 266, 274

    section CallTarget+Inlining+NGEN
    This PR (8001) - mean (891ms)  : 842, 941
    master - mean (888ms)  : 852, 925
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8001) - mean (269ms)  : 264, 275
    master - mean (270ms)  : 265, 275

    section Bailout
    This PR (8001) - mean (270ms)  : 266, 273
    master - mean (271ms)  : 266, 277

    section CallTarget+Inlining+NGEN
    This PR (8001) - mean (825ms)  : 805, 845
    master - mean (826ms)  : 802, 851
Loading

@NachoEchevarria NachoEchevarria marked this pull request as ready for review December 23, 2025 12:50
@NachoEchevarria NachoEchevarria requested a review from a team as a code owner December 23, 2025 12:50
@NachoEchevarria NachoEchevarria merged commit b5d6c80 into master Dec 23, 2025
149 of 151 checks passed
@NachoEchevarria NachoEchevarria deleted the nacho/FlakyTracerTests branch December 23, 2025 17:01
@github-actions github-actions bot added this to the vNext-v3 milestone Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

area:tests unit tests, integration tests type:flake-fix

Projects

None yet

Milestone

3.35.0

Development

Successfully merging this pull request may close these issues.

2 participants

@NachoEchevarria @andrewlock