Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7997) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7997) - mean (69ms) : 67, 70
master - mean (68ms) : 67, 70
section Bailout
This PR (7997) - mean (72ms) : 71, 73
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (7997) - mean (1,010ms) : 945, 1076
master - mean (1,006ms) : 962, 1050
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7997) - mean (106ms) : 102, 109
master - mean (106ms) : 103, 108
section Bailout
This PR (7997) - mean (107ms) : 105, 108
master - mean (107ms) : 105, 108
section CallTarget+Inlining+NGEN
This PR (7997) - mean (710ms) : 683, 737
master - mean (709ms) : 673, 745
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7997) - mean (93ms) : 91, 95
master - mean (93ms) : 91, 95
section Bailout
This PR (7997) - mean (94ms) : 93, 95
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (7997) - mean (664ms) : 640, 687
master - mean (668ms) : 631, 705
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7997) - mean (92ms) : 90, 94
master - mean (92ms) : 89, 95
section Bailout
This PR (7997) - mean (93ms) : 92, 94
master - mean (93ms) : 92, 94
section CallTarget+Inlining+NGEN
This PR (7997) - mean (631ms) : 616, 645
master - mean (631ms) : 614, 648
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7997) - mean (193ms) : 189, 197
master - mean (194ms) : 190, 198
section Bailout
This PR (7997) - mean (197ms) : 194, 199
master - mean (197ms) : 195, 199
section CallTarget+Inlining+NGEN
This PR (7997) - mean (1,112ms) : 1055, 1169
master - mean (1,114ms) : 1069, 1159
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7997) - mean (277ms) : 272, 282
master - mean (276ms) : 272, 280
section Bailout
This PR (7997) - mean (277ms) : 274, 281
master - mean (277ms) : 273, 280
section CallTarget+Inlining+NGEN
This PR (7997) - mean (903ms) : 862, 945
master - mean (907ms) : 848, 966
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7997) - mean (271ms) : 266, 275
master - mean (270ms) : 265, 274
section Bailout
This PR (7997) - mean (270ms) : 266, 274
master - mean (269ms) : 266, 272
section CallTarget+Inlining+NGEN
This PR (7997) - mean (893ms) : 848, 937
master - mean (881ms) : 839, 923
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7997) - mean (269ms) : 264, 274
master - mean (268ms) : 264, 273
section Bailout
This PR (7997) - mean (269ms) : 266, 272
master - mean (269ms) : 266, 272
section CallTarget+Inlining+NGEN
This PR (7997) - mean (825ms) : 798, 853
master - mean (823ms) : 804, 843
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2025-12-23 10:27:34 Comparing candidate commit 26e43c3 in PR branch Found 9 performance improvements and 2 performance regressions! Performance is the same for 162 metrics, 13 unstable metrics. scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0
scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery netcoreapp3.1
scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1
|
Summary of changes
Run smoke tests against arm64 macOS images
Reason for change
We have a blindspot for macOS testing on arm64, and Azure DevOps recently added preview runners, so we should try to use them.
Implementation details
Currently, AzDo says
So I just added a single instance, to try to avoid the risk of overloading and flake. We only run these on master by default too, so should hopefully be ok.
Test coverage
Will run a "full installer test" so that these tests trigger
Other details
Fixed a typo in the macos14 .NET 10 entry too