[SymDB] DEBUG-4881 Fix type name in TypeProvider#7990
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7990) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7990) - mean (69ms) : 67, 70
master - mean (68ms) : 67, 70
section Bailout
This PR (7990) - mean (72ms) : 71, 73
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (7990) - mean (1,007ms) : 959, 1056
master - mean (1,007ms) : 967, 1047
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7990) - mean (106ms) : 103, 109
master - mean (106ms) : 103, 108
section Bailout
This PR (7990) - mean (107ms) : 105, 108
master - mean (107ms) : 106, 108
section CallTarget+Inlining+NGEN
This PR (7990) - mean (736ms) : 667, 804
master - mean (735ms) : 672, 799
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7990) - mean (94ms) : 92, 95
master - mean (94ms) : 92, 96
section Bailout
This PR (7990) - mean (94ms) : 93, 95
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (7990) - mean (711ms) : 685, 736
master - mean (709ms) : 672, 747
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7990) - mean (92ms) : 90, 94
master - mean (92ms) : 90, 94
section Bailout
This PR (7990) - mean (93ms) : 92, 95
master - mean (93ms) : 92, 95
section CallTarget+Inlining+NGEN
This PR (7990) - mean (633ms) : 616, 650
master - mean (633ms) : 616, 650
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7990) - mean (193ms) : 189, 197
master - mean (193ms) : 189, 197
section Bailout
This PR (7990) - mean (196ms) : 194, 199
master - mean (197ms) : 192, 201
section CallTarget+Inlining+NGEN
This PR (7990) - mean (1,127ms) : 1050, 1205
master - mean (1,113ms) : 1058, 1169
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7990) - mean (277ms) : 270, 284
master - mean (277ms) : 271, 282
section Bailout
This PR (7990) - mean (277ms) : 273, 282
master - mean (276ms) : 273, 279
section CallTarget+Inlining+NGEN
This PR (7990) - mean (923ms) : 863, 982
master - mean (922ms) : 871, 974
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7990) - mean (269ms) : 264, 274
master - mean (270ms) : 265, 275
section Bailout
This PR (7990) - mean (269ms) : 266, 272
master - mean (269ms) : 264, 274
section CallTarget+Inlining+NGEN
This PR (7990) - mean (919ms) : 876, 963
master - mean (923ms) : 874, 972
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7990) - mean (270ms) : 264, 275
master - mean (269ms) : 264, 274
section Bailout
This PR (7990) - mean (269ms) : 266, 271
master - mean (269ms) : 265, 272
section CallTarget+Inlining+NGEN
This PR (7990) - mean (822ms) : 804, 841
master - mean (822ms) : 800, 845
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-01-15 18:30:51 Comparing candidate commit 4529020 in PR branch Found 9 performance improvements and 13 performance regressions! Performance is the same for 158 metrics, 12 unstable metrics. scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net472
scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0
scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.RedisBenchmark.SendReceive net472
scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0
scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1
scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1
|
21e9e23 to
8d824cc
Compare
0be0c2e to
4529020
Compare
Summary of changes
Change type name for boolean on our TypePreovider
Test coverage
All current integration tests + exploration tests
Other details
This PR is part of an effort to make the Snapshot Exploration Test run successfully end-to-end.