Skip to content

Downgrade DSM flush shutdown log from Error to Warning#7984

Merged
andrewlock merged 1 commit intomasterfrom
rob.carlan/downgrade-dsm-flush-error
Dec 19, 2025
Merged

Downgrade DSM flush shutdown log from Error to Warning#7984
andrewlock merged 1 commit intomasterfrom
rob.carlan/downgrade-dsm-flush-error

Conversation

@robcarlan-datadog
Copy link
Contributor

@robcarlan-datadog robcarlan-datadog commented Dec 19, 2025

Summary of changes

Addressing some test flake. This can happen in an overloaded CI environment.

Reason for change

Implementation details

Test coverage

Other details

@robcarlan-datadog robcarlan-datadog requested review from a team as code owners December 19, 2025 19:17
@github-actions github-actions bot added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:data-streams-monitoring labels Dec 19, 2025
andrewlock
andrewlock approved these changes Dec 19, 2025
View reviewed changes
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewlock andrewlock enabled auto-merge (squash) December 19, 2025 19:36
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Dec 19, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7984) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration68.24 ± (68.22 - 68.52) ms68.49 ± (68.43 - 68.70) ms+0.4%✅⬆️
.NET Framework 4.8 - Bailout
duration72.06 ± (71.95 - 72.17) ms72.32 ± (72.24 - 72.48) ms+0.4%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1004.50 ± (1003.46 - 1008.79) ms1004.77 ± (1005.37 - 1011.68) ms+0.0%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms21.91 ± (21.87 - 21.94) ms22.07 ± (22.03 - 22.10) ms+0.7%✅⬆️
process.time_to_main_ms78.62 ± (78.49 - 78.75) ms78.57 ± (78.44 - 78.71) ms-0.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.94 ± (10.94 - 10.95) MB10.92 ± (10.92 - 10.93) MB-0.2%✅
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms21.78 ± (21.75 - 21.81) ms21.90 ± (21.88 - 21.92) ms+0.6%✅⬆️
process.time_to_main_ms79.86 ± (79.77 - 79.96) ms79.74 ± (79.65 - 79.83) ms-0.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.96 ± (10.95 - 10.96) MB10.94 ± (10.94 - 10.95) MB-0.1%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms212.79 ± (210.56 - 215.02) ms210.52 ± (209.19 - 211.85) ms-1.1%✅
process.time_to_main_ms472.07 ± (471.56 - 472.58) ms473.15 ± (472.54 - 473.75) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.05 ± (48.03 - 48.07) MB48.10 ± (48.08 - 48.12) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅
.NET 6 - Baseline
process.internal_duration_ms20.73 ± (20.70 - 20.76) ms20.75 ± (20.71 - 20.79) ms+0.1%✅⬆️
process.time_to_main_ms68.31 ± (68.19 - 68.42) ms68.31 ± (68.18 - 68.44) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.61 ± (10.60 - 10.61) MB10.62 ± (10.62 - 10.62) MB+0.1%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms20.57 ± (20.54 - 20.60) ms20.58 ± (20.56 - 20.59) ms+0.0%✅⬆️
process.time_to_main_ms69.00 ± (68.93 - 69.07) ms69.05 ± (68.97 - 69.12) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.65 ± (10.65 - 10.66) MB10.67 ± (10.66 - 10.67) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms199.93 ± (198.97 - 200.89) ms200.83 ± (199.62 - 202.03) ms+0.4%✅⬆️
process.time_to_main_ms439.18 ± (438.69 - 439.67) ms440.85 ± (440.18 - 441.53) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.46 ± (48.41 - 48.51) MB48.18 ± (48.10 - 48.26) MB-0.6%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.1%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms18.81 ± (18.78 - 18.84) ms18.82 ± (18.79 - 18.84) ms+0.0%✅⬆️
process.time_to_main_ms67.14 ± (67.03 - 67.25) ms67.08 ± (66.98 - 67.18) ms-0.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.69 ± (7.68 - 7.70) MB7.66 ± (7.66 - 7.67) MB-0.3%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms18.76 ± (18.74 - 18.79) ms18.77 ± (18.75 - 18.80) ms+0.1%✅⬆️
process.time_to_main_ms67.98 ± (67.92 - 68.05) ms68.24 ± (68.19 - 68.29) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.71 ± (7.70 - 7.71) MB7.72 ± (7.72 - 7.73) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms179.22 ± (178.33 - 180.11) ms178.92 ± (178.05 - 179.79) ms-0.2%✅
process.time_to_main_ms424.06 ± (423.44 - 424.68) ms425.41 ± (424.80 - 426.02) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.22 ± (36.19 - 36.26) MB36.21 ± (36.18 - 36.24) MB-0.0%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.2%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration193.63 ± (193.67 - 194.58) ms194.79 ± (194.86 - 195.72) ms+0.6%✅⬆️
.NET Framework 4.8 - Bailout
duration196.83 ± (196.81 - 197.46) ms199.81 ± (199.87 - 200.75) ms+1.5%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1110.81 ± (1113.29 - 1120.74) ms1134.22 ± (1135.41 - 1146.30) ms+2.1%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms188.64 ± (188.22 - 189.05) ms189.88 ± (189.49 - 190.27) ms+0.7%✅⬆️
process.time_to_main_ms81.10 ± (80.86 - 81.34) ms81.27 ± (81.07 - 81.47) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.10 ± (16.07 - 16.12) MB16.02 ± (16.01 - 16.04) MB-0.4%✅
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-0.8%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms187.59 ± (187.30 - 187.88) ms189.94 ± (189.51 - 190.38) ms+1.3%✅⬆️
process.time_to_main_ms82.08 ± (81.93 - 82.24) ms82.91 ± (82.71 - 83.11) ms+1.0%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.11 ± (16.09 - 16.14) MB16.08 ± (16.06 - 16.10) MB-0.2%✅
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (21 - 21)+0.3%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms395.02 ± (392.66 - 397.38) ms401.68 ± (398.90 - 404.46) ms+1.7%✅⬆️
process.time_to_main_ms475.17 ± (474.45 - 475.89) ms477.53 ± (476.78 - 478.28) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.51 ± (58.36 - 58.66) MB58.89 ± (58.78 - 59.01) MB+0.7%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)30 ± (29 - 30)+0.2%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms192.69 ± (192.30 - 193.08) ms193.14 ± (192.69 - 193.58) ms+0.2%✅⬆️
process.time_to_main_ms70.17 ± (70.00 - 70.35) ms70.28 ± (70.11 - 70.45) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.04 ± (15.90 - 16.18) MB16.32 ± (16.30 - 16.35) MB+1.8%✅⬆️
runtime.dotnet.threads.count19 ± (18 - 19)19 ± (19 - 19)+1.8%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms191.54 ± (191.26 - 191.81) ms192.18 ± (191.87 - 192.48) ms+0.3%✅⬆️
process.time_to_main_ms70.92 ± (70.80 - 71.03) ms71.11 ± (71.01 - 71.20) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.05 ± (15.89 - 16.21) MB16.43 ± (16.39 - 16.47) MB+2.4%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)20 ± (20 - 20)+4.8%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms407.50 ± (405.48 - 409.52) ms406.41 ± (404.34 - 408.48) ms-0.3%✅
process.time_to_main_ms445.84 ± (445.25 - 446.44) ms446.96 ± (446.31 - 447.61) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed58.97 ± (58.83 - 59.12) MB58.84 ± (58.69 - 58.99) MB-0.2%✅
runtime.dotnet.threads.count30 ± (29 - 30)30 ± (30 - 30)+0.0%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms191.03 ± (190.64 - 191.41) ms191.40 ± (190.95 - 191.86) ms+0.2%✅⬆️
process.time_to_main_ms70.14 ± (69.92 - 70.35) ms70.10 ± (69.94 - 70.26) ms-0.0%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.69 ± (11.66 - 11.71) MB11.69 ± (11.66 - 11.72) MB+0.0%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)+0.2%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms190.15 ± (189.87 - 190.43) ms189.67 ± (189.37 - 189.97) ms-0.3%✅
process.time_to_main_ms70.76 ± (70.64 - 70.89) ms70.47 ± (70.39 - 70.56) ms-0.4%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.79 ± (11.76 - 11.82) MB11.78 ± (11.74 - 11.82) MB-0.1%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.1%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms365.92 ± (364.30 - 367.54) ms368.85 ± (367.60 - 370.09) ms+0.8%✅⬆️
process.time_to_main_ms428.91 ± (428.12 - 429.70) ms430.10 ± (429.48 - 430.73) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed47.90 ± (47.86 - 47.93) MB47.96 ± (47.93 - 47.98) MB+0.1%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.1%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7984) - mean (69ms)  : 67, 70
    master - mean (68ms)  : 66, 70

    section Bailout
    This PR (7984) - mean (72ms)  : 71, 73
    master - mean (72ms)  : 71, 73

    section CallTarget+Inlining+NGEN
    This PR (7984) - mean (1,009ms)  : 970, 1047
    master - mean (1,006ms)  : 968, 1044
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7984) - mean (106ms)  : 104, 108
    master - mean (106ms)  : 103, 108

    section Bailout
    This PR (7984) - mean (107ms)  : 106, 108
    master - mean (107ms)  : 105, 108

    section CallTarget+Inlining+NGEN
    This PR (7984) - mean (710ms)  : 683, 737
    master - mean (712ms)  : 678, 746
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7984) - mean (94ms)  : 92, 96
    master - mean (94ms)  : 92, 96

    section Bailout
    This PR (7984) - mean (94ms)  : 93, 96
    master - mean (94ms)  : 93, 95

    section CallTarget+Inlining+NGEN
    This PR (7984) - mean (669ms)  : 650, 687
    master - mean (667ms)  : 643, 690
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7984) - mean (92ms)  : 90, 94
    master - mean (92ms)  : 90, 94

    section Bailout
    This PR (7984) - mean (93ms)  : 92, 94
    master - mean (93ms)  : 92, 94

    section CallTarget+Inlining+NGEN
    This PR (7984) - mean (633ms)  : 617, 649
    master - mean (630ms)  : 614, 646
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7984) - mean (195ms)  : 190, 200
    master - mean (194ms)  : 190, 199

    section Bailout
    This PR (7984) - mean (200ms)  : 194, 207
    master - mean (197ms)  : 194, 200

    section CallTarget+Inlining+NGEN
    This PR (7984) - mean (1,141ms)  : 1056, 1226
    master - mean (1,117ms)  : 1064, 1170
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7984) - mean (280ms)  : 271, 288
    master - mean (278ms)  : 272, 284

    section Bailout
    This PR (7984) - mean (281ms)  : 273, 289
    master - mean (278ms)  : 274, 282

    section CallTarget+Inlining+NGEN
    This PR (7984) - mean (914ms)  : 863, 965
    master - mean (909ms)  : 867, 950
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7984) - mean (272ms)  : 266, 278
    master - mean (271ms)  : 266, 277

    section Bailout
    This PR (7984) - mean (271ms)  : 267, 275
    master - mean (270ms)  : 267, 274

    section CallTarget+Inlining+NGEN
    This PR (7984) - mean (889ms)  : 842, 935
    master - mean (888ms)  : 847, 929
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7984) - mean (271ms)  : 264, 278
    master - mean (271ms)  : 265, 277

    section Bailout
    This PR (7984) - mean (270ms)  : 266, 273
    master - mean (270ms)  : 267, 274

    section CallTarget+Inlining+NGEN
    This PR (7984) - mean (830ms)  : 805, 854
    master - mean (825ms)  : 808, 842
Loading

@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2025

Benchmarks

Benchmark execution time: 2025-12-19 20:16:12

Comparing candidate commit e97545b in PR branch rob.carlan/downgrade-dsm-flush-error with baseline commit 36ac459 in branch master.

Found 7 performance improvements and 4 performance regressions! Performance is the same for 163 metrics, 12 unstable metrics.

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟥 execution_time [+12.029ms; +18.375ms] or [+6.088%; +9.299%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472

  • 🟥 execution_time [+21.347ms; +25.870ms] or [+10.570%; +12.809%]
  • 🟥 throughput [-134.981op/s; -113.272op/s] or [-11.358%; -9.531%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

  • 🟩 execution_time [-37.615ms; -30.034ms] or [-19.976%; -15.950%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472

  • 🟩 execution_time [-143.665µs; -139.428µs] or [-6.839%; -6.638%]
  • 🟩 throughput [+33.898op/s; +34.894op/s] or [+7.121%; +7.330%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

  • 🟩 execution_time [-96.627µs; -93.066µs] or [-6.437%; -6.200%]
  • 🟩 throughput [+44.085op/s; +45.777op/s] or [+6.618%; +6.872%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟩 execution_time [-902.441µs; -853.135µs] or [-66.266%; -62.646%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1

  • 🟥 execution_time [+72.132ms; +74.836ms] or [+57.628%; +59.788%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟩 execution_time [-17.356ms; -13.434ms] or [-8.200%; -6.347%]

@andrewlock andrewlock merged commit b1bc5a1 into master Dec 19, 2025
151 checks passed
@andrewlock andrewlock deleted the rob.carlan/downgrade-dsm-flush-error branch December 19, 2025 20:33
@github-actions github-actions bot added this to the vNext-v3 milestone Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bouwkast bouwkast bouwkast approved these changes

@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

area:data-streams-monitoring area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) type:flake-fix

Projects

None yet

Milestone

3.34.0

Development

Successfully merging this pull request may close these issues.

3 participants

@robcarlan-datadog @bouwkast @andrewlock