Extend the DD_TRACE_ENABLED to manual instrumentation#796
Merged
lucaspimentel merged 4 commits intomasterfrom Jul 21, 2020
Merged
Extend the DD_TRACE_ENABLED to manual instrumentation#796lucaspimentel merged 4 commits intomasterfrom
lucaspimentel merged 4 commits intomasterfrom
Conversation
lucaspimentel
approved these changes
Jul 13, 2020
Member
lucaspimentel
left a comment
There was a problem hiding this comment.
Well, that was much easier than I expected.
zacharycmontoya
requested changes
Jul 14, 2020
Contributor
zacharycmontoya
left a comment
There was a problem hiding this comment.
Looks good! Can you also add a unit test for this behavior?
zacharycmontoya
approved these changes
Jul 15, 2020
lucaspimentel
requested changes
Jul 15, 2020
Member
lucaspimentel
left a comment
There was a problem hiding this comment.
See comments about using environment variables in tests.
lucaspimentel
approved these changes
Jul 17, 2020
# Conflicts: # test/Datadog.Trace.Tests/TracerSettingsTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DD_TRACE_ENABLED was only disabling automatic instrumentation. Extend it to manual instrumentation.