[Iast] Fix GetModuleInfo freezes#7947
Merged
daniel-romano-DD merged 3 commits intomasterfrom Jan 14, 2026
Merged
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7947) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7947) - mean (68ms) : 67, 70
master - mean (68ms) : 67, 70
section Bailout
This PR (7947) - mean (72ms) : 71, 73
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (7947) - mean (1,007ms) : 968, 1046
master - mean (1,008ms) : 971, 1045
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7947) - mean (106ms) : 104, 108
master - mean (106ms) : 103, 108
section Bailout
This PR (7947) - mean (107ms) : 105, 108
master - mean (107ms) : 105, 108
section CallTarget+Inlining+NGEN
This PR (7947) - mean (733ms) : 676, 790
master - mean (732ms) : 664, 799
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7947) - mean (93ms) : 91, 95
master - mean (94ms) : 92, 96
section Bailout
This PR (7947) - mean (94ms) : 93, 95
master - mean (94ms) : 94, 95
section CallTarget+Inlining+NGEN
This PR (7947) - mean (711ms) : 676, 746
master - mean (716ms) : 697, 735
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7947) - mean (92ms) : 89, 95
master - mean (92ms) : 90, 94
section Bailout
This PR (7947) - mean (93ms) : 91, 95
master - mean (93ms) : 92, 95
section CallTarget+Inlining+NGEN
This PR (7947) - mean (634ms) : 621, 648
master - mean (636ms) : 615, 658
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7947) - mean (193ms) : 189, 197
master - mean (193ms) : 189, 197
section Bailout
This PR (7947) - mean (199ms) : 192, 206
master - mean (196ms) : 193, 198
section CallTarget+Inlining+NGEN
This PR (7947) - mean (1,111ms) : 1062, 1161
master - mean (1,114ms) : 1052, 1176
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7947) - mean (276ms) : 270, 282
master - mean (275ms) : 271, 280
section Bailout
This PR (7947) - mean (277ms) : 272, 281
master - mean (277ms) : 272, 282
section CallTarget+Inlining+NGEN
This PR (7947) - mean (929ms) : 889, 969
master - mean (919ms) : 857, 980
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7947) - mean (269ms) : 262, 277
master - mean (269ms) : 264, 275
section Bailout
This PR (7947) - mean (269ms) : 266, 271
master - mean (269ms) : 266, 273
section CallTarget+Inlining+NGEN
This PR (7947) - mean (924ms) : 878, 971
master - mean (922ms) : 877, 966
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7947) - mean (268ms) : 264, 272
master - mean (269ms) : 264, 274
section Bailout
This PR (7947) - mean (269ms) : 263, 275
master - mean (268ms) : 264, 272
section CallTarget+Inlining+NGEN
This PR (7947) - mean (825ms) : 800, 850
master - mean (822ms) : 802, 841
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-01-13 11:13:15 Comparing candidate commit b0ba046 in PR branch Found 11 performance improvements and 12 performance regressions! Performance is the same for 152 metrics, 11 unstable metrics. scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net472
scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild net6.0
scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1
scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest netcoreapp3.1
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472
scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync netcoreapp3.1
scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1
|
|
da3ca06 to
50cb63a
Compare
Load all preloaded modules at dataflow init
50cb63a to
d52c4f1
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d52c4f1beb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tonyredondo
approved these changes
Jan 13, 2026
| } | ||
|
|
||
| // Retrieve module information if not found | ||
| const int pathLen = 2048; |
Member
There was a problem hiding this comment.
why the change on the length? you had 300 before.
Contributor
Author
There was a problem hiding this comment.
Just to erase the shadow of a buffer overrun
e-n-0
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Move all GetModuleInfo calls to the
ModuleLoadeFinishedprofiler event.Reason for change
Some freezes could happen in Linux
Implementation details
Calling GetAssemblyInfo outside of the Module and Assembly events may corrupt the process
Test coverage
Other details