Skip to content

[AAS] Set DataPipelineEnabled=0 by default#7943

Merged
lucaspimentel merged 1 commit intomasterfrom
andrew/disable-trace-exporter
Dec 10, 2025
Merged

[AAS] Set DataPipelineEnabled=0 by default#7943
lucaspimentel merged 1 commit intomasterfrom
andrew/disable-trace-exporter

Conversation

@andrewlock
Copy link
Member

Summary of changes

Disables the data pipeline by default

Reason for change

We noticed a potential issue in the settings-update path for data pipelines, that could cause problems if a trace exporter instance is disposed while a request is in flight. Working around the issue requires either a bunch of extra locks (undesirable) or more extensive rework. Rather than risk causing a crash, this PR disables the datapipeline by default temporarily.

Implementation details

Default to false instead of just AAS

Test coverage

Covered by existing

@andrewlock andrewlock requested a review from a team as a code owner December 10, 2025 16:49
@andrewlock andrewlock added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) libdatadog Updates to the libdatadog library and Rust integration labels Dec 10, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 10, 2025

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests.WcfTests (Datadog) (Fix with Cursor)

    },} version: 1.0.0et,tests,dd,d,0000/WcfSample/123,123/CalculatorService,WcfInstrumentation=False_enableWcfObfuscation=True.verified.txt

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
* Fix with Cursor requires Datadog plugin ≥v2.17.0
🔗 Commit SHA: d927702 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@lucaspimentel lucaspimentel enabled auto-merge (squash) December 10, 2025 19:21
@lucaspimentel lucaspimentel merged commit 5f62b8c into master Dec 10, 2025
72 of 76 checks passed
@lucaspimentel lucaspimentel deleted the andrew/disable-trace-exporter branch December 10, 2025 19:40
@github-actions github-actions bot added this to the vNext-v3 milestone Dec 10, 2025
@lucaspimentel lucaspimentel changed the title Set DataPipelineEnabled=0 by default [AAS] Set DataPipelineEnabled=0 by default Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:azure-site-extension Changes for AAS support area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) libdatadog Updates to the libdatadog library and Rust integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants