Skip to content

Encode changes to vendored code added in #7884#7913

Merged
andrewlock merged 1 commit intomasterfrom
andrew/update-vendors
Dec 9, 2025
Merged

Encode changes to vendored code added in #7884#7913
andrewlock merged 1 commit intomasterfrom
andrew/update-vendors

Conversation

@andrewlock
Copy link
Member

@andrewlock andrewlock commented Dec 5, 2025

Summary of changes

Encodes changes made manually to vendored code in #7884

Reason for change

In #7884, we manually fixed some problematic code in vendored code. This PR encodes those changes in the vendors tool, ostensibly so that re-running the tool recreates the currently vendored code.

Unfortunately, that's not the case. The code that's been vendored for all of the System. libraries cannot be regenerated using the tool.

Implementation details

Added the transforms, and confirm they work as expected. However, it's a bit moot as we currently can't regenerate the existing code.

Test coverage

Manually tested that the new changes were reproduced, then reverted, because it breaks a bunch of existing vendored code 😅

@andrewlock andrewlock requested a review from a team as a code owner December 5, 2025 14:46
@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Dec 5, 2025
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Dec 5, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7913) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration74.50 ± (74.46 - 75.22) ms74.92 ± (74.71 - 75.46) ms+0.6%✅⬆️
.NET Framework 4.8 - Bailout
duration79.60 ± (79.38 - 80.13) ms79.99 ± (79.77 - 80.47) ms+0.5%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1054.31 ± (1054.25 - 1060.78) ms1055.48 ± (1055.14 - 1061.45) ms+0.1%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.83 ± (22.75 - 22.91) ms22.99 ± (22.91 - 23.07) ms+0.7%✅⬆️
process.time_to_main_ms87.25 ± (86.93 - 87.57) ms87.56 ± (87.20 - 87.93) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.91 ± (10.91 - 10.92) MB10.94 ± (10.94 - 10.95) MB+0.3%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.95 ± (22.89 - 23.02) ms22.90 ± (22.82 - 22.98) ms-0.2%✅
process.time_to_main_ms89.59 ± (89.24 - 89.94) ms89.29 ± (88.93 - 89.65) ms-0.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.95 ± (10.94 - 10.95) MB10.98 ± (10.98 - 10.98) MB+0.3%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms221.83 ± (220.55 - 223.12) ms220.73 ± (219.26 - 222.19) ms-0.5%✅
process.time_to_main_ms500.18 ± (499.07 - 501.29) ms500.61 ± (499.45 - 501.78) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed47.86 ± (47.83 - 47.88) MB48.02 ± (48.00 - 48.04) MB+0.3%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.1%✅
.NET 6 - Baseline
process.internal_duration_ms21.85 ± (21.77 - 21.92) ms21.96 ± (21.88 - 22.04) ms+0.5%✅⬆️
process.time_to_main_ms76.23 ± (75.87 - 76.59) ms77.11 ± (76.74 - 77.48) ms+1.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.60 ± (10.60 - 10.60) MB10.64 ± (10.64 - 10.65) MB+0.4%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.78 ± (21.72 - 21.84) ms21.75 ± (21.69 - 21.81) ms-0.1%✅
process.time_to_main_ms77.95 ± (77.58 - 78.32) ms77.59 ± (77.28 - 77.90) ms-0.5%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.66 ± (10.65 - 10.66) MB10.68 ± (10.68 - 10.68) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms211.27 ± (210.23 - 212.30) ms213.35 ± (212.25 - 214.45) ms+1.0%✅⬆️
process.time_to_main_ms467.10 ± (466.06 - 468.14) ms469.52 ± (468.49 - 470.56) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.04 ± (48.01 - 48.06) MB48.17 ± (48.14 - 48.19) MB+0.3%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms19.83 ± (19.76 - 19.89) ms19.83 ± (19.77 - 19.89) ms+0.0%✅⬆️
process.time_to_main_ms75.01 ± (74.69 - 75.32) ms75.07 ± (74.77 - 75.38) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.66 ± (7.65 - 7.66) MB7.67 ± (7.66 - 7.67) MB+0.1%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.80 ± (19.74 - 19.86) ms19.91 ± (19.85 - 19.97) ms+0.6%✅⬆️
process.time_to_main_ms75.96 ± (75.64 - 76.29) ms77.05 ± (76.75 - 77.36) ms+1.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.71 ± (7.70 - 7.71) MB7.72 ± (7.71 - 7.73) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms192.91 ± (192.02 - 193.80) ms196.07 ± (195.06 - 197.07) ms+1.6%✅⬆️
process.time_to_main_ms455.02 ± (454.02 - 456.02) ms460.44 ± (459.24 - 461.64) ms+1.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.51 ± (36.47 - 36.55) MB36.48 ± (36.44 - 36.53) MB-0.1%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.0%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration193.38 ± (193.03 - 193.76) ms193.20 ± (193.21 - 194.19) ms-0.1%✅
.NET Framework 4.8 - Bailout
duration196.64 ± (196.40 - 196.95) ms197.33 ± (197.26 - 197.82) ms+0.4%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1108.51 ± (1114.09 - 1122.80) ms1121.76 ± (1123.53 - 1133.39) ms+1.2%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms188.08 ± (187.72 - 188.44) ms188.74 ± (188.39 - 189.09) ms+0.4%✅⬆️
process.time_to_main_ms80.62 ± (80.39 - 80.84) ms80.80 ± (80.57 - 81.03) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.08 ± (16.05 - 16.11) MB16.15 ± (16.13 - 16.17) MB+0.5%✅⬆️
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (19 - 20)+0.2%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms187.44 ± (187.14 - 187.74) ms188.80 ± (188.49 - 189.12) ms+0.7%✅⬆️
process.time_to_main_ms81.88 ± (81.73 - 82.02) ms82.31 ± (82.13 - 82.50) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.16 ± (16.13 - 16.18) MB16.16 ± (16.13 - 16.19) MB+0.0%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)-0.2%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms400.66 ± (398.02 - 403.29) ms402.14 ± (399.41 - 404.88) ms+0.4%✅⬆️
process.time_to_main_ms474.25 ± (473.60 - 474.90) ms475.04 ± (474.29 - 475.79) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.67 ± (58.55 - 58.80) MB58.75 ± (58.62 - 58.88) MB+0.1%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.0%✅
.NET 6 - Baseline
process.internal_duration_ms192.90 ± (192.50 - 193.30) ms193.75 ± (193.36 - 194.13) ms+0.4%✅⬆️
process.time_to_main_ms70.24 ± (70.07 - 70.41) ms70.62 ± (70.41 - 70.83) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.06 ± (15.92 - 16.20) MB16.36 ± (16.32 - 16.41) MB+1.9%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)19 ± (19 - 19)+3.7%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms191.81 ± (191.55 - 192.06) ms193.22 ± (192.83 - 193.61) ms+0.7%✅⬆️
process.time_to_main_ms71.15 ± (71.05 - 71.26) ms71.51 ± (71.36 - 71.67) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.16 ± (16.02 - 16.30) MB16.36 ± (16.30 - 16.42) MB+1.3%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)20 ± (20 - 20)+3.9%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms412.26 ± (410.15 - 414.36) ms406.23 ± (404.48 - 407.99) ms-1.5%✅
process.time_to_main_ms441.94 ± (441.41 - 442.46) ms443.15 ± (442.46 - 443.84) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed59.13 ± (59.01 - 59.26) MB58.98 ± (58.83 - 59.12) MB-0.3%✅
runtime.dotnet.threads.count30 ± (29 - 30)30 ± (30 - 30)+0.2%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms190.77 ± (190.48 - 191.07) ms190.68 ± (190.42 - 190.93) ms-0.1%✅
process.time_to_main_ms69.59 ± (69.40 - 69.78) ms69.65 ± (69.47 - 69.82) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.75 ± (11.71 - 11.78) MB11.76 ± (11.73 - 11.79) MB+0.1%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)+0.6%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms190.47 ± (190.19 - 190.75) ms190.24 ± (189.93 - 190.54) ms-0.1%✅
process.time_to_main_ms70.60 ± (70.48 - 70.72) ms70.67 ± (70.56 - 70.78) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.84 ± (11.81 - 11.87) MB11.85 ± (11.82 - 11.88) MB+0.1%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.0%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms368.91 ± (367.38 - 370.43) ms368.70 ± (367.20 - 370.20) ms-0.1%✅
process.time_to_main_ms431.47 ± (430.93 - 432.02) ms431.80 ± (431.25 - 432.35) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed47.94 ± (47.92 - 47.97) MB47.95 ± (47.93 - 47.98) MB+0.0%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.6%✅
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7913) - mean (75ms)  : 69, 81
    master - mean (75ms)  : 69, 81

    section Bailout
    This PR (7913) - mean (80ms)  : 75, 85
    master - mean (80ms)  : 74, 85

    section CallTarget+Inlining+NGEN
    This PR (7913) - mean (1,058ms)  : 1013, 1103
    master - mean (1,058ms)  : 1011, 1104
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7913) - mean (118ms)  : 112, 125
    master - mean (118ms)  : 110, 125

    section Bailout
    This PR (7913) - mean (120ms)  : 113, 127
    master - mean (120ms)  : 114, 126

    section CallTarget+Inlining+NGEN
    This PR (7913) - mean (761ms)  : 727, 795
    master - mean (757ms)  : 725, 789
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7913) - mean (106ms)  : 99, 113
    master - mean (105ms)  : 97, 113

    section Bailout
    This PR (7913) - mean (107ms)  : 100, 113
    master - mean (107ms)  : 99, 115

    section CallTarget+Inlining+NGEN
    This PR (7913) - mean (714ms)  : 673, 755
    master - mean (705ms)  : 676, 733
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7913) - mean (103ms)  : 96, 110
    master - mean (103ms)  : 97, 110

    section Bailout
    This PR (7913) - mean (106ms)  : 99, 112
    master - mean (104ms)  : 98, 110

    section CallTarget+Inlining+NGEN
    This PR (7913) - mean (697ms)  : 662, 733
    master - mean (679ms)  : 650, 708
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7913) - mean (194ms)  : 189, 199
    master - mean (193ms)  : 190, 197

    section Bailout
    This PR (7913) - mean (198ms)  : 195, 200
    master - mean (197ms)  : 194, 199

    section CallTarget+Inlining+NGEN
    This PR (7913) - mean (1,128ms)  : 1056, 1201
    master - mean (1,118ms)  : 1057, 1180
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7913) - mean (278ms)  : 272, 284
    master - mean (277ms)  : 272, 282

    section Bailout
    This PR (7913) - mean (279ms)  : 275, 284
    master - mean (277ms)  : 274, 281

    section CallTarget+Inlining+NGEN
    This PR (7913) - mean (911ms)  : 856, 967
    master - mean (910ms)  : 872, 949
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7913) - mean (273ms)  : 265, 280
    master - mean (272ms)  : 264, 280

    section Bailout
    This PR (7913) - mean (273ms)  : 266, 280
    master - mean (271ms)  : 268, 274

    section CallTarget+Inlining+NGEN
    This PR (7913) - mean (881ms)  : 849, 913
    master - mean (888ms)  : 850, 927
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7913) - mean (270ms)  : 266, 274
    master - mean (270ms)  : 265, 275

    section Bailout
    This PR (7913) - mean (270ms)  : 267, 274
    master - mean (271ms)  : 267, 274

    section CallTarget+Inlining+NGEN
    This PR (7913) - mean (831ms)  : 805, 857
    master - mean (831ms)  : 806, 856
Loading

@andrewlock andrewlock merged commit 77daef6 into master Dec 9, 2025
151 checks passed
@andrewlock andrewlock deleted the andrew/update-vendors branch December 9, 2025 09:04
@github-actions github-actions bot added this to the vNext-v3 milestone Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes

@bouwkast bouwkast bouwkast approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.33.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewlock @lucaspimentel @bouwkast