Skip to content

Stop testing .NET 8 on PRs#7881

Merged
andrewlock merged 1 commit intomasterfrom
andrew/stop-testing-net8
Dec 4, 2025
Merged

Stop testing .NET 8 on PRs#7881
andrewlock merged 1 commit intomasterfrom
andrew/stop-testing-net8

Conversation

@andrewlock
Copy link
Member

@andrewlock andrewlock commented Dec 1, 2025

Summary of changes

Removes .NET 8 from the standard test matrix for PRs

Reason for change

We recently added .NET 10 to the standard test matrix for PRs. As running more tests means more chance of flake, we agreed that removing .NET 8 to bring us back to the same level of testing makes sense.

  • We chose to remove .NET 8 vs .NET 9, as there are CLR fixes in .NET 9 that aren't in .NET 8
  • Both .NET 8 and .NET 9 have the same amount of official support remaining
  • Both .NET 8 and .NET 9 hit the same code paths in our code (which is all .NET 6+)

Also, to be clear, we still run the full suite of TFMs (.NET Core 3.0+) on master. We also run the full suite of TFMs on PRs if there are "risky" modifications (modifications to integrations), or if the run_all_test_frameworks variable is set.

Implementation details

Removed .NET 8 from the "on PRs" frameworks

Test coverage

Technically the same coverage, but a bit less comprehensive on PRs

@andrewlock andrewlock requested a review from a team as a code owner December 1, 2025 08:46
@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Dec 1, 2025
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Dec 1, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7881) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration74.88 ± (74.87 - 75.58) ms75.36 ± (75.45 - 76.03) ms+0.6%✅⬆️
.NET Framework 4.8 - Bailout
duration80.38 ± (80.30 - 81.13) ms79.50 ± (79.33 - 80.00) ms-1.1%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1057.13 ± (1057.80 - 1066.03) ms1059.37 ± (1060.29 - 1067.96) ms+0.2%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.76 ± (22.69 - 22.83) ms23.04 ± (22.96 - 23.12) ms+1.2%✅⬆️
process.time_to_main_ms87.41 ± (87.02 - 87.81) ms87.24 ± (86.90 - 87.57) ms-0.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.92 ± (10.91 - 10.92) MB10.92 ± (10.92 - 10.92) MB+0.0%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.84 ± (22.78 - 22.91) ms22.79 ± (22.73 - 22.86) ms-0.2%✅
process.time_to_main_ms88.72 ± (88.37 - 89.07) ms89.04 ± (88.71 - 89.37) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.96 ± (10.96 - 10.96) MB10.97 ± (10.96 - 10.97) MB+0.1%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms221.68 ± (220.24 - 223.13) ms221.05 ± (219.25 - 222.84) ms-0.3%✅
process.time_to_main_ms501.09 ± (499.88 - 502.30) ms499.01 ± (497.91 - 500.11) ms-0.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed47.85 ± (47.83 - 47.88) MB47.91 ± (47.89 - 47.93) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.5%✅
.NET 6 - Baseline
process.internal_duration_ms21.92 ± (21.84 - 21.99) ms21.67 ± (21.60 - 21.74) ms-1.1%✅
process.time_to_main_ms77.64 ± (77.26 - 78.01) ms75.74 ± (75.38 - 76.10) ms-2.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.62 ± (10.62 - 10.63) MB10.65 ± (10.64 - 10.65) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.68 ± (21.61 - 21.74) ms21.67 ± (21.60 - 21.74) ms-0.0%✅
process.time_to_main_ms77.41 ± (77.12 - 77.71) ms77.67 ± (77.31 - 78.03) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.67 ± (10.66 - 10.67) MB10.69 ± (10.69 - 10.69) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms212.23 ± (211.33 - 213.12) ms211.03 ± (209.89 - 212.18) ms-0.6%✅
process.time_to_main_ms468.07 ± (467.06 - 469.08) ms466.45 ± (465.54 - 467.36) ms-0.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.07 ± (48.04 - 48.10) MB48.08 ± (48.05 - 48.11) MB+0.0%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms19.88 ± (19.82 - 19.94) ms19.68 ± (19.63 - 19.74) ms-1.0%✅
process.time_to_main_ms74.92 ± (74.68 - 75.17) ms75.01 ± (74.72 - 75.31) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.67 ± (7.66 - 7.68) MB7.67 ± (7.67 - 7.68) MB+0.0%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.95 ± (19.89 - 20.00) ms19.84 ± (19.78 - 19.91) ms-0.5%✅
process.time_to_main_ms76.20 ± (75.92 - 76.47) ms76.44 ± (76.10 - 76.78) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.72 ± (7.71 - 7.72) MB7.73 ± (7.72 - 7.74) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms195.37 ± (194.28 - 196.45) ms193.47 ± (192.47 - 194.47) ms-1.0%✅
process.time_to_main_ms457.49 ± (456.41 - 458.56) ms455.54 ± (454.42 - 456.67) ms-0.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.42 ± (36.38 - 36.46) MB36.47 ± (36.43 - 36.51) MB+0.1%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.0%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration191.21 ± (191.38 - 192.44) ms192.46 ± (192.81 - 193.73) ms+0.7%✅⬆️
.NET Framework 4.8 - Bailout
duration194.78 ± (194.66 - 195.17) ms195.28 ± (195.20 - 195.79) ms+0.3%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1105.35 ± (1109.07 - 1117.71) ms1107.60 ± (1112.04 - 1120.48) ms+0.2%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms187.55 ± (187.14 - 187.97) ms186.89 ± (186.64 - 187.13) ms-0.4%✅
process.time_to_main_ms80.18 ± (79.96 - 80.40) ms80.28 ± (80.11 - 80.45) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.09 ± (16.06 - 16.12) MB16.11 ± (16.08 - 16.13) MB+0.1%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (19 - 20)-0.1%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms186.27 ± (185.96 - 186.59) ms186.58 ± (186.28 - 186.88) ms+0.2%✅⬆️
process.time_to_main_ms81.27 ± (81.14 - 81.41) ms81.52 ± (81.39 - 81.66) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.17 ± (16.14 - 16.19) MB16.17 ± (16.14 - 16.19) MB+0.0%✅⬆️
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (20 - 21)-0.2%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms400.36 ± (397.37 - 403.34) ms396.20 ± (393.49 - 398.92) ms-1.0%✅
process.time_to_main_ms470.64 ± (470.09 - 471.18) ms471.21 ± (470.61 - 471.81) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.30 ± (58.16 - 58.44) MB58.49 ± (58.36 - 58.63) MB+0.3%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.1%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms190.48 ± (190.16 - 190.80) ms190.81 ± (190.48 - 191.13) ms+0.2%✅⬆️
process.time_to_main_ms69.58 ± (69.44 - 69.73) ms69.67 ± (69.51 - 69.83) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed15.80 ± (15.63 - 15.97) MB15.96 ± (15.79 - 16.12) MB+1.0%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)+0.2%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms189.96 ± (189.70 - 190.21) ms190.69 ± (190.32 - 191.05) ms+0.4%✅⬆️
process.time_to_main_ms70.63 ± (70.52 - 70.75) ms70.80 ± (70.70 - 70.90) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed15.68 ± (15.51 - 15.85) MB16.16 ± (16.03 - 16.30) MB+3.0%✅⬆️
runtime.dotnet.threads.count19 ± (18 - 19)20 ± (19 - 20)+5.5%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms404.32 ± (401.98 - 406.66) ms405.08 ± (403.20 - 406.95) ms+0.2%✅⬆️
process.time_to_main_ms438.59 ± (438.02 - 439.16) ms439.86 ± (439.30 - 440.42) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed58.48 ± (58.32 - 58.64) MB58.80 ± (58.64 - 58.95) MB+0.5%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (29 - 30)-0.2%✅
.NET 8 - Baseline
process.internal_duration_ms188.68 ± (188.41 - 188.95) ms188.82 ± (188.55 - 189.09) ms+0.1%✅⬆️
process.time_to_main_ms69.12 ± (68.93 - 69.31) ms68.87 ± (68.69 - 69.06) ms-0.4%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.81 ± (11.77 - 11.84) MB11.79 ± (11.75 - 11.83) MB-0.1%✅
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)+0.1%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms188.72 ± (188.47 - 188.98) ms188.04 ± (187.78 - 188.31) ms-0.4%✅
process.time_to_main_ms69.93 ± (69.85 - 70.01) ms69.88 ± (69.78 - 69.98) ms-0.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.76 ± (11.68 - 11.85) MB11.82 ± (11.76 - 11.88) MB+0.5%✅⬆️
runtime.dotnet.threads.count19 ± (18 - 19)19 ± (18 - 19)-0.1%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms364.92 ± (363.63 - 366.21) ms363.89 ± (362.40 - 365.37) ms-0.3%✅
process.time_to_main_ms426.36 ± (425.74 - 426.99) ms426.67 ± (426.04 - 427.30) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed47.90 ± (47.87 - 47.93) MB47.86 ± (47.83 - 47.88) MB-0.1%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.0%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7881) - mean (76ms)  : 72, 80
    master - mean (75ms)  : 70, 81

    section Bailout
    This PR (7881) - mean (80ms)  : 75, 84
    master - mean (81ms)  : 74, 87

    section CallTarget+Inlining+NGEN
    This PR (7881) - mean (1,064ms)  : 1008, 1120
    master - mean (1,062ms)  : 1003, 1121
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7881) - mean (118ms)  : 112, 123
    master - mean (118ms)  : 111, 125

    section Bailout
    This PR (7881) - mean (119ms)  : 113, 126
    master - mean (119ms)  : 112, 126

    section CallTarget+Inlining+NGEN
    This PR (7881) - mean (759ms)  : 710, 808
    master - mean (762ms)  : 726, 799
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7881) - mean (104ms)  : 97, 112
    master - mean (107ms)  : 100, 114

    section Bailout
    This PR (7881) - mean (106ms)  : 100, 112
    master - mean (106ms)  : 100, 112

    section CallTarget+Inlining+NGEN
    This PR (7881) - mean (705ms)  : 679, 731
    master - mean (708ms)  : 676, 741
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7881) - mean (103ms)  : 98, 108
    master - mean (103ms)  : 98, 108

    section Bailout
    This PR (7881) - mean (105ms)  : 98, 112
    master - mean (105ms)  : 100, 110

    section CallTarget+Inlining+NGEN
    This PR (7881) - mean (681ms)  : 653, 710
    master - mean (685ms)  : 655, 714
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7881) - mean (193ms)  : 187, 199
    master - mean (192ms)  : 186, 197

    section Bailout
    This PR (7881) - mean (195ms)  : 193, 198
    master - mean (195ms)  : 192, 197

    section CallTarget+Inlining+NGEN
    This PR (7881) - mean (1,116ms)  : 1055, 1178
    master - mean (1,113ms)  : 1051, 1175
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7881) - mean (275ms)  : 271, 279
    master - mean (276ms)  : 271, 281

    section Bailout
    This PR (7881) - mean (276ms)  : 273, 280
    master - mean (276ms)  : 272, 280

    section CallTarget+Inlining+NGEN
    This PR (7881) - mean (903ms)  : 866, 939
    master - mean (904ms)  : 852, 957
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7881) - mean (269ms)  : 264, 274
    master - mean (268ms)  : 263, 274

    section Bailout
    This PR (7881) - mean (269ms)  : 265, 274
    master - mean (269ms)  : 264, 273

    section CallTarget+Inlining+NGEN
    This PR (7881) - mean (877ms)  : 843, 911
    master - mean (876ms)  : 837, 914
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7881) - mean (267ms)  : 262, 273
    master - mean (267ms)  : 262, 273

    section Bailout
    This PR (7881) - mean (267ms)  : 264, 271
    master - mean (268ms)  : 264, 272

    section CallTarget+Inlining+NGEN
    This PR (7881) - mean (822ms)  : 801, 844
    master - mean (823ms)  : 801, 845
Loading

@andrewlock andrewlock merged commit 0d0b6b3 into master Dec 4, 2025
151 checks passed
@andrewlock andrewlock deleted the andrew/stop-testing-net8 branch December 4, 2025 14:41
@github-actions github-actions bot added this to the vNext-v3 milestone Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes

@bouwkast bouwkast bouwkast approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.33.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewlock @lucaspimentel @bouwkast