Skip to content

[Dynamix Instrumentation] Fix DebuggerUploader adaptive flush interval#7831

Merged
dudikeleti merged 1 commit intomasterfrom
dudik/fix-interval-update
Dec 29, 2025
Merged

[Dynamix Instrumentation] Fix DebuggerUploader adaptive flush interval#7831
dudikeleti merged 1 commit intomasterfrom
dudik/fix-interval-update

Conversation

@dudikeleti
Copy link
Contributor

@dudikeleti dudikeleti commented Nov 17, 2025 •
edited
Loading

Summary of changes

Fixes a bug where the adaptive flush interval in DebuggerUploaderBase never actually adapted because the interval was reinitialized on every loop iteration.

Reason for change

This bug caused our debug log to be very noisy with irrelevant messages on every timer interval, regardless of whether the interval changed or not.

@dudikeleti dudikeleti requested a review from a team as a code owner November 17, 2025 15:51
@github-actions github-actions bot added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:debugger labels Nov 17, 2025
@dudikeleti dudikeleti changed the title Fix DebuggerUploaderBase adaptive flush interval [Dynamix Instrumentation] Fix DebuggerUploader adaptive flush interval Nov 17, 2025
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Nov 17, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7831) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration75.40 ± (75.21 - 75.82) ms75.45 ± (75.55 - 76.36) ms+0.1%✅⬆️
.NET Framework 4.8 - Bailout
duration81.58 ± (81.44 - 82.53) ms78.97 ± (78.77 - 79.51) ms-3.2%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1138.61 ± (1140.95 - 1155.55) ms1115.51 ± (1115.37 - 1123.28) ms-2.0%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms23.07 ± (22.99 - 23.15) ms22.96 ± (22.88 - 23.04) ms-0.5%✅
process.time_to_main_ms87.85 ± (87.49 - 88.21) ms87.68 ± (87.29 - 88.06) ms-0.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.91 ± (10.91 - 10.92) MB10.91 ± (10.90 - 10.91) MB-0.1%✅
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms23.00 ± (22.93 - 23.06) ms23.04 ± (22.95 - 23.12) ms+0.2%✅⬆️
process.time_to_main_ms89.79 ± (89.44 - 90.14) ms90.33 ± (89.99 - 90.68) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.96 ± (10.95 - 10.96) MB10.95 ± (10.95 - 10.96) MB-0.0%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms220.85 ± (219.50 - 222.19) ms220.59 ± (219.16 - 222.02) ms-0.1%✅
process.time_to_main_ms553.22 ± (551.95 - 554.49) ms548.54 ± (547.51 - 549.58) ms-0.8%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed52.68 ± (52.66 - 52.70) MB52.48 ± (52.46 - 52.50) MB-0.4%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.87 ± (21.80 - 21.94) ms21.60 ± (21.54 - 21.65) ms-1.2%✅
process.time_to_main_ms76.83 ± (76.48 - 77.19) ms75.85 ± (75.55 - 76.15) ms-1.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.60 ± (10.60 - 10.60) MB10.62 ± (10.62 - 10.62) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.75 ± (21.68 - 21.81) ms21.69 ± (21.61 - 21.77) ms-0.3%✅
process.time_to_main_ms78.26 ± (77.89 - 78.63) ms76.92 ± (76.56 - 77.28) ms-1.7%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.65 ± (10.65 - 10.66) MB10.66 ± (10.66 - 10.66) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms211.11 ± (208.47 - 213.76) ms207.45 ± (206.16 - 208.75) ms-1.7%✅
process.time_to_main_ms520.24 ± (519.15 - 521.33) ms510.25 ± (509.04 - 511.46) ms-1.9%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed51.77 ± (51.74 - 51.80) MB51.65 ± (51.62 - 51.68) MB-0.2%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms19.86 ± (19.79 - 19.92) ms19.96 ± (19.88 - 20.04) ms+0.5%✅⬆️
process.time_to_main_ms74.33 ± (74.02 - 74.64) ms74.91 ± (74.51 - 75.32) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.65 ± (7.65 - 7.66) MB7.63 ± (7.62 - 7.64) MB-0.3%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms20.12 ± (20.06 - 20.18) ms19.85 ± (19.79 - 19.92) ms-1.3%✅
process.time_to_main_ms78.34 ± (77.94 - 78.73) ms76.27 ± (75.91 - 76.63) ms-2.6%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.71 ± (7.71 - 7.72) MB7.69 ± (7.68 - 7.70) MB-0.3%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms192.78 ± (191.82 - 193.75) ms193.33 ± (192.37 - 194.28) ms+0.3%✅⬆️
process.time_to_main_ms497.55 ± (496.61 - 498.49) ms489.38 ± (488.23 - 490.53) ms-1.6%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed39.20 ± (39.16 - 39.23) MB38.91 ± (38.87 - 38.95) MB-0.7%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.0%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration192.82 ± (192.99 - 193.93) ms195.30 ± (194.87 - 195.73) ms+1.3%✅⬆️
.NET Framework 4.8 - Bailout
duration196.33 ± (196.25 - 196.72) ms199.95 ± (199.51 - 200.55) ms+1.8%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1162.43 ± (1163.08 - 1169.83) ms1181.97 ± (1184.40 - 1195.04) ms+1.7%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms188.71 ± (188.29 - 189.12) ms190.47 ± (190.11 - 190.83) ms+0.9%✅⬆️
process.time_to_main_ms80.87 ± (80.67 - 81.06) ms81.41 ± (81.20 - 81.63) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.13 ± (16.10 - 16.16) MB16.09 ± (16.06 - 16.11) MB-0.3%✅
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (20 - 20)+0.3%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms187.69 ± (187.42 - 187.95) ms191.52 ± (191.07 - 191.98) ms+2.0%✅⬆️
process.time_to_main_ms82.13 ± (81.97 - 82.28) ms83.58 ± (83.36 - 83.80) ms+1.8%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.20 ± (16.18 - 16.23) MB16.13 ± (16.11 - 16.15) MB-0.4%✅
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)-0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms397.03 ± (394.30 - 399.76) ms396.46 ± (394.19 - 398.74) ms-0.1%✅
process.time_to_main_ms517.20 ± (516.56 - 517.84) ms518.94 ± (518.22 - 519.67) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed63.00 ± (62.84 - 63.16) MB63.15 ± (63.00 - 63.29) MB+0.2%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.1%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms192.64 ± (192.23 - 193.06) ms193.20 ± (192.84 - 193.55) ms+0.3%✅⬆️
process.time_to_main_ms70.05 ± (69.86 - 70.23) ms69.96 ± (69.78 - 70.14) ms-0.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.10 ± (15.97 - 16.23) MB16.08 ± (15.94 - 16.22) MB-0.1%✅
runtime.dotnet.threads.count18 ± (18 - 19)18 ± (18 - 19)-0.0%✅
.NET 6 - Bailout
process.internal_duration_ms193.08 ± (192.60 - 193.55) ms191.78 ± (191.44 - 192.12) ms-0.7%✅
process.time_to_main_ms71.24 ± (71.10 - 71.39) ms71.13 ± (71.00 - 71.27) ms-0.2%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.40 ± (16.37 - 16.43) MB16.43 ± (16.39 - 16.46) MB+0.1%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)-1.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms407.77 ± (404.88 - 410.66) ms411.95 ± (409.03 - 414.88) ms+1.0%✅⬆️
process.time_to_main_ms486.13 ± (485.54 - 486.72) ms483.55 ± (482.85 - 484.25) ms-0.5%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed62.08 ± (61.92 - 62.23) MB62.18 ± (62.04 - 62.32) MB+0.2%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 30)29 ± (29 - 30)-0.1%✅
.NET 8 - Baseline
process.internal_duration_ms190.14 ± (189.74 - 190.54) ms190.29 ± (189.94 - 190.64) ms+0.1%✅⬆️
process.time_to_main_ms69.11 ± (68.94 - 69.28) ms69.44 ± (69.23 - 69.64) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.78 ± (11.74 - 11.81) MB11.71 ± (11.68 - 11.73) MB-0.6%✅
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-1.0%✅
.NET 8 - Bailout
process.internal_duration_ms190.37 ± (189.92 - 190.82) ms189.52 ± (189.23 - 189.80) ms-0.4%✅
process.time_to_main_ms70.46 ± (70.33 - 70.59) ms70.33 ± (70.20 - 70.45) ms-0.2%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.82 ± (11.77 - 11.87) MB11.83 ± (11.80 - 11.85) MB+0.1%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.2%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms365.47 ± (364.05 - 366.89) ms361.12 ± (359.50 - 362.75) ms-1.2%✅
process.time_to_main_ms467.54 ± (466.88 - 468.20) ms458.84 ± (458.02 - 459.66) ms-1.9%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed50.59 ± (50.55 - 50.63) MB50.37 ± (50.33 - 50.41) MB-0.4%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.3%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7831) - mean (76ms)  : 70, 82
    master - mean (76ms)  : 71, 80

    section Bailout
    This PR (7831) - mean (79ms)  : 73, 85
    master - mean (82ms)  : 74, 90

    section CallTarget+Inlining+NGEN
    This PR (7831) - mean (1,119ms)  : 1063, 1175
    master - mean (1,148ms)  : 1034, 1262
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7831) - mean (118ms)  : 110, 126
    master - mean (119ms)  : 111, 127

    section Bailout
    This PR (7831) - mean (121ms)  : 115, 127
    master - mean (120ms)  : 114, 126

    section CallTarget+Inlining+NGEN
    This PR (7831) - mean (804ms)  : 765, 844
    master - mean (811ms)  : 767, 855
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7831) - mean (105ms)  : 98, 111
    master - mean (106ms)  : 98, 114

    section Bailout
    This PR (7831) - mean (106ms)  : 99, 113
    master - mean (107ms)  : 100, 114

    section CallTarget+Inlining+NGEN
    This PR (7831) - mean (748ms)  : 707, 789
    master - mean (763ms)  : 712, 814
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7831) - mean (103ms)  : 97, 109
    master - mean (103ms)  : 95, 111

    section Bailout
    This PR (7831) - mean (104ms)  : 97, 111
    master - mean (107ms)  : 98, 116

    section CallTarget+Inlining+NGEN
    This PR (7831) - mean (713ms)  : 683, 743
    master - mean (723ms)  : 693, 753
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7831) - mean (195ms)  : 190, 200
    master - mean (193ms)  : 188, 199

    section Bailout
    This PR (7831) - mean (200ms)  : 193, 207
    master - mean (196ms)  : 194, 199

    section CallTarget+Inlining+NGEN
    This PR (7831) - mean (1,190ms)  : 1107, 1273
    master - mean (1,166ms)  : 1118, 1215
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7831) - mean (281ms)  : 274, 288
    master - mean (278ms)  : 272, 284

    section Bailout
    This PR (7831) - mean (283ms)  : 274, 292
    master - mean (278ms)  : 274, 282

    section CallTarget+Inlining+NGEN
    This PR (7831) - mean (947ms)  : 899, 994
    master - mean (951ms)  : 907, 994
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7831) - mean (271ms)  : 266, 277
    master - mean (271ms)  : 265, 277

    section Bailout
    This PR (7831) - mean (271ms)  : 266, 275
    master - mean (273ms)  : 267, 278

    section CallTarget+Inlining+NGEN
    This PR (7831) - mean (929ms)  : 879, 979
    master - mean (925ms)  : 878, 971
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7831) - mean (270ms)  : 265, 274
    master - mean (269ms)  : 263, 274

    section Bailout
    This PR (7831) - mean (270ms)  : 266, 274
    master - mean (270ms)  : 264, 276

    section CallTarget+Inlining+NGEN
    This PR (7831) - mean (853ms)  : 832, 874
    master - mean (865ms)  : 845, 885
Loading

@dudikeleti dudikeleti merged commit b2597a4 into master Dec 29, 2025
75 of 78 checks passed
@dudikeleti dudikeleti deleted the dudik/fix-interval-update branch December 29, 2025 13:18
@github-actions github-actions bot added this to the vNext-v3 milestone Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylfin tylfin tylfin approved these changes

Assignees

No one assigned

Labels

area:debugger area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)

Projects

None yet

Milestone

3.35.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dudikeleti @tylfin