Skip to content

Tweak CI variables#7784

Merged
andrewlock merged 2 commits intomasterfrom
andrew/ci/tweak-variables
Nov 5, 2025
Merged

Tweak CI variables#7784
andrewlock merged 2 commits intomasterfrom
andrew/ci/tweak-variables

Conversation

@andrewlock
Copy link
Member

@andrewlock andrewlock commented Nov 5, 2025

Summary of changes

  • Don't clobber the global filter in linux integration tests
  • Rename the "force" variables to not imply they're specific to "exploration" tests

Reason for change

  • The filter gets clobbered - if you explicitly set the Filter variable it gets ignored in linux integration tests
  • It's confusing having exploration in the name

Implementation details

Fix it

Test coverage

Meh

@andrewlock andrewlock requested a review from a team as a code owner November 5, 2025 17:49
@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Nov 5, 2025
bouwkast
bouwkast approved these changes Nov 5, 2025
View reviewed changes
Copy link
Collaborator

@bouwkast bouwkast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Nov 5, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7784) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration68.65 ± (68.67 - 68.96) ms68.74 ± (68.75 - 68.98) ms+0.1%✅⬆️
.NET Framework 4.8 - Bailout
duration72.55 ± (72.48 - 72.86) ms72.80 ± (72.62 - 72.87) ms+0.3%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1049.31 ± (1049.36 - 1054.86) ms1120.54 ± (1103.23 - 1120.72) ms+6.8%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.12 ± (22.09 - 22.15) ms22.60 ± (22.51 - 22.68) ms+2.2%✅⬆️
process.time_to_main_ms79.83 ± (79.67 - 79.99) ms82.09 ± (81.75 - 82.42) ms+2.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.91 ± (10.90 - 10.91) MB10.89 ± (10.89 - 10.90) MB-0.1%✅
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.05 ± (22.03 - 22.08) ms22.01 ± (21.98 - 22.03) ms-0.2%✅
process.time_to_main_ms81.34 ± (81.21 - 81.48) ms81.40 ± (81.26 - 81.54) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.94 ± (10.94 - 10.95) MB10.93 ± (10.93 - 10.94) MB-0.1%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms209.82 ± (208.48 - 211.16) ms210.05 ± (208.83 - 211.27) ms+0.1%✅⬆️
process.time_to_main_ms519.79 ± (519.21 - 520.38) ms516.96 ± (516.37 - 517.55) ms-0.5%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed52.67 ± (52.65 - 52.69) MB52.53 ± (52.50 - 52.55) MB-0.3%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅
.NET 6 - Baseline
process.internal_duration_ms20.80 ± (20.77 - 20.83) ms20.95 ± (20.92 - 20.98) ms+0.7%✅⬆️
process.time_to_main_ms69.18 ± (69.05 - 69.31) ms69.90 ± (69.79 - 70.02) ms+1.1%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.61 ± (10.61 - 10.61) MB10.60 ± (10.60 - 10.60) MB-0.1%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms20.75 ± (20.72 - 20.79) ms20.84 ± (20.81 - 20.87) ms+0.4%✅⬆️
process.time_to_main_ms69.97 ± (69.83 - 70.11) ms71.02 ± (70.91 - 71.14) ms+1.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.63 ± (10.62 - 10.63) MB10.65 ± (10.65 - 10.66) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms201.92 ± (199.26 - 204.57) ms197.51 ± (196.25 - 198.76) ms-2.2%✅
process.time_to_main_ms486.02 ± (485.46 - 486.58) ms480.66 ± (480.08 - 481.25) ms-1.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed51.66 ± (51.60 - 51.72) MB51.37 ± (51.30 - 51.45) MB-0.6%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms19.02 ± (19.00 - 19.05) ms18.96 ± (18.93 - 18.99) ms-0.3%✅
process.time_to_main_ms68.27 ± (68.14 - 68.40) ms68.49 ± (68.35 - 68.64) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.65 ± (7.64 - 7.65) MB7.66 ± (7.65 - 7.66) MB+0.1%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms18.98 ± (18.96 - 19.01) ms18.99 ± (18.95 - 19.02) ms+0.0%✅⬆️
process.time_to_main_ms69.46 ± (69.34 - 69.58) ms69.35 ± (69.23 - 69.48) ms-0.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.69 ± (7.68 - 7.70) MB7.68 ± (7.67 - 7.68) MB-0.1%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms179.32 ± (178.51 - 180.14) ms179.67 ± (178.98 - 180.36) ms+0.2%✅⬆️
process.time_to_main_ms461.73 ± (461.26 - 462.20) ms457.79 ± (457.38 - 458.21) ms-0.9%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed38.80 ± (38.77 - 38.83) MB38.64 ± (38.62 - 38.67) MB-0.4%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.2%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration194.30 ± (194.74 - 195.78) ms193.21 ± (193.16 - 194.07) ms-0.6%✅
.NET Framework 4.8 - Bailout
duration197.19 ± (197.22 - 197.90) ms197.85 ± (197.72 - 198.65) ms+0.3%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1168.58 ± (1167.61 - 1175.32) ms1162.54 ± (1166.86 - 1175.27) ms-0.5%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms190.35 ± (189.91 - 190.79) ms187.89 ± (187.50 - 188.29) ms-1.3%✅
process.time_to_main_ms81.51 ± (81.31 - 81.71) ms80.94 ± (80.70 - 81.17) ms-0.7%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.02 ± (16.00 - 16.05) MB16.11 ± (16.09 - 16.13) MB+0.5%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.2%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms190.25 ± (189.78 - 190.72) ms187.54 ± (187.19 - 187.89) ms-1.4%✅
process.time_to_main_ms83.39 ± (83.18 - 83.60) ms82.22 ± (82.08 - 82.36) ms-1.4%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.10 ± (16.08 - 16.13) MB16.17 ± (16.14 - 16.19) MB+0.4%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)+0.1%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms399.26 ± (396.67 - 401.85) ms393.81 ± (391.36 - 396.26) ms-1.4%✅
process.time_to_main_ms521.83 ± (520.92 - 522.75) ms517.15 ± (516.51 - 517.79) ms-0.9%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed63.25 ± (63.11 - 63.39) MB63.20 ± (63.06 - 63.34) MB-0.1%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 30)+0.1%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms191.99 ± (191.65 - 192.33) ms192.04 ± (191.63 - 192.46) ms+0.0%✅⬆️
process.time_to_main_ms70.09 ± (69.90 - 70.28) ms69.61 ± (69.46 - 69.77) ms-0.7%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.17 ± (16.05 - 16.29) MB16.13 ± (16.00 - 16.26) MB-0.2%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.4%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms196.65 ± (195.95 - 197.34) ms190.74 ± (190.46 - 191.01) ms-3.0%✅
process.time_to_main_ms72.63 ± (72.33 - 72.93) ms70.49 ± (70.39 - 70.58) ms-2.9%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.35 ± (16.32 - 16.37) MB16.09 ± (15.94 - 16.24) MB-1.6%✅
runtime.dotnet.threads.count20 ± (20 - 20)19 ± (19 - 19)-5.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms413.95 ± (410.95 - 416.94) ms415.49 ± (412.13 - 418.84) ms+0.4%✅⬆️
process.time_to_main_ms489.80 ± (488.85 - 490.74) ms480.16 ± (479.62 - 480.70) ms-2.0%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed62.24 ± (62.09 - 62.39) MB62.07 ± (61.94 - 62.21) MB-0.3%✅
runtime.dotnet.threads.count30 ± (29 - 30)29 ± (29 - 29)-0.2%✅
.NET 8 - Baseline
process.internal_duration_ms190.91 ± (190.52 - 191.30) ms190.47 ± (190.14 - 190.81) ms-0.2%✅
process.time_to_main_ms69.69 ± (69.51 - 69.87) ms69.64 ± (69.47 - 69.81) ms-0.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.76 ± (11.73 - 11.78) MB11.70 ± (11.68 - 11.73) MB-0.5%✅
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)+0.2%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms191.05 ± (190.62 - 191.48) ms189.70 ± (189.38 - 190.02) ms-0.7%✅
process.time_to_main_ms70.98 ± (70.83 - 71.13) ms70.38 ± (70.28 - 70.49) ms-0.8%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.77 ± (11.75 - 11.80) MB11.78 ± (11.75 - 11.80) MB+0.1%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.4%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms365.50 ± (364.16 - 366.83) ms361.68 ± (360.24 - 363.12) ms-1.0%✅
process.time_to_main_ms470.76 ± (470.10 - 471.41) ms459.29 ± (458.72 - 459.87) ms-2.4%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed50.49 ± (50.46 - 50.52) MB50.24 ± (50.21 - 50.27) MB-0.5%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.1%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7784) - mean (69ms)  : 67, 71
    master - mean (69ms)  : 67, 71

    section Bailout
    This PR (7784) - mean (73ms)  : 71, 74
    master - mean (73ms)  : 71, 75

    section CallTarget+Inlining+NGEN
    This PR (7784) - mean (1,112ms)  : 985, 1239
    master - mean (1,052ms)  : 1013, 1091
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7784) - mean (111ms)  : 106, 117
    master - mean (108ms)  : 105, 110

    section Bailout
    This PR (7784) - mean (109ms)  : 107, 111
    master - mean (109ms)  : 107, 111

    section CallTarget+Inlining+NGEN
    This PR (7784) - mean (762ms)  : 735, 790
    master - mean (763ms)  : 723, 804
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7784) - mean (96ms)  : 94, 98
    master - mean (95ms)  : 93, 97

    section Bailout
    This PR (7784) - mean (97ms)  : 95, 99
    master - mean (96ms)  : 93, 98

    section CallTarget+Inlining+NGEN
    This PR (7784) - mean (707ms)  : 678, 737
    master - mean (717ms)  : 676, 758
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7784) - mean (94ms)  : 91, 96
    master - mean (94ms)  : 91, 97

    section Bailout
    This PR (7784) - mean (95ms)  : 93, 97
    master - mean (95ms)  : 92, 97

    section CallTarget+Inlining+NGEN
    This PR (7784) - mean (670ms)  : 648, 692
    master - mean (670ms)  : 652, 687
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7784) - mean (194ms)  : 189, 198
    master - mean (195ms)  : 188, 203

    section Bailout
    This PR (7784) - mean (198ms)  : 193, 204
    master - mean (198ms)  : 194, 201

    section CallTarget+Inlining+NGEN
    This PR (7784) - mean (1,171ms)  : 1109, 1233
    master - mean (1,171ms)  : 1117, 1226
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7784) - mean (278ms)  : 272, 283
    master - mean (281ms)  : 269, 292

    section Bailout
    This PR (7784) - mean (278ms)  : 274, 283
    master - mean (282ms)  : 272, 292

    section CallTarget+Inlining+NGEN
    This PR (7784) - mean (953ms)  : 903, 1003
    master - mean (961ms)  : 916, 1007
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7784) - mean (270ms)  : 265, 274
    master - mean (270ms)  : 266, 274

    section Bailout
    This PR (7784) - mean (269ms)  : 266, 273
    master - mean (278ms)  : 262, 294

    section CallTarget+Inlining+NGEN
    This PR (7784) - mean (929ms)  : 868, 989
    master - mean (938ms)  : 881, 996
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7784) - mean (270ms)  : 265, 274
    master - mean (270ms)  : 264, 276

    section Bailout
    This PR (7784) - mean (270ms)  : 266, 274
    master - mean (272ms)  : 265, 278

    section CallTarget+Inlining+NGEN
    This PR (7784) - mean (853ms)  : 834, 872
    master - mean (868ms)  : 844, 892
Loading

@andrewlock andrewlock merged commit 068cdd0 into master Nov 5, 2025
152 checks passed
@andrewlock andrewlock deleted the andrew/ci/tweak-variables branch November 5, 2025 19:29
@github-actions github-actions bot added this to the vNext-v3 milestone Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes

@bouwkast bouwkast bouwkast approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.31.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewlock @lucaspimentel @bouwkast