Add fix for whitespace in exporter settings and metrics URL by andrewlock · Pull Request #7747 · DataDog/dd-trace-dotnet

andrewlock · 2025-10-31T17:49:54Z

Summary of changes

Trim whitespace in the exporter settings values before trying to use them
Fix a bug where having a whitespace in the DD_DOGSTATSD_SOCKET variable would cause incorrect (and invalid) UDS config

Reason for change

This manifested in a different test in a branch, where an empty string passed in DD_DOGSTATSD_SOCKET was causing us to use UDS for metrics even through it's not available and not really set.

Implementation details

Trim() the string variables (I don't think there's a good reason not to?)
As we're trimming, we can switch to IsNullOrEmpty instead of IsWhitespace
Treat empty DD_DOGSTATSD_SOCKET as not set

Alternatively, we could not trim, stick to using IsWhitespace, and just update the check I fixed to use IsWhitespace 🤷‍♂️

Test coverage

Added a couple of unit tests. Only one test is for this specific issue, the others were just part of my investigation, and seemed reasonable.

Other details

Discovered as part of #7724 and https://datadoghq.atlassian.net/browse/LANGPLAT-819

This manifested in a different test where an empty string passed as the DogStatsD socket was causing us to use UDS even through it's not available and not _really_ set

andrewlock · 2025-10-31T17:50:20Z

tracer/src/Datadog.Trace/Configuration/ExporterSettings.Shared.cs

            // For some cases, we allow falling back on another configuration (eg invalid url as the application will need to be restarted to fix it anyway).
            // For other cases (eg a configured unix domain socket path not found), we don't fallback as the problem could be fixed outside the application.
-            if (!string.IsNullOrWhiteSpace(agentUri))
+            if (!string.IsNullOrEmpty(agentUri))


If we're trimming, we only need to check for empty

andrewlock · 2025-10-31T17:50:31Z

tracer/src/Datadog.Trace/Configuration/ExporterSettings.cs

                settings = new MetricsTransportSettings(TransportType.NamedPipe, PipeName: metricsPipeName);
            }
-            else if (metricsUnixDomainSocketPath != null)
+            else if (!string.IsNullOrEmpty(metricsUnixDomainSocketPath))


This fixes the actual bug

andrewlock · 2025-10-31T17:50:52Z

tracer/test/Datadog.Trace.Tests/Configuration/ExporterSettingsTests.cs

+        [InlineData(null)]
+        [InlineData("")]
+        [InlineData(" ")]
+        public void Metrics_UdsTraceAgent_EmptyDogStatsdSocket_UsesDefaultUdp(string metricsSocket)


This is the test that fails before the fix

andrewlock · 2025-10-31T17:50:59Z

tracer/test/Datadog.Trace.Tests/Configuration/ExporterSettingsTests.cs


        [Fact]
-        public void Metrics_DogStatsdUrl_UdsUnsupported_UsesDefaultUdsOnLinux()
+        public void Metrics_DogStatsdUrl_UdsUnsupported_UsesDefaultUdpOnLinux()


typo in the test name

dd-trace-dotnet-ci-bot · 2025-10-31T19:25:16Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7747) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7747) - mean (68ms)  : 66, 70
     .   : milestone, 68,
    master - mean (68ms)  : 67, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7747) - mean (1,047ms)  : 999, 1096
     .   : milestone, 1047,
    master - mean (1,045ms)  : 1004, 1087
     .   : milestone, 1045,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7747) - mean (107ms)  : 105, 108
     .   : milestone, 107,
    master - mean (107ms)  : 105, 108
     .   : milestone, 107,

    section Baseline
    This PR (7747) - mean (105ms)  : 103, 108
     .   : milestone, 105,
    master - mean (106ms)  : 104, 108
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (7747) - mean (748ms)  : 726, 770
     .   : milestone, 748,
    master - mean (749ms)  : 719, 780
     .   : milestone, 749,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7747) - mean (94ms)  : 93, 95
     .   : milestone, 94,
    master - mean (94ms)  : 93, 95
     .   : milestone, 94,

    section Baseline
    This PR (7747) - mean (93ms)  : 91, 95
     .   : milestone, 93,
    master - mean (94ms)  : 92, 96
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (7747) - mean (710ms)  : 672, 747
     .   : milestone, 710,
    master - mean (708ms)  : 670, 745
     .   : milestone, 708,

gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7747) - mean (93ms)  : 91, 94
     .   : milestone, 93,
    master - mean (93ms)  : 91, 95
     .   : milestone, 93,

    section Baseline
    This PR (7747) - mean (92ms)  : 89, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7747) - mean (659ms)  : 643, 674
     .   : milestone, 659,
    master - mean (664ms)  : 649, 679
     .   : milestone, 664,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7747) - mean (196ms)  : 194, 198
     .   : milestone, 196,
    master - mean (196ms)  : 192, 201
     .   : milestone, 196,

    section Baseline
    This PR (7747) - mean (194ms)  : 190, 198
     .   : milestone, 194,
    master - mean (193ms)  : 189, 196
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (7747) - mean (1,170ms)  : 1109, 1232
     .   : milestone, 1170,
    master - mean (1,175ms)  : 1099, 1250
     .   : milestone, 1175,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7747) - mean (278ms)  : 274, 283
     .   : milestone, 278,
    master - mean (277ms)  : 273, 281
     .   : milestone, 277,

    section Baseline
    This PR (7747) - mean (283ms)  : 274, 293
     .   : milestone, 283,
    master - mean (277ms)  : 272, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (7747) - mean (963ms)  : 912, 1014
     .   : milestone, 963,
    master - mean (957ms)  : 905, 1008
     .   : milestone, 957,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7747) - mean (270ms)  : 266, 274
     .   : milestone, 270,
    master - mean (269ms)  : 265, 273
     .   : milestone, 269,

    section Baseline
    This PR (7747) - mean (271ms)  : 265, 276
     .   : milestone, 271,
    master - mean (270ms)  : 265, 275
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (7747) - mean (944ms)  : 887, 1002
     .   : milestone, 944,
    master - mean (933ms)  : 873, 992
     .   : milestone, 933,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7747) - mean (274ms)  : 266, 282
     .   : milestone, 274,
    master - mean (270ms)  : 264, 275
     .   : milestone, 270,

    section Baseline
    This PR (7747) - mean (273ms)  : 265, 281
     .   : milestone, 273,
    master - mean (268ms)  : 263, 273
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (7747) - mean (861ms)  : 837, 885
     .   : milestone, 861,
    master - mean (855ms)  : 837, 873
     .   : milestone, 855,

Add fix for whitespace in exporter settings and metrics URL

59d3f61

This manifested in a different test where an empty string passed as the DogStatsD socket was causing us to use UDS even through it's not available and not _really_ set

andrewlock added the type:bug label Oct 31, 2025

andrewlock requested a review from a team as a code owner October 31, 2025 17:49

andrewlock added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Oct 31, 2025

andrewlock commented Oct 31, 2025

View reviewed changes

link04 approved these changes Oct 31, 2025

View reviewed changes

bouwkast approved these changes Oct 31, 2025

View reviewed changes

bouwkast enabled auto-merge (squash) October 31, 2025 18:09

bouwkast merged commit d5726e6 into master Oct 31, 2025
154 of 155 checks passed

bouwkast deleted the andrew/fix-exporter-settings branch October 31, 2025 20:27

github-actions bot added this to the vNext-v3 milestone Oct 31, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add fix for whitespace in exporter settings and metrics URL#7747

Add fix for whitespace in exporter settings and metrics URL#7747
bouwkast merged 1 commit intomasterfrom
andrew/fix-exporter-settings

andrewlock commented Oct 31, 2025 •

edited

Loading

Uh oh!

andrewlock Oct 31, 2025

Uh oh!

andrewlock Oct 31, 2025

Uh oh!

andrewlock Oct 31, 2025

Uh oh!

andrewlock Oct 31, 2025

Uh oh!

dd-trace-dotnet-ci-bot bot commented Oct 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

andrewlock commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

andrewlock Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

andrewlock Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

andrewlock Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

andrewlock Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

dd-trace-dotnet-ci-bot bot commented Oct 31, 2025

Execution-Time Benchmarks Report ⏱️

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

andrewlock commented Oct 31, 2025 •

edited

Loading