DataDog · andrewlock · Oct 27, 2021 · Oct 7, 2021 · Oct 14, 2021 · Oct 8, 2021
@@ -4,6 +4,7 @@
 // </copyright>
 
 using System;
+using System.Reflection;
 using System.Runtime.CompilerServices;
 using Datadog.Trace.DuckTyping;
 using Datadog.Trace.Logging;
@@ -26,7 +27,7 @@ internal static void LogException(Exception exception, string message = null)
         {
             // ReSharper disable twice ExplicitCallerInfoArgument
             Log.Error(exception, message ?? exception?.Message);
-            if (exception is DuckTypeException)
+            if (exception is DuckTypeException or TargetInvocationException { InnerException: DuckTypeException })
             {
                 Log.Warning($"DuckTypeException has been detected, the integration <{typeof(TIntegration)}, {typeof(TTarget)}> will be disabled.");
                 _disableIntegration = true;

@@ -27,42 +27,16 @@ public enum DuckKind
     /// <summary>
     /// Duck attribute
     /// </summary>
-    [AttributeUsage(AttributeTargets.Property | AttributeTargets.Method | AttributeTargets.Field, AllowMultiple = false)]
-    public class DuckAttribute : Attribute
+    public class DuckAttribute : DuckAttributeBase
     {
         /// <summary>
         /// Default BindingFlags
         /// </summary>
         public const BindingFlags DefaultFlags = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Static | BindingFlags.Instance | BindingFlags.FlattenHierarchy;
 
-        /// <summary>
-        /// Gets or sets the underlying type member name
-        /// </summary>
-        public string Name { get; set; }
-
         /// <summary>
         /// Gets or sets duck kind
         /// </summary>
         public DuckKind Kind { get; set; } = DuckKind.Property;
-
-        /// <summary>
-        /// Gets or sets the binding flags
-        /// </summary>
-        public BindingFlags BindingFlags { get; set; } = DefaultFlags;
-
-        /// <summary>
-        /// Gets or sets the generic parameter type names definition for a generic method call (required when calling generic methods and instance type is non public)
-        /// </summary>
-        public string[] GenericParameterTypeNames { get; set; }
-
-        /// <summary>
-        /// Gets or sets the parameter type names of the target method (optional / used to disambiguation)
-        /// </summary>
-        public string[] ParameterTypeNames { get; set; }
-
-        /// <summary>
-        /// Gets or sets the explicit interface type name
-        /// </summary>
-        public string ExplicitInterfaceTypeName { get; set; }
     }
 }
@@ -0,0 +1,43 @@
+// <copyright file="DuckAttributeBase.cs" company="Datadog">
+// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
+// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
+// </copyright>
+
+using System;
+using System.ComponentModel;
+using System.Reflection;
+
+namespace Datadog.Trace.DuckTyping
+{
+    /// <summary>
+    /// Duck attribute
+    /// </summary>
+    [AttributeUsage(AttributeTargets.Property | AttributeTargets.Method | AttributeTargets.Field, AllowMultiple = false)]
+    public abstract class DuckAttributeBase : Attribute
+    {
+        /// <summary>
+        /// Gets or sets the underlying type member name
+        /// </summary>
+        public string Name { get; set; }
+
+        /// <summary>
+        /// Gets or sets the binding flags
+        /// </summary>
+        public BindingFlags BindingFlags { get; set; } = DuckAttribute.DefaultFlags;
+
+        /// <summary>
+        /// Gets or sets the generic parameter type names definition for a generic method call (required when calling generic methods and instance type is non public)
+        /// </summary>
+        public string[] GenericParameterTypeNames { get; set; }
+
+        /// <summary>
+        /// Gets or sets the parameter type names of the target method (optional / used to disambiguation)
+        /// </summary>
+        public string[] ParameterTypeNames { get; set; }
+
+        /// <summary>
+        /// Gets or sets the explicit interface type name
+        /// </summary>
+        public string ExplicitInterfaceTypeName { get; set; }
+    }
+}
@@ -10,28 +10,7 @@ namespace Datadog.Trace.DuckTyping
     /// <summary>
     /// Duck reverse method attribute
     /// </summary>
-    [AttributeUsage(AttributeTargets.Method)]
-    public class DuckReverseMethodAttribute : Attribute
+    public class DuckReverseMethodAttribute : DuckAttributeBase
     {
-        /// <summary>
-        /// Initializes a new instance of the <see cref="DuckReverseMethodAttribute"/> class.
-        /// </summary>
-        public DuckReverseMethodAttribute()
-        {
-        }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="DuckReverseMethodAttribute"/> class.
-        /// </summary>
-        /// <param name="arguments">Methods arguments</param>
-        public DuckReverseMethodAttribute(params string[] arguments)
-        {
-            Arguments = arguments;
-        }
-
-        /// <summary>
-        /// Gets the methods arguments
-        /// </summary>
-        public string[] Arguments { get; private set; }
     }
 }
@@ -83,6 +83,8 @@ private static MethodBuilder GetFieldGetMethod(TypeBuilder proxyTypeBuilder, Typ
                     il.Emit(OpCodes.Box, targetField.FieldType);
                 }
 
+                // WARNING: If targetField.FieldType cannot be duck cast to proxyMemberReturnType
+                // this will throw an exception at runtime when accessing the member
                 // We call DuckType.CreateCache<>.Create()
                 MethodInfo getProxyMethodInfo = typeof(CreateCache<>)
                     .MakeGenericType(proxyMemberReturnType).GetMethod("Create");