Skip to content

update integrations.json#1685

Closed
lucaspimentel wants to merge 1 commit into
masterfrom
lpimentel/fix-integrations-json
Closed

update integrations.json#1685
lucaspimentel wants to merge 1 commit into
masterfrom
lpimentel/fix-integrations-json

Conversation

@lucaspimentel

Copy link
Copy Markdown
Member

Regenerate integrations.json which got out of sync in #1647.
@robertpi and @anna-git please confirm since this is used for AppSec, I believe.

@lucaspimentel lucaspimentel added the area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) label Aug 12, 2021
@lucaspimentel lucaspimentel requested review from a team, anna-git and robertpi August 12, 2021 21:29

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, this integration is for 2.x+, and returns void. That was split into two integrations - a 3.x+ integration that returns void, and a 2.x-3 which returns RequestDelegate.

@anna-git

anna-git commented Aug 13, 2021

Copy link
Copy Markdown
Contributor

Indeed there was one too many AspNetCore, I checked on the former appsec branch and it wasn't regenerated 🙇

@colin-higgins

Copy link
Copy Markdown
Member

This is handled in the 1.28.3-prerelease PR: #1688

@lucaspimentel lucaspimentel deleted the lpimentel/fix-integrations-json branch August 25, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants