Fix issue with CustomSerilogLogProvider#1558
Closed
zacharycmontoya wants to merge 1 commit into
Closed
Conversation
…erilog where the Serilog.Context.LogContext type has the Push method that takes in exactly one ILogEventEnricher. This fixes a crash condition in earlier versions of the library where the method does not exist. In those cases, fall back to the original LibLog implementation where we call PushProperty on each field.
Contributor
Author
|
Superseded by #1560 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restrict usage of optimized
CustomSerilogLogProviderto versions of Serilog where theSerilog.Context.LogContexttype has thePushmethod that takes in exactly oneILogEventEnricher. This fixes a crash condition in earlier versions of the library where the method does not exist. In those cases, fall back to the original LibLog implementation where we callPushPropertyon each field.@DataDog/apm-dotnet