Refactor folder locations#1530
Conversation
…dditionally, make all required changes for Datadog.Trace.sln, Datadog.Trace.Minimal.sln, and Datadog.Trace.Native.sln to build, and update .gitignore.
…ory as everything else: tracer/bin/windows-tracer-home
…hich is also the NUKE root directory
andrewlock
left a comment
There was a problem hiding this comment.
Clicked through about 1500 files and they all said "content is identical", and it builds, so LGTM! 👍
| tracer/deploy/linux/ | ||
| tracer/deploy/AzureAppServices/ | ||
| !tracer/build/artifacts |
There was a problem hiding this comment.
Are these actually required? I think they're probably left overs from an old build process?
There was a problem hiding this comment.
!tracer/build/artifacts seems correct, because there's a file there that we don't want to ignore. I'm guessing this was added because this line ignores folders named artifacts. Maybe the better fix is to remove both.
Line 49 in 13cdc48
There was a problem hiding this comment.
Regarding deploy/, the wix project that builds the msi used to live there before we moved it in #973. I don't think we use deploy/AzureAppServices/, either. @colin-higgins may know better.
| AbsolutePath MsBuildProject => RootDirectory / "Datadog.Trace.proj"; | ||
|
|
||
| AbsolutePath OutputDirectory => RootDirectory / "bin"; | ||
| AbsolutePath OutputDirectory => RootDirectory / "tracer" / "bin"; |
There was a problem hiding this comment.
nit: we should probably extract RootDirectory / "tracer" to a property. Not for this PR, just a note!
|
Closed via #1748 |
Primarily work done by @zacharycmontoya to move the src/test etc folders into a tracer sub-directory.
I just did the final pieces to fix minor CI issues, so Ill defer to Zach for details:
Changes
This PR moves almost all of the code related to development/test/build of the .NET Tracer into a
/tracerdirectory to allow for better code partitioning when we add more products into the repo. File changes include:/to/tracer//to/tracer//src/binto/tracer/bin@DataDog/apm-dotnet