RUM-15877: Add fed2 endpoint to DatadogSite#3383
RUM-15877: Add fed2 endpoint to DatadogSite#3383gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e392dc9a02
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /** | ||
| * The US2_FED site (FedRAMP compatible): [fed2.ddog-gov.com](https://fed2.ddog-gov.com). | ||
| */ | ||
| US2_FED("us2_fed", "browser-intake-fed2-ddog-gov.com"), |
There was a problem hiding this comment.
Use the resolvable Fed2 intake host
When an app selects DatadogSite.US2_FED, the default request factories build their upload URLs from site.intakeEndpoint; with browser-intake-fed2-ddog-gov.com those uploads target a host that does not resolve from DNS, while the Fed2 browser intake host resolves as browser-intake-fed2.ddog-gov.com. This makes the new site unable to send RUM/logs/traces/replay/profile data unless users configure custom endpoints.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
This is a very nice catch! Fixed. The correct url is browser-intake-us2-ddog-gov.com, confirmed with the backend team.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3383 +/- ##
===========================================
+ Coverage 71.99% 72.18% +0.19%
===========================================
Files 956 956
Lines 35307 35307
Branches 5861 5861
===========================================
+ Hits 25418 25484 +66
+ Misses 8284 8242 -42
+ Partials 1605 1581 -24
🚀 New features to boost your workflow:
|
e392dc9 to
8904cc4
Compare
8904cc4 to
2107c7e
Compare
| DatadogSite.AP1 -> "ap1.datadoghq.com" | ||
| DatadogSite.AP2 -> "ap2.datadoghq.com" | ||
| DatadogSite.US1_FED -> "ddog-gov.com" | ||
| DatadogSite.US2_FED -> "us2.ddog-gov.com" |
There was a problem hiding this comment.
Sorry, one more fix. The site was also wrong. This time - double checked with browser DataDog/browser-sdk#4495.
There was a problem hiding this comment.
although the old one also resolves and opens a page, but maybe the old name is something to be deprecated
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
What does this PR do?
Adding a new DC similar to what iOS already did here DataDog/dd-sdk-ios#2827
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)