cmd/trace-agent: ignore SIGPIPE signal #486
Conversation
|
PR looks good. There's a problem with CircleCI here. Not sure why it isn't running. Because of that I can't merge either. Do you wanna try renaming the commit message? Perhaps that'll trigger CI. Use the PR title. |
2160da9 to
9e1f171
Compare
|
Maybe CircleCI isn't triggered because I made the PR from a fork. I can't create a branch on the main repo |
|
@palazzem can you please do something about this? e.g. give me more power,
change some settings or merge yourself?
…On Wed, 10 Oct 2018 at 17:29, Rémi Calixte ***@***.***> wrote:
Maybe CircleCI isn't triggered because I made the PR from a fork. I can't
create a branch on the main repo
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#486 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGYGlPOb7p1fEzWdMeR8BQOO1yyqt4pvks5ujhJLgaJpZM4XT1Fq>
.
|
98bd8a0 to
9e1f171
Compare
|
@gbbr CircleCI is fine now. Let's wait for the other PR to be merged before pushing this in our 6.6.0. I want 1-1 feature parity with the core Agent. |
2b6d7ae to
5543cf0
Compare
|
I think the fail in circleci is unrelated to the latest changes |
|
DataDog/datadog-agent#2416 is merged, we could merge this now |
gbbr
left a comment
There was a problem hiding this comment.
LGTM. Slight nit about the comment. Will merge after.
cmd/trace-agent/main.go
Outdated
| log.Infof("received signal %d (%v)", signo, signo) | ||
| onSignal() | ||
| return | ||
| // By default systemd redirects the stdout to journald. When journald is stopped or crashes we receive a SIGPIPE signal. |
There was a problem hiding this comment.
Please move this comment inside the case statement and remove the other one (// do nothing)
|
Please consider my comment in the other PR: DataDog/datadog-agent#2416 (comment) |
caf0b0c to
807c44b
Compare
What does this PR do?
By default systemd redirect the stdout to journald. When journald is stopped or crashes we receive a SIGPIPE signal. Go ignore SIGPIPE signals unless it is when stdout or stdout is closed, in this case the agent is stopped. We don't want that so we intercept the SIGPIPE signals and just discard them.
Motivation
Fix DataDog/datadog-agent#1555
Related datadog-agent PR: DataDog/datadog-agent#2416