Pin datadog-ci to v3 for v1.2.4 action release#52
Merged
colemaring merged 1 commit intomainfrom Oct 9, 2025
Merged
Conversation
Drarig29
approved these changes
Oct 9, 2025
jasonforal
approved these changes
Oct 9, 2025
Contributor
jasonforal
left a comment
There was a problem hiding this comment.
Nice job with the testing of this!
Collaborator
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
This pull request was merged directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Users of action v1.2.4 release should see a warning message when using the Sarif upload command from datadog-ci on pull_request events.
Testing Methodology
To ensure that the
RUN npm install -g @datadog/datadog-ci@^3 && npm list -g @datadog/datadog-ciactually pins todatadog-ci@v3even whendatadog-ci@v4is released, I've set up the following test:RUN npm install -g @datadog/datadog-ci@^2 && npm list -g @datadog/datadog-cinpm list -g @datadog/datadog-ciin container@datadog/datadog-ci@2.48.0, even though a new version exists3.22.2This confirms that we can pin to v3 even when v4 exists (in the future)