Add shim Docker image to update @datadog/datadog-ci#51
Merged
jasonforal merged 1 commit intomainfrom Mar 25, 2025
Merged
Conversation
tanishq-dubey
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This action uses the datadog-static-analyzer container, which pre-installs
datadog-ci(source here). This freezesdatadog-cito the latest at the time of container compilation, which isn't the intended behavior.In the long term, we will remove the bundled
datadog-cifrom the datadog-static-analyzer container (it's an anti-pattern to have an all-in-one container like this). But in the short term, we can fix this by introducing a shim.This PR creates a new container that takes the original datadog-static-analyzer container and updates datadog-ci, and exposes this (transparently) as a new container. Note that there is a small execution time overhead because a new Docker image must be dynamically generated every time the action is run (initial runs showed ~30 seconds).