Conversation
estherk15
approved these changes
Feb 3, 2025
jasonforal
approved these changes
Feb 6, 2025
Contributor
jasonforal
left a comment
There was a problem hiding this comment.
Approving, but see comment about language, in case you think it should be changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
We want to be able to deactivate static analysis if the customer only wants to run secrets scanning.
Solution
Add a new configuration option to enable/disable static analysis. It will pass an environment variable used by our github action script in the docker image for the analyzer.
Related static-analyzer PR