Conversation
amaanq
approved these changes
Nov 3, 2024
|
Stumbled across this when looking into why we suddenly started getting warnings in our workflow runs this morning: Probably should document this change somewhere or have a deprecation message for those that have already implemented this action. |
Contributor
|
@tcs-cclaflin thanks for reporting that -- we'll have this fixed by #48. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
Remove
serviceandenvas we do not want to have the user specify them.Solution
Remove them from the GitHub action.
Testing
See here https://github.com/DataDog/datadog-static-analyzer-test-repo/actions/runs/11664561121/job/32475339303
Notes
Should be tested and merged only after this PR is merged.