Merged
Conversation
This comment has been minimized.
This comment has been minimized.
jacobotb
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
As part of the config file v2 rollout, I need to be able to detect if a local configuration file is v1 or v2 and adjust control flow accordingly (until the config merge endpoint on the backend can be updated, the analyzer needs to error when handling a v2 config).
get_confighas highly-nested control flow, making this difficult to do in an understandable way.What is your solution?
ConfigFileor convert to base64 from that StringWhat the reviewer should know
expectwas replaced with proper Result propagation (anyhow::Context).