Skip to content

Bump Rust 1.91.1 & dd_sds version#793

Merged
dd-mergequeue[bot] merged 6 commits intomainfrom
isabella.garza/bump-rust-1.91.1
Nov 13, 2025
Merged

Bump Rust 1.91.1 & dd_sds version#793
dd-mergequeue[bot] merged 6 commits intomainfrom
isabella.garza/bump-rust-1.91.1

Conversation

@isabella-garza-datadog
Copy link
Contributor

What problem are you trying to solve?

In order to support new Secondary Validators implemented in dd_sds, we need to bump the version of dd_sds. However, the current version of dd_sds has been updated to use Rust 1.90, but datadog-static-analyzer is still using Rust 1.86. Attempting to bump the dd_sds dependency directly results in build incompatibilities due to the compiler version mismatch.

What is your solution?

This PR updates the Rust toolchain version from 1.86 to 1.91.1 (the latest stable version). This ensures compatibility with the new version of dd_sds and resolves the build issues encountered when trying to update the library.
After updating the toolchain, the dependency on dd_sds was successfully bumped, and the code compiles and runs as expected.

Alternatives considered

  • Downgrading dd_sds: Not viable, as it would prevent us from taking advantage of the latest improvements and security updates in the library.
  • Manually patching dd_sds for 1.86 compatibility: Would introduce unnecessary maintenance overhead and diverge from the upstream version.
  • Upgrading only to Rust 1.90: Since 1.91.1 is the latest stable release, it’s preferable to stay current with the toolchain to minimize future upgrade friction.

What the reviewer should know

@isabella-garza-datadog isabella-garza-datadog force-pushed the isabella.garza/bump-rust-1.91.1 branch from 4528b1a to 00d77ff Compare November 12, 2025 14:29
@isabella-garza-datadog isabella-garza-datadog marked this pull request as ready for review November 12, 2025 23:58
@isabella-garza-datadog isabella-garza-datadog requested a review from a team as a code owner November 12, 2025 23:58
@isabella-garza-datadog
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Nov 13, 2025

View all feedbacks in Devflow UI.

2025-11-13 15:33:40 UTC ℹ️ Start processing command /merge


2025-11-13 15:33:48 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 33m (p90).


2025-11-13 15:56:29 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 79101aa into main Nov 13, 2025
82 checks passed
@dd-mergequeue dd-mergequeue bot deleted the isabella.garza/bump-rust-1.91.1 branch November 13, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants