Bump Rust 1.91.1 & dd_sds version#793
Merged
dd-mergequeue[bot] merged 6 commits intomainfrom Nov 13, 2025
Merged
Conversation
4528b1a to
00d77ff
Compare
fuchsnj
approved these changes
Nov 12, 2025
jasonforal
approved these changes
Nov 12, 2025
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
In order to support new Secondary Validators implemented in
dd_sds, we need to bump the version ofdd_sds. However, the current version ofdd_sdshas been updated to use Rust 1.90, butdatadog-static-analyzeris still using Rust 1.86. Attempting to bump thedd_sdsdependency directly results in build incompatibilities due to the compiler version mismatch.What is your solution?
This PR updates the Rust toolchain version from 1.86 to 1.91.1 (the latest stable version). This ensures compatibility with the new version of
dd_sdsand resolves the build issues encountered when trying to update the library.After updating the toolchain, the dependency on
dd_sdswas successfully bumped, and the code compiles and runs as expected.Alternatives considered
What the reviewer should know