Conversation
de4350c to
10e329c
Compare
…om component properties
46b3301 to
e709d02
Compare
Drarig29
approved these changes
Mar 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Motivation
SBOM component property keys are being migrated from vendor-specific prefixes (
osv-scanner:,datadog-sbom-generator:) to a unified canonical format (datadog:). During this transition period, SBOMs can contain either the old legacy keys or the new canonical keys (or both).datadog-cimust be able to handle both formats seamlessly to avoid dropping data.📝 Summary
LEGACY_*(osv-scanner:anddatadog-sbom-generator:prefixes) and introduced new canonical constants withdatadog:prefix (PACKAGE_MANAGER_PROPERTY_KEY,IS_DEPENDENCY_DIRECT_PROPERTY_KEY,IS_DEPENDENCY_DEV_ENVIRONMENT_PROPERTY_KEY,EXCLUSION_KEY,REACHABLE_SYMBOL_LOCATION_KEY_PREFIX).payload.tsto parse both legacy and canonical property names when building dependencies. Canonical (datadog:) values take precedence over legacy ones when both are present.datadog-sbom-generator:exclusion) and canonical (datadog:exclusion) keys are merged via aSetto avoid duplicates.datadog-sbom-generator:reachable-symbol-location:*anddatadog:reachable-symbol-location:*are collected together; deduplication is delegated to another component.sbom-with-both-legacy-canonical-properties.json) and a corresponding test case that validates the dual-parsing behaviour, priority rules, and merging logic.🧪 Testing
🚧 Staging validation
Tested locally comparing the payload output using as input different SBOM files
🆘 Recovery
Notes for on-call - select only one: