Skip to content

[chores] Fail pre-approval-checks job if no PR#2091

Merged
Drarig29 merged 1 commit intomasterfrom
corentin.girard/fail-pre-approval-checks-when-no-pr
Feb 4, 2026
Merged

[chores] Fail pre-approval-checks job if no PR#2091
Drarig29 merged 1 commit intomasterfrom
corentin.girard/fail-pre-approval-checks-when-no-pr

Conversation

@Drarig29
Copy link
Contributor

@Drarig29 Drarig29 commented Feb 4, 2026

What and why?

We should block the npm-publish job until a release PR is opened.

How?

  • Fail pre-approval-checks job if no release PR
  • Make release instructions clearer

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@Drarig29 Drarig29 added the chores Related to the CI or developer experience label Feb 4, 2026
@Drarig29 Drarig29 requested review from a team as code owners February 4, 2026 10:00
@Drarig29 Drarig29 merged commit 3c14c47 into master Feb 4, 2026
28 checks passed
@Drarig29 Drarig29 deleted the corentin.girard/fail-pre-approval-checks-when-no-pr branch February 4, 2026 13:36
@piloulacdog piloulacdog mentioned this pull request Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chores Related to the CI or developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants