Conversation
buranmert
reviewed
Jan 26, 2026
Comment on lines
+550
to
+552
| // Final validation: ensure we have a non-empty version after all resolution attempts | ||
| if (!this.version || this.version.trim().length === 0) { | ||
| this.context.stderr.write(renderArgumentMissingError('version')) |
Contributor
There was a problem hiding this comment.
you also need to update README in this directory. it says version is optional, we should state it's required
Contributor
Author
There was a problem hiding this comment.
Done. Updated the README in the latest commit.
Context:
- This PR is primarily a bug fix. The --version parameters was never truly "optional" - a version was always required for the upload to succeeded (either from the flag
versionor from thepubspec.yaml). - The bug allowed to pass whitespace-only values like
--version " ", and this would bypass the pubspec fallback(!this.version && (await this.parsePubspecVersion(this.pubspecLocation))(since non-empty strings are truthy in JS). - The fix ensures whitespace-only versions are treated the same as empty/missing versions, and adds an explicit client-side error message when no valid version can be determined.
Added a note in the README.MD, clarifying the need for the version having a fallback for pubspec.yaml.
Drarig29
approved these changes
Jan 27, 2026
Drarig29
approved these changes
Jan 27, 2026
Contributor
Drarig29
left a comment
There was a problem hiding this comment.
LGTM. This breaking change is a bug fix, so we won't cut a major release for it.
Clarify version requirement for upload in README.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
--versionparameter in theflutter-symbols uploadcommand to prevent uploads with empty or invalid version strings.How?
--versionis not provided, empty, or whitespace-only, the command now attempts to extract the version frompubspec.yamlError: parameter "version" is requiredReview checklist
Test check
yarn test packages/datadog-ci/src/commands/flutter-symbols