Skip to content

[chores] Add label guardrails in release process#2063

Merged
Drarig29 merged 8 commits intomasterfrom
corentin.girard/change-job-order-in-release-process
Jan 20, 2026
Merged

[chores] Add label guardrails in release process#2063
Drarig29 merged 8 commits intomasterfrom
corentin.girard/change-job-order-in-release-process

Conversation

@Drarig29
Copy link
Contributor

@Drarig29 Drarig29 commented Jan 19, 2026

What and why?

This PR changes the job order during the release process to have quick access to the draft release.

After the draft release is created, pre-approval-checks and all build-* jobs run in parallel, and are required before starting npm-publish.

And the pre-approval-checks job can add a oidc-setup-required ⚠️ label, which needs to be cleared with a oidc-setup-done ✅ label. Adding oidc-setup-done ✅ is now part of the first-time publishing process.

How?

  • Move the pre-approval-checks job after the create-draft-release job
  • Change the single line YAML array into a multiline YAML array for better readability
  • Fix the ARM build jobs not being listed as requirements
  • Add pre-approval-checks as a direct requirement for npm-publish
  • Add label management

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

Tested with GITHUB_TOKEN=$(gh auth token) GITHUB_SHA=04b0d1cc47ab5f3ad479d0603df5acc1c6e01ba0 bin/check-npm-packages.sh on #2062

@Drarig29 Drarig29 requested a review from a team as a code owner January 19, 2026 13:52
@Drarig29 Drarig29 added the chores Related to the CI or developer experience label Jan 19, 2026
@Drarig29 Drarig29 changed the title [chores] Change job order in release process [chores] Add label guardrails in release process Jan 19, 2026
Comment on lines +224 to +232
echo
echo -e "${RED}${BOLD}⚠️ You are not done!${NC} Please setup OIDC on each package at the links below."
echo

for pkg in "${missing_packages[@]}"; do
echo -e " - Opening ${BLUE}https://www.npmjs.com/package/$pkg/access${NC}"
open "https://www.npmjs.com/package/$pkg/access"
done
echo No newline at end of file
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@Drarig29 Drarig29 requested a review from GabrielAnca January 20, 2026 11:02
@Drarig29 Drarig29 merged commit a325126 into master Jan 20, 2026
26 checks passed
@Drarig29 Drarig29 deleted the corentin.girard/change-job-order-in-release-process branch January 20, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chores Related to the CI or developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants