Skip to content

Coverage upload: add tags for codeowners and coverage config path and sha#2022

Merged
nikita-tkachenko-datadog merged 2 commits intomasterfrom
nikita-tkachenko/coverage-upload-codeowners
Dec 17, 2025
Merged

Coverage upload: add tags for codeowners and coverage config path and sha#2022
nikita-tkachenko-datadog merged 2 commits intomasterfrom
nikita-tkachenko/coverage-upload-codeowners

Conversation

@nikita-tkachenko-datadog
Copy link
Contributor

What and why?

Updates coverage upload command: with these changes the event will contain tags for path/sha of CODEOWNERS file and coverage config file.

Normally this information is obtained in the backend using gitdb, but for some high load repos gitdb cannot keep up with the added commits, so the CLI will try to get hold of this info whenever it can to ease the load on the backend.

How?

simplegit is used to get the SHAs: both for CODEOWNERS and for the coverage config the code will iterate over the list of possible paths, checking for which one sha can be successfully obtained.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the software-delivery Related to [coverage, deployment, dora, junit, measure, tag, trace] label Dec 16, 2025
Copy link
Contributor

@GabrielAnca GabrielAnca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! As the upload command grows in size and complexity, it would be great to have tests that verify the functionality. I don't want to block you since the file already had no tests

@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 3d70e49 into master Dec 17, 2025
23 of 24 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/coverage-upload-codeowners branch December 17, 2025 12:41
@nikita-tkachenko-datadog nikita-tkachenko-datadog mentioned this pull request Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

software-delivery Related to [coverage, deployment, dora, junit, measure, tag, trace]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants